You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Ying He (JIRA)" <ji...@apache.org> on 2009/10/09 00:44:31 UTC
[jira] Created: (PIG-1000) InternalCachedBag.java generates javac
warning and findbug warning
InternalCachedBag.java generates javac warning and findbug warning
------------------------------------------------------------------
Key: PIG-1000
URL: https://issues.apache.org/jira/browse/PIG-1000
Project: Pig
Issue Type: Improvement
Affects Versions: 0.4.0
Reporter: Ying He
Assignee: Ying He
Fix For: 0.6.0
POPackage uses DefaultDataBag during reduce process to hold data. It is registered with SpillableMemoryManager and prone to OutOfMemoryException. It's better to pro-actively managers the usage of the memory. The bag fills in memory to a specified amount, and dump the rest the disk. The amount of memory to hold tuples is configurable. This can avoid out of memory error.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1000) InternalCachedBag.java generates javac
warning and findbug warning
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765744#action_12765744 ]
Hadoop QA commented on PIG-1000:
--------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12421679/PIG-1000.patch
against trunk revision 824980.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/79/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/79/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/79/console
This message is automatically generated.
> InternalCachedBag.java generates javac warning and findbug warning
> ------------------------------------------------------------------
>
> Key: PIG-1000
> URL: https://issues.apache.org/jira/browse/PIG-1000
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.4.0
> Reporter: Ying He
> Assignee: Ying He
> Fix For: 0.6.0
>
> Attachments: PIG-1000.patch
>
>
> patch submitted by PIG-975 generates javac warning and findbug warning
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1000) InternalCachedBag.java generates javac
warning and findbug warning
Posted by "Ying He (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ying He updated PIG-1000:
-------------------------
Attachment: PIG-1000.patch
fix javac warning and findbug warning
> InternalCachedBag.java generates javac warning and findbug warning
> ------------------------------------------------------------------
>
> Key: PIG-1000
> URL: https://issues.apache.org/jira/browse/PIG-1000
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.4.0
> Reporter: Ying He
> Assignee: Ying He
> Fix For: 0.6.0
>
> Attachments: PIG-1000.patch
>
>
> POPackage uses DefaultDataBag during reduce process to hold data. It is registered with SpillableMemoryManager and prone to OutOfMemoryException. It's better to pro-actively managers the usage of the memory. The bag fills in memory to a specified amount, and dump the rest the disk. The amount of memory to hold tuples is configurable. This can avoid out of memory error.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1000) InternalCachedBag.java generates javac
warning and findbug warning
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765660#action_12765660 ]
Daniel Dai commented on PIG-1000:
---------------------------------
+1
> InternalCachedBag.java generates javac warning and findbug warning
> ------------------------------------------------------------------
>
> Key: PIG-1000
> URL: https://issues.apache.org/jira/browse/PIG-1000
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.4.0
> Reporter: Ying He
> Assignee: Ying He
> Fix For: 0.6.0
>
> Attachments: PIG-1000.patch
>
>
> patch submitted by PIG-975 generates javac warning and findbug warning
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1000) InternalCachedBag.java generates javac
warning and findbug warning
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1000:
----------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
This patch is to address javacc and findbug warnings, no unit test needed. Patch committed. Thanks Ying!
> InternalCachedBag.java generates javac warning and findbug warning
> ------------------------------------------------------------------
>
> Key: PIG-1000
> URL: https://issues.apache.org/jira/browse/PIG-1000
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.4.0
> Reporter: Ying He
> Assignee: Ying He
> Fix For: 0.6.0
>
> Attachments: PIG-1000.patch
>
>
> patch submitted by PIG-975 generates javac warning and findbug warning
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1000) InternalCachedBag.java generates javac
warning and findbug warning
Posted by "Ying He (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ying He updated PIG-1000:
-------------------------
Description: patch submitted by PIG-975 generates javac warning and findbug warning (was: POPackage uses DefaultDataBag during reduce process to hold data. It is registered with SpillableMemoryManager and prone to OutOfMemoryException. It's better to pro-actively managers the usage of the memory. The bag fills in memory to a specified amount, and dump the rest the disk. The amount of memory to hold tuples is configurable. This can avoid out of memory error.)
Patch Info: [Patch Available]
> InternalCachedBag.java generates javac warning and findbug warning
> ------------------------------------------------------------------
>
> Key: PIG-1000
> URL: https://issues.apache.org/jira/browse/PIG-1000
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.4.0
> Reporter: Ying He
> Assignee: Ying He
> Fix For: 0.6.0
>
> Attachments: PIG-1000.patch
>
>
> patch submitted by PIG-975 generates javac warning and findbug warning
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1000) InternalCachedBag.java generates javac
warning and findbug warning
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1000:
----------------------------
Status: Patch Available (was: Open)
> InternalCachedBag.java generates javac warning and findbug warning
> ------------------------------------------------------------------
>
> Key: PIG-1000
> URL: https://issues.apache.org/jira/browse/PIG-1000
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.4.0
> Reporter: Ying He
> Assignee: Ying He
> Fix For: 0.6.0
>
> Attachments: PIG-1000.patch
>
>
> patch submitted by PIG-975 generates javac warning and findbug warning
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.