You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Max Gekk (Jira)" <ji...@apache.org> on 2022/10/13 11:33:00 UTC

[jira] [Updated] (SPARK-40785) Check error classes in ExpressionParserSuite

     [ https://issues.apache.org/jira/browse/SPARK-40785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Max Gekk updated SPARK-40785:
-----------------------------
    Description: 
Check error classes in ExpressionParserSuite by using checkError(). For instance, replace

{code:scala}
intercept("a like 'pattern%' escape '##'", message)
{code}
by
{code:scala}
checkError(
      exception = parseException("a like 'pattern%' escape '##'"),
      errorClass = "...",
      parameters = Map.empty,
      context = ...)
{code}
at https://github.com/apache/spark/blob/c4a0360daf546baa9cc970ef805f52c40f384fe3/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala#L200



  was:
Check error classes in DDLParserSuite by using checkError(). For instance, replace

{code:scala}
intercept("CREATE TABLE my_tab (id bigint) SKEWED BY (id) ON (1,2,3)",
      "CREATE TABLE ... SKEWED BY")
{code}
by
{code:scala}
checkError(
      exception = parseException("CREATE TABLE my_tab (id bigint) SKEWED BY (id) ON (1,2,3)"),
      errorClass = "...",
      parameters = Map.empty,
      context = ...)
{code}
at https://github.com/apache/spark/blob/1a1341910249d545365ba3d6679c6943896dde22/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DDLParserSuite.scala#L546




> Check error classes in ExpressionParserSuite
> --------------------------------------------
>
>                 Key: SPARK-40785
>                 URL: https://issues.apache.org/jira/browse/SPARK-40785
>             Project: Spark
>          Issue Type: Sub-task
>          Components: SQL
>    Affects Versions: 3.4.0
>            Reporter: Max Gekk
>            Priority: Major
>              Labels: starter
>             Fix For: 3.4.0
>
>
> Check error classes in ExpressionParserSuite by using checkError(). For instance, replace
> {code:scala}
> intercept("a like 'pattern%' escape '##'", message)
> {code}
> by
> {code:scala}
> checkError(
>       exception = parseException("a like 'pattern%' escape '##'"),
>       errorClass = "...",
>       parameters = Map.empty,
>       context = ...)
> {code}
> at https://github.com/apache/spark/blob/c4a0360daf546baa9cc970ef805f52c40f384fe3/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala#L200



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org