You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2012/05/01 21:08:50 UTC
[jira] [Created] (HADOOP-8340) SNAPSHOT build versions should
compare as less than their eventual final release
Todd Lipcon created HADOOP-8340:
-----------------------------------
Summary: SNAPSHOT build versions should compare as less than their eventual final release
Key: HADOOP-8340
URL: https://issues.apache.org/jira/browse/HADOOP-8340
Project: Hadoop Common
Issue Type: Improvement
Components: util
Affects Versions: 2.0.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
Priority: Minor
We recently added a utility function to compare two version strings, based on splitting on '.'s and comparing each component. However, it considers a version like 2.0.0-SNAPSHOT as being greater than 2.0.0. This isn't right, since SNAPSHOT builds come before the final release.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8340) SNAPSHOT build versions should
compare as less than their eventual final release
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271998#comment-13271998 ]
Hudson commented on HADOOP-8340:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2291 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2291/])
HDFS-3341, HADOOP-8340. SNAPSHOT build versions should compare as less than their eventual release. Contributed by Todd Lipcon. (Revision 1336459)
Result = SUCCESS
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336459
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/VersionUtil.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestVersionUtil.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
> SNAPSHOT build versions should compare as less than their eventual final release
> --------------------------------------------------------------------------------
>
> Key: HADOOP-8340
> URL: https://issues.apache.org/jira/browse/HADOOP-8340
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: hadoop-8340.txt, hadoop-8340.txt
>
>
> We recently added a utility function to compare two version strings, based on splitting on '.'s and comparing each component. However, it considers a version like 2.0.0-SNAPSHOT as being greater than 2.0.0. This isn't right, since SNAPSHOT builds come before the final release.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8340) SNAPSHOT build versions should
compare as less than their eventual final release
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266030#comment-13266030 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-8340:
------------------------------------------------
+1 patch looks good.
> SNAPSHOT build versions should compare as less than their eventual final release
> --------------------------------------------------------------------------------
>
> Key: HADOOP-8340
> URL: https://issues.apache.org/jira/browse/HADOOP-8340
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: hadoop-8340.txt, hadoop-8340.txt
>
>
> We recently added a utility function to compare two version strings, based on splitting on '.'s and comparing each component. However, it considers a version like 2.0.0-SNAPSHOT as being greater than 2.0.0. This isn't right, since SNAPSHOT builds come before the final release.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8340) SNAPSHOT build versions should
compare as less than their eventual final release
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266007#comment-13266007 ]
Hadoop QA commented on HADOOP-8340:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12525199/hadoop-8340.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
-1 javadoc. The javadoc tool appears to have generated 16 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:
org.apache.hadoop.fs.viewfs.TestViewFsTrash
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/912//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/912//console
This message is automatically generated.
> SNAPSHOT build versions should compare as less than their eventual final release
> --------------------------------------------------------------------------------
>
> Key: HADOOP-8340
> URL: https://issues.apache.org/jira/browse/HADOOP-8340
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: hadoop-8340.txt
>
>
> We recently added a utility function to compare two version strings, based on splitting on '.'s and comparing each component. However, it considers a version like 2.0.0-SNAPSHOT as being greater than 2.0.0. This isn't right, since SNAPSHOT builds come before the final release.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8340) SNAPSHOT build versions should
compare as less than their eventual final release
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-8340:
--------------------------------
Status: Patch Available (was: Open)
> SNAPSHOT build versions should compare as less than their eventual final release
> --------------------------------------------------------------------------------
>
> Key: HADOOP-8340
> URL: https://issues.apache.org/jira/browse/HADOOP-8340
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: hadoop-8340.txt
>
>
> We recently added a utility function to compare two version strings, based on splitting on '.'s and comparing each component. However, it considers a version like 2.0.0-SNAPSHOT as being greater than 2.0.0. This isn't right, since SNAPSHOT builds come before the final release.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8340) SNAPSHOT build versions should
compare as less than their eventual final release
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272022#comment-13272022 ]
Hudson commented on HADOOP-8340:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2233 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2233/])
HDFS-3341, HADOOP-8340. SNAPSHOT build versions should compare as less than their eventual release. Contributed by Todd Lipcon. (Revision 1336459)
Result = ABORTED
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336459
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/VersionUtil.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestVersionUtil.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
> SNAPSHOT build versions should compare as less than their eventual final release
> --------------------------------------------------------------------------------
>
> Key: HADOOP-8340
> URL: https://issues.apache.org/jira/browse/HADOOP-8340
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: hadoop-8340.txt, hadoop-8340.txt
>
>
> We recently added a utility function to compare two version strings, based on splitting on '.'s and comparing each component. However, it considers a version like 2.0.0-SNAPSHOT as being greater than 2.0.0. This isn't right, since SNAPSHOT builds come before the final release.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8340) SNAPSHOT build versions should
compare as less than their eventual final release
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266024#comment-13266024 ]
Todd Lipcon commented on HADOOP-8340:
-------------------------------------
Worth noting that when we commit this, we also have to commit a change to HDFS to make the new minimum version 2.0.0-SNAPSHOT instead of 2.0.0. Then when we cut a 2.0 release candidate, we need to change the minimum back to 2.0.0 to disallow snapshots from connecting to 2.0.0 clusters.
> SNAPSHOT build versions should compare as less than their eventual final release
> --------------------------------------------------------------------------------
>
> Key: HADOOP-8340
> URL: https://issues.apache.org/jira/browse/HADOOP-8340
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: hadoop-8340.txt, hadoop-8340.txt
>
>
> We recently added a utility function to compare two version strings, based on splitting on '.'s and comparing each component. However, it considers a version like 2.0.0-SNAPSHOT as being greater than 2.0.0. This isn't right, since SNAPSHOT builds come before the final release.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (HADOOP-8340) SNAPSHOT build versions should
compare as less than their eventual final release
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy closed HADOOP-8340.
---------------------------------
> SNAPSHOT build versions should compare as less than their eventual final release
> --------------------------------------------------------------------------------
>
> Key: HADOOP-8340
> URL: https://issues.apache.org/jira/browse/HADOOP-8340
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 2.0.0-alpha
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 2.0.2-alpha
>
> Attachments: hadoop-8340.txt, hadoop-8340.txt
>
>
> We recently added a utility function to compare two version strings, based on splitting on '.'s and comparing each component. However, it considers a version like 2.0.0-SNAPSHOT as being greater than 2.0.0. This isn't right, since SNAPSHOT builds come before the final release.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8340) SNAPSHOT build versions should
compare as less than their eventual final release
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266019#comment-13266019 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-8340:
------------------------------------------------
Looks good. Minor comments:
- remove System.err.println
- Use com.google.common.collect.ComparisonChain, i.e.
{code}
return ComparisonChain.start()
.compare(version1Parts.length, version2Parts.length)
.compare(isSnapshot2, isSnapshot1)
.result();
{code}
> SNAPSHOT build versions should compare as less than their eventual final release
> --------------------------------------------------------------------------------
>
> Key: HADOOP-8340
> URL: https://issues.apache.org/jira/browse/HADOOP-8340
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: hadoop-8340.txt
>
>
> We recently added a utility function to compare two version strings, based on splitting on '.'s and comparing each component. However, it considers a version like 2.0.0-SNAPSHOT as being greater than 2.0.0. This isn't right, since SNAPSHOT builds come before the final release.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8340) SNAPSHOT build versions should
compare as less than their eventual final release
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272350#comment-13272350 ]
Hudson commented on HADOOP-8340:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #1075 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1075/])
HDFS-3341, HADOOP-8340. SNAPSHOT build versions should compare as less than their eventual release. Contributed by Todd Lipcon. (Revision 1336459)
Result = SUCCESS
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336459
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/VersionUtil.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestVersionUtil.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
> SNAPSHOT build versions should compare as less than their eventual final release
> --------------------------------------------------------------------------------
>
> Key: HADOOP-8340
> URL: https://issues.apache.org/jira/browse/HADOOP-8340
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: hadoop-8340.txt, hadoop-8340.txt
>
>
> We recently added a utility function to compare two version strings, based on splitting on '.'s and comparing each component. However, it considers a version like 2.0.0-SNAPSHOT as being greater than 2.0.0. This isn't right, since SNAPSHOT builds come before the final release.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8340) SNAPSHOT build versions should
compare as less than their eventual final release
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273225#comment-13273225 ]
Hudson commented on HADOOP-8340:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #1040 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1040/])
HDFS-3341, HADOOP-8340. SNAPSHOT build versions should compare as less than their eventual release. Contributed by Todd Lipcon. (Revision 1336459)
Result = FAILURE
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336459
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/VersionUtil.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestVersionUtil.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
> SNAPSHOT build versions should compare as less than their eventual final release
> --------------------------------------------------------------------------------
>
> Key: HADOOP-8340
> URL: https://issues.apache.org/jira/browse/HADOOP-8340
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: hadoop-8340.txt, hadoop-8340.txt
>
>
> We recently added a utility function to compare two version strings, based on splitting on '.'s and comparing each component. However, it considers a version like 2.0.0-SNAPSHOT as being greater than 2.0.0. This isn't right, since SNAPSHOT builds come before the final release.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8340) SNAPSHOT build versions should
compare as less than their eventual final release
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-8340:
--------------------------------
Attachment: hadoop-8340.txt
Oops, sorry about the println. I used ComparisonChain like you suggested - good call, much easier to follow.
> SNAPSHOT build versions should compare as less than their eventual final release
> --------------------------------------------------------------------------------
>
> Key: HADOOP-8340
> URL: https://issues.apache.org/jira/browse/HADOOP-8340
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: hadoop-8340.txt, hadoop-8340.txt
>
>
> We recently added a utility function to compare two version strings, based on splitting on '.'s and comparing each component. However, it considers a version like 2.0.0-SNAPSHOT as being greater than 2.0.0. This isn't right, since SNAPSHOT builds come before the final release.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8340) SNAPSHOT build versions should
compare as less than their eventual final release
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272000#comment-13272000 ]
Hudson commented on HADOOP-8340:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #2216 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2216/])
HDFS-3341, HADOOP-8340. SNAPSHOT build versions should compare as less than their eventual release. Contributed by Todd Lipcon. (Revision 1336459)
Result = SUCCESS
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336459
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/VersionUtil.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestVersionUtil.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
> SNAPSHOT build versions should compare as less than their eventual final release
> --------------------------------------------------------------------------------
>
> Key: HADOOP-8340
> URL: https://issues.apache.org/jira/browse/HADOOP-8340
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: hadoop-8340.txt, hadoop-8340.txt
>
>
> We recently added a utility function to compare two version strings, based on splitting on '.'s and comparing each component. However, it considers a version like 2.0.0-SNAPSHOT as being greater than 2.0.0. This isn't right, since SNAPSHOT builds come before the final release.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8340) SNAPSHOT build versions should
compare as less than their eventual final release
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-8340:
--------------------------------
Fix Version/s: (was: 2.0.0)
2.0.1
> SNAPSHOT build versions should compare as less than their eventual final release
> --------------------------------------------------------------------------------
>
> Key: HADOOP-8340
> URL: https://issues.apache.org/jira/browse/HADOOP-8340
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 2.0.1
>
> Attachments: hadoop-8340.txt, hadoop-8340.txt
>
>
> We recently added a utility function to compare two version strings, based on splitting on '.'s and comparing each component. However, it considers a version like 2.0.0-SNAPSHOT as being greater than 2.0.0. This isn't right, since SNAPSHOT builds come before the final release.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8340) SNAPSHOT build versions should
compare as less than their eventual final release
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266075#comment-13266075 ]
Hadoop QA commented on HADOOP-8340:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12525207/hadoop-8340.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
-1 javadoc. The javadoc tool appears to have generated 16 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:
org.apache.hadoop.fs.viewfs.TestViewFsTrash
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/915//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/915//console
This message is automatically generated.
> SNAPSHOT build versions should compare as less than their eventual final release
> --------------------------------------------------------------------------------
>
> Key: HADOOP-8340
> URL: https://issues.apache.org/jira/browse/HADOOP-8340
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: hadoop-8340.txt, hadoop-8340.txt
>
>
> We recently added a utility function to compare two version strings, based on splitting on '.'s and comparing each component. However, it considers a version like 2.0.0-SNAPSHOT as being greater than 2.0.0. This isn't right, since SNAPSHOT builds come before the final release.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8340) SNAPSHOT build versions should
compare as less than their eventual final release
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-8340:
--------------------------------
Attachment: hadoop-8340.txt
> SNAPSHOT build versions should compare as less than their eventual final release
> --------------------------------------------------------------------------------
>
> Key: HADOOP-8340
> URL: https://issues.apache.org/jira/browse/HADOOP-8340
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: hadoop-8340.txt
>
>
> We recently added a utility function to compare two version strings, based on splitting on '.'s and comparing each component. However, it considers a version like 2.0.0-SNAPSHOT as being greater than 2.0.0. This isn't right, since SNAPSHOT builds come before the final release.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8340) SNAPSHOT build versions should
compare as less than their eventual final release
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-8340:
--------------------------------
Resolution: Fixed
Fix Version/s: 2.0.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
> SNAPSHOT build versions should compare as less than their eventual final release
> --------------------------------------------------------------------------------
>
> Key: HADOOP-8340
> URL: https://issues.apache.org/jira/browse/HADOOP-8340
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: hadoop-8340.txt, hadoop-8340.txt
>
>
> We recently added a utility function to compare two version strings, based on splitting on '.'s and comparing each component. However, it considers a version like 2.0.0-SNAPSHOT as being greater than 2.0.0. This isn't right, since SNAPSHOT builds come before the final release.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira