You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Xiaoqiao He (Jira)" <ji...@apache.org> on 2021/01/02 13:14:00 UTC

[jira] [Commented] (HADOOP-16947) Stale record should be remove when generating SlowPeersReport

    [ https://issues.apache.org/jira/browse/HADOOP-16947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17257363#comment-17257363 ] 

Xiaoqiao He commented on HADOOP-16947:
--------------------------------------

Thanks [~huanghaibin] for your involving me here.  [^HADOOP-16947-007.patch] seems good for me almost. Some nit comments,
a. Please fix checkstyle and whitespace warning Jenkins reported.
b. Add javadoc to timestamp and specify what it means, also it is better to note why set recordValidityMs to NUM_WINDOWS_DEFAULT * WINDOW_SIZE_MS_DEFAULT.
+1 for [^HADOOP-16947-007.patch]  after update from me. cc [~elgoiri] would you mind to give another check? Thanks.

> Stale record should be remove when generating SlowPeersReport
> -------------------------------------------------------------
>
>                 Key: HADOOP-16947
>                 URL: https://issues.apache.org/jira/browse/HADOOP-16947
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Haibin Huang
>            Assignee: Haibin Huang
>            Priority: Major
>         Attachments: HADOOP-16947-001.patch, HADOOP-16947-002.patch, HADOOP-16947-003.patch, HADOOP-16947-004.patch, HADOOP-16947-005.patch, HADOOP-16947-006.patch, HADOOP-16947-007.patch, HDFS-14783, HDFS-14783-001.patch, HDFS-14783-002.patch, HDFS-14783-003.patch, HDFS-14783-004.patch, HDFS-14783-005.patch
>
>
> SlowPeersReport is generated by the SampleStat between tow dn, so it can present on nn's jmx like this:
> {code:java}
> "SlowPeersReport" :[{"SlowNode":"dn2","ReportingNodes":["dn1"]}]
> {code}
> In each period, MutableRollingAverages will do a rollOverAvgs(), it will generate a SumAndCount object which is based on SampleStat, and store it in a LinkedBlockingDeque<SumAndCount>, the deque will be used to generate  SlowPeersReport. And the old member of deque won't be removed until the queue is full. However, if dn1 don't send any packet to dn2 in the last of 36*300_000 ms, the deque will be filled with an old member, because the number of last SampleStat never change.I think these old SampleStats should be considered as expired message and ignore them when generating a new SlowPeersReport.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org