You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2025/09/24 06:13:52 UTC
[GH] (rocketmq/dev_merge_storeConfig): Workflow run "Build and Run Tests by Bazel" is working again!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git/dev_merge_storeConfig has succeeded.
Run started by GitHub user guyinyou (triggered by github-actions[bot]).
Head commit for run:
06699c78adaf7b62d029fbc3eb6404ac44010d83 / guyinyou <gu...@alibaba-inc.com>
refactor(store): merge enableRunningFlagsInFlush into isWriteWithoutMmap
These two configurations are typically used together and need to be enabled/disabled
simultaneously, so merging them simplifies configuration management.
Changes:
- Remove enableRunningFlagsInFlush configuration field and its getter/setter methods
- Update AllocateMappedFileService to use isWriteWithoutMmap for runningFlags logic
- Update CommitLog to use isWriteWithoutMmap for runningFlags logic
- Update writeWithoutMmap documentation to explain runningFlags behavior
Behavior after merge:
- When isWriteWithoutMmap=true: Use RandomAccessFile + set runningFlags to null
- When isWriteWithoutMmap=false: Use MappedByteBuffer + use normal runningFlags
This eliminates the need to manage two separate but related configurations,
reducing the chance of misconfiguration and simplifying the codebase.
Change-Id: I053a6ee5c8ba9be825db47940900ce01a8c707b9
Report URL: https://github.com/apache/rocketmq/actions/runs/17967941391
With regards,
GitHub Actions via GitBox