You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/11/17 03:26:45 UTC
[GitHub] [iotdb] HTHou opened a new pull request #4412: [DRAFT] IWritableMemChunkGroup Interface
HTHou opened a new pull request #4412:
URL: https://github.com/apache/iotdb/pull/4412
## Description
### Content1 ...
### Content2 ...
### Content3 ...
<!--
In each section, please describe design decisions made, including:
- Choice of algorithms
- Behavioral aspects. What configuration values are acceptable? How are corner cases and error
conditions handled, such as when there are insufficient resources?
- Class organization and design (how the logic is split between classes, inheritance, composition,
design patterns)
- Method organization and design (how the logic is split between methods, parameters and return types)
- Naming (class, method, API, configuration, HTTP endpoint, names of emitted metrics)
-->
<!-- It's good to describe an alternative design (or mention an alternative name) for every design
(or naming) decision point and compare the alternatives with the designs that you've implemented
(or the names you've chosen) to highlight the advantages of the chosen designs and names. -->
<!-- If there was a discussion of the design of the feature implemented in this PR elsewhere
(e. g. a "Proposal" issue, any other issue, or a thread in the development mailing list),
link to that discussion from this PR description and explain what have changed in your final design
compared to your original proposal or the consensus version in the end of the discussion.
If something hasn't changed since the original discussion, you can omit a detailed discussion of
those aspects of the design here, perhaps apart from brief mentioning for the sake of readability
of this PR description. -->
<!-- Some of the aspects mentioned above may be omitted for simple and small changes. -->
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] concurrent read
- [ ] concurrent write
- [ ] concurrent read and write
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods.
- [ ] added or updated version, __license__, or notice information
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious
for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold
for code coverage.
- [ ] added integration tests.
- [ ] been tested in a test IoTDB cluster.
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items
apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items
from the checklist above are strictly necessary, but it would be very helpful if you at least
self-review the PR. -->
<hr>
##### Key changed/added classes (or packages if there are too many classes) in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a change in pull request #4412: [DRAFT] IWritableMemChunkGroup Interface
Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #4412:
URL: https://github.com/apache/iotdb/pull/4412#discussion_r750859606
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/memtable/AlignedWritableMemChunkGroup.java
##########
@@ -0,0 +1,62 @@
+package org.apache.iotdb.db.engine.memtable;
Review comment:
```suggestion
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.iotdb.db.engine.memtable;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4412: [DRAFT] IWritableMemChunkGroup Interface
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4412:
URL: https://github.com/apache/iotdb/pull/4412#issuecomment-971168632
[](https://coveralls.io/builds/44322804)
Coverage increased (+0.02%) to 66.523% when pulling **21dc8a7be5b0a8315668810d792eba5c262e0128 on IWritableMemChunkGroup** into **96df1861643aa7f8f72d1bb276569d0eb68ee901 on master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4412: [DRAFT] IWritableMemChunkGroup Interface
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4412:
URL: https://github.com/apache/iotdb/pull/4412#issuecomment-971168632
[](https://coveralls.io/builds/44359818)
Coverage increased (+0.1%) to 66.612% when pulling **367c4318c14226438c832733473c64e9bc6c28c5 on IWritableMemChunkGroup** into **96df1861643aa7f8f72d1bb276569d0eb68ee901 on master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4412: [DRAFT] IWritableMemChunkGroup Interface
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4412:
URL: https://github.com/apache/iotdb/pull/4412#issuecomment-971168632
[](https://coveralls.io/builds/44322855)
Coverage increased (+0.03%) to 66.534% when pulling **21dc8a7be5b0a8315668810d792eba5c262e0128 on IWritableMemChunkGroup** into **96df1861643aa7f8f72d1bb276569d0eb68ee901 on master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4412: [DRAFT] IWritableMemChunkGroup Interface
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4412:
URL: https://github.com/apache/iotdb/pull/4412#issuecomment-971168632
[](https://coveralls.io/builds/44322838)
Coverage increased (+0.02%) to 66.52% when pulling **21dc8a7be5b0a8315668810d792eba5c262e0128 on IWritableMemChunkGroup** into **96df1861643aa7f8f72d1bb276569d0eb68ee901 on master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #4412: [DRAFT] IWritableMemChunkGroup Interface
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #4412:
URL: https://github.com/apache/iotdb/pull/4412#issuecomment-972571826
SonarCloud Quality Gate failed. 
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4412&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4412&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4412&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4412&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4412&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4412&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=4412&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=4412&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=4412&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4412&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4412&resolved=false&types=CODE_SMELL) [12 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4412&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=4412&metric=new_coverage&view=list) [57.5% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=4412&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=4412&metric=new_duplicated_lines_density&view=list) [3.1% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=4412&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #4412: [IOTDB-2030] Add IWritableMemChunkGroup Interface to unify the map in memtable
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #4412:
URL: https://github.com/apache/iotdb/pull/4412#issuecomment-972571826
SonarCloud Quality Gate failed. 
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4412&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4412&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4412&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4412&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4412&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4412&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=4412&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=4412&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=4412&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4412&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4412&resolved=false&types=CODE_SMELL) [12 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4412&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=4412&metric=new_coverage&view=list) [57.5% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=4412&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=4412&metric=new_duplicated_lines_density&view=list) [3.1% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=4412&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #4412: [IOTDB-2030] Add IWritableMemChunkGroup Interface to unify the map in memtable
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #4412:
URL: https://github.com/apache/iotdb/pull/4412#issuecomment-973863420
SonarCloud Quality Gate failed. 
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4412&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4412&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4412&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4412&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4412&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4412&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=4412&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=4412&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=4412&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4412&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4412&resolved=false&types=CODE_SMELL) [8 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4412&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=4412&metric=new_coverage&view=list) [70.7% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=4412&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=4412&metric=new_duplicated_lines_density&view=list) [3.6% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=4412&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4412: [IOTDB-2030] Add IWritableMemChunkGroup Interface to unify the map in memtable
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4412:
URL: https://github.com/apache/iotdb/pull/4412#issuecomment-971168632
[](https://coveralls.io/builds/44397982)
Coverage decreased (-0.02%) to 66.874% when pulling **d63a191d3bf99ef39d84b14c96d3d544eb9d79f3 on IWritableMemChunkGroup** into **d63539b7ec78576b12484a731ac3ff2894f922ed on master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a change in pull request #4412: [DRAFT] IWritableMemChunkGroup Interface
Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #4412:
URL: https://github.com/apache/iotdb/pull/4412#discussion_r750858710
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/memtable/AlignedWritableMemChunkGroup.java
##########
@@ -0,0 +1,62 @@
+package org.apache.iotdb.db.engine.memtable;
Review comment:
```suggestion
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.iotdb.db.engine.memtable;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4412: [IOTDB-2030] Add IWritableMemChunkGroup Interface to unify the map in memtable
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4412:
URL: https://github.com/apache/iotdb/pull/4412#issuecomment-971168632
[](https://coveralls.io/builds/44396461)
Coverage increased (+0.02%) to 66.914% when pulling **3002640e1bd74a9778558e61a4965ab849a7d5e5 on IWritableMemChunkGroup** into **d63539b7ec78576b12484a731ac3ff2894f922ed on master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4412: [DRAFT] IWritableMemChunkGroup Interface
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4412:
URL: https://github.com/apache/iotdb/pull/4412#issuecomment-971168632
[](https://coveralls.io/builds/44322918)
Coverage increased (+0.05%) to 66.547% when pulling **21dc8a7be5b0a8315668810d792eba5c262e0128 on IWritableMemChunkGroup** into **96df1861643aa7f8f72d1bb276569d0eb68ee901 on master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a change in pull request #4412: [DRAFT] IWritableMemChunkGroup Interface
Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #4412:
URL: https://github.com/apache/iotdb/pull/4412#discussion_r750858896
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/memtable/IWritableMemChunkGroup.java
##########
@@ -0,0 +1,30 @@
+package org.apache.iotdb.db.engine.memtable;
Review comment:
```suggestion
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.iotdb.db.engine.memtable;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a change in pull request #4412: [DRAFT] IWritableMemChunkGroup Interface
Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #4412:
URL: https://github.com/apache/iotdb/pull/4412#discussion_r750858979
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/memtable/WritableMemChunkGroup.java
##########
@@ -0,0 +1,99 @@
+package org.apache.iotdb.db.engine.memtable;
Review comment:
```suggestion
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.iotdb.db.engine.memtable;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] JackieTien97 merged pull request #4412: [IOTDB-2030] Add IWritableMemChunkGroup Interface to unify the map in memtable
Posted by GitBox <gi...@apache.org>.
JackieTien97 merged pull request #4412:
URL: https://github.com/apache/iotdb/pull/4412
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4412: [IOTDB-2030] Add IWritableMemChunkGroup Interface to unify the map in memtable
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4412:
URL: https://github.com/apache/iotdb/pull/4412#issuecomment-971168632
[](https://coveralls.io/builds/44396396)
Coverage decreased (-0.006%) to 66.883% when pulling **3002640e1bd74a9778558e61a4965ab849a7d5e5 on IWritableMemChunkGroup** into **d63539b7ec78576b12484a731ac3ff2894f922ed on master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4412: [DRAFT] IWritableMemChunkGroup Interface
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4412:
URL: https://github.com/apache/iotdb/pull/4412#issuecomment-971168632
[](https://coveralls.io/builds/44357839)
Coverage increased (+0.1%) to 66.639% when pulling **cbf31dc948c93f6fb5c4a755e72514f830ad843c on IWritableMemChunkGroup** into **96df1861643aa7f8f72d1bb276569d0eb68ee901 on master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4412: [DRAFT] IWritableMemChunkGroup Interface
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4412:
URL: https://github.com/apache/iotdb/pull/4412#issuecomment-971168632
[](https://coveralls.io/builds/44322900)
Coverage increased (+0.02%) to 66.524% when pulling **21dc8a7be5b0a8315668810d792eba5c262e0128 on IWritableMemChunkGroup** into **96df1861643aa7f8f72d1bb276569d0eb68ee901 on master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #4412: [DRAFT] IWritableMemChunkGroup Interface
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #4412:
URL: https://github.com/apache/iotdb/pull/4412#issuecomment-971168632
[](https://coveralls.io/builds/44322495)
Coverage increased (+0.001%) to 66.503% when pulling **21dc8a7be5b0a8315668810d792eba5c262e0128 on IWritableMemChunkGroup** into **96df1861643aa7f8f72d1bb276569d0eb68ee901 on master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org