You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/10/30 21:31:19 UTC

[GitHub] [helix] helix-bot opened a new pull request, #2263: 2259/send identity token

helix-bot opened a new pull request, #2263:
URL: https://github.com/apache/helix/pull/2263

   ### Description
   
   <!-- Write a concise description: "what?, why?, how?" and then add some details about this PR, including screenshots of any UI changes -->
   
   <!-- This PR fixes this Helix issue & includes the Helix issue in the PR description. Link your issue number here: You can write `Fix #123`.  See https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue -->
   
   This PR sends the Identity Token to helix-rest using the `Identity-Token` header if an Identity Token Source is configured in `server/config.ts`.
   
   Fix #2259
   
   ### Tests
   
   Tested locally. 
   
   <details>
   
   ### Code Style
   
   <!-- Ensure the PR diff has been formatted using [Prettier](https://prettier.io) -->
   
   Formatted using [Prettier](https://prettier.io)
   
   ### Commits
   
   - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   
   ### Changes that Break Backward Compatibility (Optional)
   
   - [ ] My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include: -->
   
   <!-- Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method or API behavior. -->
   
   ### Documentation (Optional)
   
   - [ ] In case of new functionality, my PR adds documentation in the following wiki page: -->
   
   <!-- Link the GitHub wiki you added -->
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] helix-bot commented on pull request #2263: 2259/send identity token

Posted by GitBox <gi...@apache.org>.
helix-bot commented on PR #2263:
URL: https://github.com/apache/helix/pull/2263#issuecomment-1301518678

   This PR is ready to be merged, approved by @somecodemonkey         
   Final commit message:
   ## Send Identity Token from helix-front to helix-rest (#2259)
   If an identity token source is configured.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] somecodemonkey commented on a diff in pull request #2263: 2259/send identity token

Posted by GitBox <gi...@apache.org>.
somecodemonkey commented on code in PR #2263:
URL: https://github.com/apache/helix/pull/2263#discussion_r1012316082


##########
helix-front/server/controllers/helix.ts:
##########
@@ -50,6 +50,12 @@ export class HelixCtrl {
           'Helix-User': user,
         },
       };
+
+      if (IDENTITY_TOKEN_SOURCE) {
+        options.headers['Identity-Token'] =
+          res.locals.cookie['helixui_identity.token'];
+      }

Review Comment:
   Minor suggestion, the keys 'Identity-Token' and 'helixui_identity.token' are also used elsewhere, I suggest putting them in a constants. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] NealSun96 merged pull request #2263: 2259/send identity token

Posted by GitBox <gi...@apache.org>.
NealSun96 merged PR #2263:
URL: https://github.com/apache/helix/pull/2263


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org