You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@plc4x.apache.org by cd...@apache.org on 2018/11/06 10:40:01 UTC
[incubator-plc4x] branch master updated: - Added a tiny little bit
of test-coverage to pass the 80% boundary
This is an automated email from the ASF dual-hosted git repository.
cdutz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-plc4x.git
The following commit(s) were added to refs/heads/master by this push:
new 73cab04 - Added a tiny little bit of test-coverage to pass the 80% boundary
73cab04 is described below
commit 73cab048a7d8a6fc1d170e23d78f59f439ca059f
Author: Christofer Dutz <ch...@c-ware.de>
AuthorDate: Tue Nov 6 11:39:58 2018 +0100
- Added a tiny little bit of test-coverage to pass the 80% boundary
---
.../java/utils/connectionpool/PooledPlcDriverManagerTest.java | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/plc4j/utils/connection-pool/src/test/java/org/apache/plc4x/java/utils/connectionpool/PooledPlcDriverManagerTest.java b/plc4j/utils/connection-pool/src/test/java/org/apache/plc4x/java/utils/connectionpool/PooledPlcDriverManagerTest.java
index bbe8ea8..2c015a5 100644
--- a/plc4j/utils/connection-pool/src/test/java/org/apache/plc4x/java/utils/connectionpool/PooledPlcDriverManagerTest.java
+++ b/plc4j/utils/connection-pool/src/test/java/org/apache/plc4x/java/utils/connectionpool/PooledPlcDriverManagerTest.java
@@ -267,6 +267,15 @@ class PooledPlcDriverManagerTest implements WithAssertions {
);
}
+ @Test
+ public void testOtherConstructors() {
+ assertThat(new PooledPlcDriverManager()).isNotNull();
+ assertThat(new PooledPlcDriverManager(new PoolKeyFactory())).isNotNull();
+ assertThat(new PooledPlcDriverManager(PooledPlcDriverManager.class.getClassLoader())).isNotNull();
+ assertThat(new PooledPlcDriverManager(
+ PooledPlcDriverManager.class.getClassLoader(), new PoolKeyFactory())).isNotNull();
+ }
+
class DummyPlcConnection implements PlcConnection, PlcConnectionMetadata {
private final String url;
@@ -285,7 +294,7 @@ class PooledPlcDriverManagerTest implements WithAssertions {
}
@Override
- public void connect() throws PlcConnectionException {
+ public void connect() {
connected = true;
}