[GitHub] [superset] villebro commented on issue #24271: [SIP] Proposal for adding a notification feature

["villebro (via GitHub)" <gi...@apache.org>]

villebro commented on issue #24271:
URL: https://github.com/apache/superset/issues/24271#issuecomment-1573545101

   I LOVE this proposal! I routinely need something similar, but hadn't even thought of having something like this. +1 for the proposal and an even bigger +1 for the well thought out UI + API.
   
   Some thoughts:
   - I know we aren't super consistent in always applying or not applying training slashes on REST endpoints, but I believe it's commonly accepted that leaving out the trailing slash is best practice. So maybe replace `/api/v1/notification/` with `/api/v1/notification` etc. @dpgaspar any thoughts here?
   - The "Manage" menu item is maybe unnecessarily ambiguous. I've been thinking about starting a SIP to introduce a similar UI for cache warmup jobs, and if we do end up adding more scheduling functionality, maybe we could consider breaking them out under a new menu "Scheduled tasks". Maybe not now, but perhaps for Superset 4.0
   - Instead of toasts, maybe important notifications should be displayed more prominently, e.g. on the subnav (the one with "Home" in the pic below), with a button to explicitly ack that the message has been read? Typical cases for such notifications could be scheduled downtimes, upgrade notifications etc. Also being able to add links to the messages would be a nice addition.
   <img width="1189" alt="image" src="https://github.com/apache/superset/assets/33317356/a2bb6ab2-f81d-4d7d-a02e-05d96396fb81">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org