You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "zentol (via GitHub)" <gi...@apache.org> on 2023/03/16 12:42:43 UTC
[GitHub] [flink] zentol commented on a diff in pull request #22191: [FLINK-31485][Confluent Avro] Change packaging of Avro Confluent Schema Registry
zentol commented on code in PR #22191:
URL: https://github.com/apache/flink/pull/22191#discussion_r1138595476
##########
flink-formats/flink-avro-confluent-registry/pom.xml:
##########
@@ -65,6 +65,38 @@ under the License.
<groupId>io.swagger</groupId>
<artifactId>swagger-core</artifactId>
</exclusion>
+ <exclusion>
+ <groupId>com.google.guava</groupId>
+ <artifactId>failureaccess</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>com.google.guava</groupId>
+ <artifactId>listenablefuture</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>io.swagger.core.v3</groupId>
+ <artifactId>swagger-annotations</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>com.google.errorprone</groupId>
+ <artifactId>error_prone_annotations</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>com.google.j2objc</groupId>
+ <artifactId>j2objc-annotations</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>com.google.code.findbugs</groupId>
+ <artifactId>jsr305</artifactId>
+ </exclusion>
Review Comment:
This is actually defined in the Flink root pom. Either we add a dependency on it marked as provided to this module or exclude it in the shade-plugin config. I think I'd prefer the exclusion.
##########
flink-formats/flink-sql-avro-confluent-registry/src/main/resources/META-INF/NOTICE:
##########
@@ -6,20 +6,27 @@ The Apache Software Foundation (http://www.apache.org/).
This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt)
-- org.apache.avro:avro:1.11.1
+- com.fasterxml.jackson.core:jackson-annotations:2.13.4
- com.fasterxml.jackson.core:jackson-core:2.13.4
- com.fasterxml.jackson.core:jackson-databind:2.13.4.2
-- com.fasterxml.jackson.core:jackson-annotations:2.13.4
-- org.apache.commons:commons-compress:1.21
-- io.confluent:kafka-schema-registry-client:7.2.2
-- org.apache.kafka:kafka-clients:7.2.2-ccs
+- com.google.guava:guava:30.1.1-jre
- io.confluent:common-config:7.2.2
- io.confluent:common-utils:7.2.2
+- io.confluent:kafka-schema-registry-client:7.2.2
+- org.apache.avro:avro:1.11.1
+- org.apache.commons:commons-compress:1.21
+- org.apache.kafka:kafka-clients:7.2.2-ccs
- org.glassfish.jersey.core:jersey-common:2.30
+- org.xerial.snappy:snappy-java:1.1.8.3
The binary distribution of this product bundles these dependencies under the Eclipse Public License - v 2.0 (https://www.eclipse.org/org/documents/epl-2.0/EPL-2.0.txt)
- jakarta.annotation:jakarta.annotation-api:1.3.5
- jakarta.ws.rs:jakarta.ws.rs-api:2.1.6
- org.glassfish.hk2.external:jakarta.inject:2.6.1
- org.glassfish.hk2:osgi-resource-locator:1.0.3
+
+This project bundles the following dependencies under the BSD license.
+See bundled license files for details.
Review Comment:
There's no bundled license for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org