You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dlab.apache.org by GitBox <gi...@apache.org> on 2019/12/27 20:49:34 UTC
[GitHub] [incubator-dlab] viravit opened a new pull request #512:
[DLAB-1418]: Created integration tests for project in Gherkin
viravit opened a new pull request #512: [DLAB-1418]: Created integration tests for project in Gherkin
URL: https://github.com/apache/incubator-dlab/pull/512
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@dlab.apache.org
For additional commands, e-mail: dev-help@dlab.apache.org
[GitHub] [incubator-dlab] ofuks commented on a change in pull request #512:
[DLAB-1418]: Created integration tests for project in Gherkin
Posted by GitBox <gi...@apache.org>.
ofuks commented on a change in pull request #512: [DLAB-1418]: Created integration tests for project in Gherkin
URL: https://github.com/apache/incubator-dlab/pull/512#discussion_r361936044
##########
File path: integration-tests-cucumber/src/test/resources/dlab/project.feature
##########
@@ -1,18 +1,146 @@
Feature: Project management in DLab
Such feature allowed to manage projects inside DLab
- Scenario Outline: Create new project when it does not exist
+ Scenario Outline: Create new project when it does not exist and use shared image is enable
Given There is no project with name "<name>" in DLab
And There are the following endpoints
| local |
And There are the following groups
| $anyuser |
- And User generate new publicKey
- And User try to create new project with name "<name>", endpoints, groups and publicKey
- When User send create new project request
- Then User wait maximum <timeout> minutes while project is creating
+ And User generates new publicKey
+ When User tries to create new project with name "<name>", endpoints, groups, publicKey and use shared image "true"
Review comment:
Should we unify the value for the **shared image** parameter? I mean [there](https://github.com/apache/incubator-dlab/pull/512/files#diff-c52ad2bc7daddbcfdf99b83217be5b32R4) you used _enable_, but here "true".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@dlab.apache.org
For additional commands, e-mail: dev-help@dlab.apache.org
[GitHub] [incubator-dlab] ofuks commented on a change in pull request #512:
[DLAB-1418]: Created integration tests for project in Gherkin
Posted by GitBox <gi...@apache.org>.
ofuks commented on a change in pull request #512: [DLAB-1418]: Created integration tests for project in Gherkin
URL: https://github.com/apache/incubator-dlab/pull/512#discussion_r361936100
##########
File path: integration-tests-cucumber/src/test/resources/dlab/project.feature
##########
@@ -1,18 +1,146 @@
Feature: Project management in DLab
Such feature allowed to manage projects inside DLab
- Scenario Outline: Create new project when it does not exist
+ Scenario Outline: Create new project when it does not exist and use shared image is enable
Given There is no project with name "<name>" in DLab
And There are the following endpoints
| local |
And There are the following groups
| $anyuser |
- And User generate new publicKey
- And User try to create new project with name "<name>", endpoints, groups and publicKey
- When User send create new project request
- Then User wait maximum <timeout> minutes while project is creating
+ And User generates new publicKey
+ When User tries to create new project with name "<name>", endpoints, groups, publicKey and use shared image "true"
+ And User sends create new project request
+ Then User waits maximum <timeout> minutes while project is creating
Then Status code is 200
Examples:
| name | timeout |
- | prj1 | 20 |
\ No newline at end of file
+ | prj1 | 20 |
+
+
+ Scenario Outline: Create new project when project with the same name exists already
+
+ Given There are the following projects
+ | prj1 |
+ And There are the following endpoints
+ | local |
+ And There are the following groups
+ | $anyuser |
+ And User generates new publicKey
+ When User tries to create new project with name "<name>", endpoints, groups, publicKey and use shared image "true"
Review comment:
The same here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@dlab.apache.org
For additional commands, e-mail: dev-help@dlab.apache.org
[GitHub] [incubator-dlab] ofuks merged pull request #512: [DLAB-1418]:
Created integration tests for project in Gherkin
Posted by GitBox <gi...@apache.org>.
ofuks merged pull request #512: [DLAB-1418]: Created integration tests for project in Gherkin
URL: https://github.com/apache/incubator-dlab/pull/512
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@dlab.apache.org
For additional commands, e-mail: dev-help@dlab.apache.org
[GitHub] [incubator-dlab] viravit closed pull request #512: [DLAB-1418]:
Created integration tests for project in Gherkin
Posted by GitBox <gi...@apache.org>.
viravit closed pull request #512: [DLAB-1418]: Created integration tests for project in Gherkin
URL: https://github.com/apache/incubator-dlab/pull/512
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@dlab.apache.org
For additional commands, e-mail: dev-help@dlab.apache.org
[GitHub] [incubator-dlab] viravit opened a new pull request #512:
[DLAB-1418]: Created integration tests for project in Gherkin
Posted by GitBox <gi...@apache.org>.
viravit opened a new pull request #512: [DLAB-1418]: Created integration tests for project in Gherkin
URL: https://github.com/apache/incubator-dlab/pull/512
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@dlab.apache.org
For additional commands, e-mail: dev-help@dlab.apache.org
[GitHub] [incubator-dlab] ofuks commented on a change in pull request #512:
[DLAB-1418]: Created integration tests for project in Gherkin
Posted by GitBox <gi...@apache.org>.
ofuks commented on a change in pull request #512: [DLAB-1418]: Created integration tests for project in Gherkin
URL: https://github.com/apache/incubator-dlab/pull/512#discussion_r361936214
##########
File path: integration-tests-cucumber/src/test/resources/dlab/project.feature
##########
@@ -1,18 +1,146 @@
Feature: Project management in DLab
Such feature allowed to manage projects inside DLab
- Scenario Outline: Create new project when it does not exist
+ Scenario Outline: Create new project when it does not exist and use shared image is enable
Given There is no project with name "<name>" in DLab
And There are the following endpoints
| local |
And There are the following groups
| $anyuser |
- And User generate new publicKey
- And User try to create new project with name "<name>", endpoints, groups and publicKey
- When User send create new project request
- Then User wait maximum <timeout> minutes while project is creating
+ And User generates new publicKey
+ When User tries to create new project with name "<name>", endpoints, groups, publicKey and use shared image "true"
+ And User sends create new project request
+ Then User waits maximum <timeout> minutes while project is creating
Then Status code is 200
Examples:
| name | timeout |
- | prj1 | 20 |
\ No newline at end of file
+ | prj1 | 20 |
+
+
+ Scenario Outline: Create new project when project with the same name exists already
+
+ Given There are the following projects
+ | prj1 |
+ And There are the following endpoints
+ | local |
+ And There are the following groups
+ | $anyuser |
+ And User generates new publicKey
+ When User tries to create new project with name "<name>", endpoints, groups, publicKey and use shared image "true"
+ And User sends create new project request
+ Then Response status code is 409
+ Examples:
+ | name |
+ | prj1 |
+
+
+ Scenario Outline: Get information about a projects that exits
+
+ Given There are the following projects
+ | prj1 |
+ And There are the following endpoints
+ | local |
+ And There are the following groups
+ | $anyuser |
+ When User tries to get information about project with name "<name>"
+ Then Response status code is 200
+ And Project information is successfully returned with name "<name>", endpoints, groups
+ Examples:
+ | name | endpoint | group |
+ | prj1 | local | $anyuser |
+
+
+ Scenario: Get information about a project that does not exists
+
+ Given There is no project with name "test1"
+ When User tries to get information about the project with name "test1"
+ Then Respone status code is 404
+
+
+
+
+ Scenario: Edit (change use shared image and add a group) a project that is available
+
+ Given There are the following projects
+ | prj1 |
+ And There are the following endpoints
+ | local |
+ And There are the following groups
+ | $anyuser |
+ And Use shared image
+ | true |
+ When User tries to create a new group with name "admin"
+ And User adds new group with name "admin"
+ And User changes use shared image to "false"
Review comment:
The same here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@dlab.apache.org
For additional commands, e-mail: dev-help@dlab.apache.org