You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "shivam71 (via GitHub)" <gi...@apache.org> on 2025/08/28 11:23:39 UTC

[PR] Simple implementation of LSP protocol shutdown request and exit notification handlers [netbeans]

shivam71 opened a new pull request, #8770:
URL: https://github.com/apache/netbeans/pull/8770

   ### Changes related to Netbeans Java  Language Server
    **Context** 
   - LSP Protocol provides the language clients to send messages to the language server to shutdown and exit .
   - This allows language clients to control the lifecycle of the language server completely from start to shutdown. [Spec relevant section  : lifeCycleMessages](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#lifeCycleMessages)
   #### About the changes made 
   -  `Shutdown Request `handler and the `Exit Notification` handler implemented 
   
   **Note** 
   As per the LSP Spec about [Shutdown Request ](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#shutdown) the language server should respond with `Invalid Request `error post receiving the shutdown request . That can be done in the future if required but has been deferred for now to keep this change simple .
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Simple implementation of LSP protocol shutdown request and exit notification handlers [netbeans]

Posted by "lahodaj (via GitHub)" <gi...@apache.org>.
lahodaj merged PR #8770:
URL: https://github.com/apache/netbeans/pull/8770


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Simple implementation of LSP protocol shutdown request and exit notification handlers [netbeans]

Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #8770:
URL: https://github.com/apache/netbeans/pull/8770#issuecomment-3263955753

   @lahodaj @shivam71 is not a committer, if you still think that this is good to go, please merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists