You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Jukka Zitting (JIRA)" <ji...@apache.org> on 2007/11/29 01:02:43 UTC
[jira] Created: (JCR-1244) No need for NodeReferences in jcr2spi
No need for NodeReferences in jcr2spi
-------------------------------------
Key: JCR-1244
URL: https://issues.apache.org/jira/browse/JCR-1244
Project: Jackrabbit
Issue Type: Improvement
Components: jackrabbit-jcr2spi
Reporter: Jukka Zitting
Priority: Minor
I happened to come across the org.apache.jackrabbit.jcr2spi.state.NodeReferences interface, and realized that with the current SPI definitions there's really no need for that abstraction. The PropertyId array returned by NodeInfo.getReferences() is quite good enough for jcr2spi without any NodeReferences wrapping around it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1244) No need for NodeReferences in jcr2spi
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting updated JCR-1244:
-------------------------------
Attachment: JCR-1244.patch
Proposed patch (+20 lines, -122 lines) for removing NodeReferences in jackrabbit-jcr2spi.
> No need for NodeReferences in jcr2spi
> -------------------------------------
>
> Key: JCR-1244
> URL: https://issues.apache.org/jira/browse/JCR-1244
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-jcr2spi
> Reporter: Jukka Zitting
> Priority: Minor
> Attachments: JCR-1244.patch
>
>
> I happened to come across the org.apache.jackrabbit.jcr2spi.state.NodeReferences interface, and realized that with the current SPI definitions there's really no need for that abstraction. The PropertyId array returned by NodeInfo.getReferences() is quite good enough for jcr2spi without any NodeReferences wrapping around it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JCR-1244) No need for NodeReferences in jcr2spi
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting resolved JCR-1244.
--------------------------------
Resolution: Fixed
Fix Version/s: 1.4
Assignee: Jukka Zitting
Patch applied in revision 605155. Thanks for the reviews!
> No need for NodeReferences in jcr2spi
> -------------------------------------
>
> Key: JCR-1244
> URL: https://issues.apache.org/jira/browse/JCR-1244
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-jcr2spi
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Priority: Minor
> Fix For: 1.4
>
> Attachments: JCR-1244.patch
>
>
> I happened to come across the org.apache.jackrabbit.jcr2spi.state.NodeReferences interface, and realized that with the current SPI definitions there's really no need for that abstraction. The PropertyId array returned by NodeInfo.getReferences() is quite good enough for jcr2spi without any NodeReferences wrapping around it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1244) No need for NodeReferences in jcr2spi
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552420 ]
angela commented on JCR-1244:
-----------------------------
fine with me.
> No need for NodeReferences in jcr2spi
> -------------------------------------
>
> Key: JCR-1244
> URL: https://issues.apache.org/jira/browse/JCR-1244
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-jcr2spi
> Reporter: Jukka Zitting
> Priority: Minor
> Attachments: JCR-1244.patch
>
>
> I happened to come across the org.apache.jackrabbit.jcr2spi.state.NodeReferences interface, and realized that with the current SPI definitions there's really no need for that abstraction. The PropertyId array returned by NodeInfo.getReferences() is quite good enough for jcr2spi without any NodeReferences wrapping around it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1244) No need for NodeReferences in jcr2spi
Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12547034 ]
Marcel Reutegger commented on JCR-1244:
---------------------------------------
looks good to me.
+1
> No need for NodeReferences in jcr2spi
> -------------------------------------
>
> Key: JCR-1244
> URL: https://issues.apache.org/jira/browse/JCR-1244
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-jcr2spi
> Reporter: Jukka Zitting
> Priority: Minor
> Attachments: JCR-1244.patch
>
>
> I happened to come across the org.apache.jackrabbit.jcr2spi.state.NodeReferences interface, and realized that with the current SPI definitions there's really no need for that abstraction. The PropertyId array returned by NodeInfo.getReferences() is quite good enough for jcr2spi without any NodeReferences wrapping around it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.