You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2022/05/18 15:21:14 UTC
[GitHub] [cordova-android] erisu opened a new pull request, #1434: fix: restore checkReqs in prepare.js
erisu opened a new pull request, #1434:
URL: https://github.com/apache/cordova-android/pull/1434
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Restore `checkReqs` in `prepare.js`
### Description
<!-- Describe your changes in detail -->
In PR #1431, additional usage of `checkReqs` was added to `prepare.js`.
In PR #1154, the only usage of `checkReqs` was removed so the requirement was deleted.
Because of #1154 was merged first and #1431 was merged second, with no conflict, the test ended up failing on master.
This PR just adds back the `require` statement.
### Testing
<!-- Please describe in detail how you tested your changes. -->
`npm t`
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter commented on pull request #1434: fix: restore checkReqs in prepare.js
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1434:
URL: https://github.com/apache/cordova-android/pull/1434#issuecomment-1130183656
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1434?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1434](https://codecov.io/gh/apache/cordova-android/pull/1434?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (83b1163) into [master](https://codecov.io/gh/apache/cordova-android/commit/bd0c8ce6398be2f3c005787dc383d4c98677b635?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bd0c8ce) will **increase** coverage by `3.01%`.
> The diff coverage is `87.50%`.
```diff
@@ Coverage Diff @@
## master #1434 +/- ##
==========================================
+ Coverage 72.95% 75.96% +3.01%
==========================================
Files 21 21
Lines 1653 1677 +24
==========================================
+ Hits 1206 1274 +68
+ Misses 447 403 -44
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1434?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/1434/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2NoZWNrX3JlcXMuanM=) | `71.05% <76.47%> (+0.68%)` | :arrow_up: |
| [lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/1434/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2NyZWF0ZS5qcw==) | `94.32% <100.00%> (+0.08%)` | :arrow_up: |
| [lib/prepare.js](https://codecov.io/gh/apache/cordova-android/pull/1434/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL3ByZXBhcmUuanM=) | `60.00% <100.00%> (+15.38%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1434?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1434?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4744bfe...83b1163](https://codecov.io/gh/apache/cordova-android/pull/1434?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu merged pull request #1434: fix: restore checkReqs in prepare.js
Posted by GitBox <gi...@apache.org>.
erisu merged PR #1434:
URL: https://github.com/apache/cordova-android/pull/1434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org