[GitHub] [iceberg] youngxinler commented on pull request #6886: Spark: allows catalog.warehouse for Spark Hive Catalogs #6863

["youngxinler (via GitHub)" <gi...@apache.org>]

youngxinler commented on PR #6886:
URL: https://github.com/apache/iceberg/pull/6886#issuecomment-1519592072

   > I think this is almost done, we just need to create new sessions when we are working with new config to avoid contamination of other unit tests either that or just clearing out the config of added parameters after each test.
   > 
   > I also have one more note, we could clean up the `if` tree in the checks to be something like String expectedPath = (is a Hadoop catalog) ? hadoopPath : hivePath;
   > 
   > Then it's a single assert
   
   thanks for review,  I have changed this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org