You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by wilderrodrigues <gi...@git.apache.org> on 2015/12/10 20:15:21 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-9138 - Adds multiple providers...
GitHub user wilderrodrigues opened a pull request:
https://github.com/apache/cloudstack/pull/1215
CLOUDSTACK-9138 - Adds multiple providers back to VPC implementation
- It is need and already allowed/used in the current implementation. For example, the Default [redundant] VPC offerings use two LB providers. If we cannot create offerings with 2 LB providers, the whole internal loadbalancer implementation won't work.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ekholabs/cloudstack improve/mult-providers-CLOUDSTACK-9138
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1215.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1215
----
commit 51c9f0e3b524f978eadb6a6ba630c3f7281b1a11
Author: Wilder Rodrigues <wr...@schubergphilis.com>
Date: 2015-12-10T18:51:28Z
CLOUDSTACK-9138 - Adds multiple providers back to VPC implementation
- It is need and already allowed/used in the current implementation. For example, the Default [redundant] VPC offerings use
two LB providers. If we cannot create offerings with 2 LB providers, the whole internal loadbalancer implementation won't work
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9138 - Adds multiple providers...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1215#issuecomment-164014731
LGTM, both offerings mentioned above are created fine:
```
[root@cs1 integration]# cloudmonkey
☁ Apache CloudStack � cloudmonkey 5.3.2. Type help or ? to list commands.
Using management server profile: local
(local) � > create vpcoffering name=test2 displaytext=testtest2 supportedservices=PortForwarding,StaticNat,SourceNat,Vpn,Dhcp,Connectivity,Dns,UserData,NetworkACL,Lb serviceproviderlist[0].service=PortForwarding serviceproviderlist[0].provider=VpcVirtualRouter serviceproviderlist[1].service=StaticNat serviceproviderlist[1].provider=VpcVirtualRouter serviceproviderlist[2].service=SourceNat serviceproviderlist[2].provider=VpcVirtualRouter serviceproviderlist[3].service=Vpn serviceproviderlist[3].provider=VpcVirtualRouter serviceproviderlist[4].service=Dhcp serviceproviderlist[4].provider=VpcVirtualRouter serviceproviderlist[5].service=Connectivity serviceproviderlist[5].provider=NiciraNvp serviceproviderlist[6].service=Dns serviceproviderlist[6].provider=VpcVirtualRouter serviceproviderlist[7].service=UserData serviceproviderlist[7].provider=VpcVirtualRouter serviceproviderlist[8].service=NetworkACL serviceproviderlist[8].provider=VpcVirtualRouter serviceproviderlist[9].ser
vice=Lb serviceproviderlist[9].provider=VpcVirtualRouter servicecapabilitylist[0].capabilitytype=RedundantRouter servicecapabilitylist[0].service=SourceNat servicecapabilitylist[0].capabilityvalue=true
accountid = 634eafef-a034-11e5-b0bf-5254001daa61
cmd = org.apache.cloudstack.api.command.admin.vpc.CreateVPCOfferingCmd
created = 2015-12-11T18:43:24+0000
jobid = af045abf-a7bf-4071-986b-60003e686de1
jobinstancetype = None
jobprocstatus = 0
jobresult:
vpcoffering:
name = test2
id = 9e2cffe5-e1df-40ed-a19f-c99d0b0efcaa
displaytext = testtest2
distributedvpcrouter = False
isdefault = False
service:
name = Vpn
provider:
name = VpcVirtualRouter
================================================================================
name = Dns
provider:
name = VpcVirtualRouter
================================================================================
name = Connectivity
provider:
name = NiciraNvp
================================================================================
name = NetworkACL
provider:
name = VpcVirtualRouter
================================================================================
name = Dhcp
provider:
name = VpcVirtualRouter
================================================================================
name = UserData
provider:
name = VpcVirtualRouter
================================================================================
name = SourceNat
provider:
name = VpcVirtualRouter
================================================================================
name = PortForwarding
provider:
name = VpcVirtualRouter
================================================================================
name = Lb
provider:
name = VpcVirtualRouter
================================================================================
name = StaticNat
provider:
name = VpcVirtualRouter
state = Disabled
supportsregionLevelvpc = False
jobresultcode = 0
jobresulttype = object
jobstatus = 1
userid = 634ec46c-a034-11e5-b0bf-5254001daa61
(local) � > create vpcoffering name=test displaytext=testtest supportedservices=PortForwarding,StaticNat,SourceNat,Vpn,Dhcp,Connectivity,Dns,UserData,NetworkACL,Lb serviceproviderlist[0].service=PortForwarding serviceproviderlist[0].provider=VpcVirtualRouter serviceproviderlist[1].service=StaticNat serviceproviderlist[1].provider=VpcVirtualRouter serviceproviderlist[2].service=SourceNat serviceproviderlist[2].provider=VpcVirtualRouter serviceproviderlist[3].service=Vpn serviceproviderlist[3].provider=VpcVirtualRouter serviceproviderlist[4].service=Dhcp serviceproviderlist[4].provider=VpcVirtualRouter serviceproviderlist[5].service=Connectivity serviceproviderlist[5].provider=NiciraNvp serviceproviderlist[6].service=Dns serviceproviderlist[6].provider=VpcVirtualRouter serviceproviderlist[7].service=UserData serviceproviderlist[7].provider=VpcVirtualRouter serviceproviderlist[8].service=NetworkACL serviceproviderlist[8].provider=VpcVirtualRouter serviceproviderlist[9].servi
ce=Lb serviceproviderlist[9].provider=VpcVirtualRouter serviceproviderlist[10].service=Lb serviceproviderlist[10].provider=InternalLbVm servicecapabilitylist[0].capabilitytype=RedundantRouter servicecapabilitylist[0].service=SourceNat servicecapabilitylist[0].capabilityvalue=true
accountid = 634eafef-a034-11e5-b0bf-5254001daa61
cmd = org.apache.cloudstack.api.command.admin.vpc.CreateVPCOfferingCmd
created = 2015-12-11T18:43:31+0000
jobid = 935a6cc5-e691-4224-8ec0-5158641a9f6d
jobinstancetype = None
jobprocstatus = 0
jobresult:
vpcoffering:
name = test
id = edbe4cc4-dfba-4c04-ba09-08ddc7bd485d
displaytext = testtest
distributedvpcrouter = False
isdefault = False
service:
name = Vpn
provider:
name = VpcVirtualRouter
================================================================================
name = Dns
provider:
name = VpcVirtualRouter
================================================================================
name = Connectivity
provider:
name = NiciraNvp
================================================================================
name = NetworkACL
provider:
name = VpcVirtualRouter
================================================================================
name = Dhcp
provider:
name = VpcVirtualRouter
================================================================================
name = UserData
provider:
name = VpcVirtualRouter
================================================================================
name = SourceNat
provider:
name = VpcVirtualRouter
================================================================================
name = PortForwarding
provider:
name = VpcVirtualRouter
================================================================================
name = Lb
provider:
name = InternalLbVm
================================================================================
name = VpcVirtualRouter
================================================================================
name = StaticNat
provider:
name = VpcVirtualRouter
state = Disabled
supportsregionLevelvpc = False
jobresultcode = 0
jobresulttype = object
jobstatus = 1
userid = 634ec46c-a034-11e5-b0bf-5254001daa61
(local) � >
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9138 - Adds multiple providers...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1215#issuecomment-163999132
@DaanHoogland I changed base.py (under tools/marvin) to allow the use of the multiple providers, but that will be in the PR I am about to create for the new internal LB tests.
I will only create the new PR once this one gets merged due to the dependency. But I have tested the other changes with this one and all works fine. Check below:
```
[root@cs2 integration]# less /tmp//MarvinLogs/test_internal_lb_DXYD14/results.txt
Test create, assign, remove of an Internal LB with roundrobin http traffic to 3 vm's in a Single VPC ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic to 3 vm's in a Redundant VPC ... === TestName: test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === TestName: test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === TestName: test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 4 tests in 6681.151s
OK
/tmp//MarvinLogs/test_internal_lb_DXYD14/results.txt (END)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9138 - Adds multiple providers...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1215#issuecomment-163988697
@wilderrodrigues did run the add commands in an old setup, will run the integration/regression suits and the cloudmonkey commands. code lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9138 - Adds multiple providers...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1215#issuecomment-163723768
Ping @remibergsma @DaanHoogland @miguelaferreira @michaelandersen @bhaisaab
* Environment
- 1 KVM host on CentOS 7.1
- Management Server on CentOS 7.1
- Cloudmonkey
* Tests
- Executed cloudmonkey in order to create the offerings
* With only 1 provider
```
create vpcoffering name=test2 displaytext=testtest2 supportedservices=PortForwarding,StaticNat,SourceNat,Vpn,Dhcp,Connectivity,Dns,UserData,NetworkACL,Lb serviceproviderlist[0].service=PortForwarding serviceproviderlist[0].provider=VpcVirtualRouter serviceproviderlist[1].service=StaticNat serviceproviderlist[1].provider=VpcVirtualRouter serviceproviderlist[2].service=SourceNat serviceproviderlist[2].provider=VpcVirtualRouter serviceproviderlist[3].service=Vpn serviceproviderlist[3].provider=VpcVirtualRouter serviceproviderlist[4].service=Dhcp serviceproviderlist[4].provider=VpcVirtualRouter serviceproviderlist[5].service=Connectivity serviceproviderlist[5].provider=NiciraNvp serviceproviderlist[6].service=Dns serviceproviderlist[6].provider=VpcVirtualRouter serviceproviderlist[7].service=UserData serviceproviderlist[7].provider=VpcVirtualRouter serviceproviderlist[8].service=NetworkACL serviceproviderlist[8].provider=VpcVirtualRouter serviceproviderlist[9].service=Lb servic
eproviderlist[9].provider=VpcVirtualRouter servicecapabilitylist[0].capabilitytype=RedundantRouter servicecapabilitylist[0].service=SourceNat servicecapabilitylist[0].capabilityvalue=true
```
* With 2 providers
```
create vpcoffering name=test displaytext=testtest supportedservices=PortForwarding,StaticNat,SourceNat,Vpn,Dhcp,Connectivity,Dns,UserData,NetworkACL,Lb serviceproviderlist[0].service=PortForwarding serviceproviderlist[0].provider=VpcVirtualRouter serviceproviderlist[1].service=StaticNat serviceproviderlist[1].provider=VpcVirtualRouter serviceproviderlist[2].service=SourceNat serviceproviderlist[2].provider=VpcVirtualRouter serviceproviderlist[3].service=Vpn serviceproviderlist[3].provider=VpcVirtualRouter serviceproviderlist[4].service=Dhcp serviceproviderlist[4].provider=VpcVirtualRouter serviceproviderlist[5].service=Connectivity serviceproviderlist[5].provider=NiciraNvp serviceproviderlist[6].service=Dns serviceproviderlist[6].provider=VpcVirtualRouter serviceproviderlist[7].service=UserData serviceproviderlist[7].provider=VpcVirtualRouter serviceproviderlist[8].service=NetworkACL serviceproviderlist[8].provider=VpcVirtualRouter serviceproviderlist[9].service=Lb servicep
roviderlist[9].provider=VpcVirtualRouter serviceproviderlist[10].service=Lb serviceproviderlist[10].provider=InternalLbVm servicecapabilitylist[0].capabilitytype=RedundantRouter servicecapabilitylist[0].service=SourceNat servicecapabilitylist[0].capabilityvalue=true
```
If that's hard to see, in the second test I added the following:
```
serviceproviderlist[10].service=Lb serviceproviderlist[10].provider=InternalLbVm
```
* Screenshots
- Offerings
- 2 Providers
- 1 Provider
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9138 - Adds multiple providers...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1215
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---