You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "hzxa21 (via GitHub)" <gi...@apache.org> on 2024/03/28 07:07:33 UTC
[I] writer: use write_once instead of write_part if writer is close with only a single part filled [opendal]
hzxa21 opened a new issue, #4405:
URL: https://github.com/apache/opendal/issues/4405
Currently MultipartWriter will initiate multipart upload on the first write regardless of whether there are multiple parts to be uploaded. However, if there is only a single part to be uploaded, it is better to fall back to write_once to save the extra `initiate_part` and `complete_part` call.
Arguably this can be done in the application layer via buffering and decide to call `writer_with` or `write_with` accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] writer: use write_once instead of write_part if writer is close with only a single part filled [opendal]
Posted by "hzxa21 (via GitHub)" <gi...@apache.org>.
hzxa21 closed issue #4405: writer: use write_once instead of write_part if writer is close with only a single part filled
URL: https://github.com/apache/opendal/issues/4405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] writer: use write_once instead of write_part if writer is close with only a single part filled [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #4405:
URL: https://github.com/apache/opendal/issues/4405#issuecomment-2024566426
> I thought `cache` in `MultipartWriter` is the only buffer
I will change the name a bit to make it more obvious.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] writer: use write_once instead of write_part if writer is close with only a single part filled [opendal]
Posted by "hzxa21 (via GitHub)" <gi...@apache.org>.
hzxa21 commented on issue #4405:
URL: https://github.com/apache/opendal/issues/4405#issuecomment-2024564475
Ah I see. I thought `cache` in `MultipartWriter` is the only buffer but I missed the fact that there is a `ExactBufWriter` on top of it if we specify `buffer` for `writer_with`. In this case, multiple writes from the application layer will only result in one write in `MultipartWriter` if the written bytes doesn't exceed buffer size.
I will close this issue then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] writer: use write_once instead of write_part if writer is close with only a single part filled [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #4405:
URL: https://github.com/apache/opendal/issues/4405#issuecomment-2024557000
> Currently MultipartWriter will initiate multipart upload on the first write regardless of whether there are multiple parts to be uploaded.
This is wrong. `MultipartWriter` only initiate multipart when users write data more than once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org