[GitHub] [superset] zhaoyongjie commented on pull request #18171: fix: null value and empty string in filter

[GitBox <gi...@apache.org>]

zhaoyongjie commented on pull request #18171:
URL: https://github.com/apache/superset/pull/18171#issuecomment-1023072398


   > As a bandaid this should fix the current issue. However, I can't help but feel slightly uncomfortable by these types of workarounds. I think the optimal architectural design would be such, that `<NULL>` and `<empty string>` would be the _labels_ in the select component in the frontend, but the _value_ would still be retained in its original form. Did you consider this approach, and if so, was there some reason it doesn't work?
   
   Nice catch! I have made frontend render of that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org