[jira] [Commented] (HBASE-22656) [Metrics] Tabe metrics 'BatchPut' and 'BatchDelete' are never updated

["Mingliang Liu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-22656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16879579#comment-16879579 ] 

Mingliang Liu commented on HBASE-22656:
---------------------------------------

+1 (non-binding)

Nice catch. The two method {{RegionServerTableMetrics::updatePutBatch()}} and {{RegionServerTableMetrics::updateDeleteBatch}} are never used.

> [Metrics]  Tabe metrics 'BatchPut' and 'BatchDelete' are never updated
> ----------------------------------------------------------------------
>
>                 Key: HBASE-22656
>                 URL: https://issues.apache.org/jira/browse/HBASE-22656
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>            Reporter: Reid Chan
>            Assignee: Reid Chan
>            Priority: Minor
>         Attachments: HBASE-22656.master.001.patch
>
>
> {code}
>   public void updatePutBatch(TableName tn, long t) {
>     if (tableMetrics != null && tn != null) {
>       tableMetrics.updatePut(tn, t); // Here should use updatePutBatch
>     }
>     ...
>   }
>   public void updateDeleteBatch(TableName tn, long t) {
>     if (tableMetrics != null && tn != null) {
>       tableMetrics.updateDelete(tn, t); // Here should use updateDeleteBatch
>     }
>     ...
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)