You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/27 09:43:16 UTC
[GitHub] [spark] yaooqinn opened a new pull request #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
yaooqinn opened a new pull request #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
```
bin/spark-sql --master k8s:///https://kubernetes.docker.internal:6443 --conf spark.kubernetes.container.image=yaooqinn/spark:v2.4.4
Exception in thread "main" java.lang.NullPointerException
at org.apache.spark.util.Utils$.checkAndGetK8sMasterUrl(Utils.scala:2739)
at org.apache.spark.deploy.SparkSubmit.prepareSubmitEnvironment(SparkSubmit.scala:261)
at org.apache.spark.deploy.SparkSubmit.org$apache$spark$deploy$SparkSubmit$$runMain(SparkSubmit.scala:774)
at org.apache.spark.deploy.SparkSubmit.doRunMain$1(SparkSubmit.scala:161)
at org.apache.spark.deploy.SparkSubmit.submit(SparkSubmit.scala:184)
at org.apache.spark.deploy.SparkSubmit.doSubmit(SparkSubmit.scala:86)
at org.apache.spark.deploy.SparkSubmit$$anon$2.doSubmit(SparkSubmit.scala:920)
at org.apache.spark.deploy.SparkSubmit$.main(SparkSubmit.scala:929)
at org.apache.spark.deploy.SparkSubmit.main(SparkSubmit.scala)
```
Althrough `k8s:///https://kubernetes.docker.internal:6443` is a wrong master url but should not throw npe
The `case null` will never be touched.
https://github.com/apache/spark/blob/3f4060c340d6bac412e8819c4388ccba226efcf3/core/src/main/scala/org/apache/spark/util/Utils.scala#L2772-L2776
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
bug fix
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
no
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
add ut case
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592079228
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27721: [SPARK-30970][K8S][Core]
Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592301064
**[Test build #119062 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119062/testReport)** for PR 27721 at commit [`b3dcb63`](https://github.com/apache/spark/commit/b3dcb63a682bc31827a86cf381f157a81e9e07ac).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-591960794
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119022/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592079235
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23792/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592046785
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592118927
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119046/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-591960784
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592272948
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23806/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592334057
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592398249
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592272940
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-591913196
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23770/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27721: [SPARK-30970][K8S][Core]
Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592118562
**[Test build #119046 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119046/testReport)** for PR 27721 at commit [`b3dcb63`](https://github.com/apache/spark/commit/b3dcb63a682bc31827a86cf381f157a81e9e07ac).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#discussion_r385269920
##########
File path: core/src/main/scala/org/apache/spark/util/Utils.scala
##########
@@ -2772,17 +2772,13 @@ private[spark] object Utils extends Logging {
}
val masterScheme = new URI(masterWithoutK8sPrefix).getScheme
- val resolvedURL = masterScheme.toLowerCase(Locale.ROOT) match {
- case "https" =>
+
+ val resolvedURL = Option(masterScheme).map(_.toLowerCase(Locale.ROOT)) match {
+ case Some("https") =>
masterWithoutK8sPrefix
- case "http" =>
+ case Some("http") =>
logWarning("Kubernetes master URL uses HTTP instead of HTTPS.")
masterWithoutK8sPrefix
- case null =>
- val resolvedURL = s"https://$masterWithoutK8sPrefix"
- logInfo("No scheme specified for kubernetes master URL, so defaulting to https. Resolved " +
- s"URL is $resolvedURL.")
- resolvedURL
case _ =>
Review comment:
Got it. The recovery logic seems to be not robust enough.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592379885
cc @holdenk for the flaky test which is blocking this PR.
```
- Test basic decommissioning *** FAILED ***
The code passed to eventually never returned normally. Attempted 126 times over 2.0100952450666667 minutes. Last failure message: "++ id -u
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#discussion_r385028041
##########
File path: core/src/main/scala/org/apache/spark/util/Utils.scala
##########
@@ -2772,17 +2772,13 @@ private[spark] object Utils extends Logging {
}
val masterScheme = new URI(masterWithoutK8sPrefix).getScheme
- val resolvedURL = masterScheme.toLowerCase(Locale.ROOT) match {
- case "https" =>
+
+ val resolvedURL = Option(masterScheme).map(_.toLowerCase(Locale.ROOT)) match {
+ case Some("https") =>
masterWithoutK8sPrefix
- case "http" =>
+ case Some("http") =>
logWarning("Kubernetes master URL uses HTTP instead of HTTPS.")
masterWithoutK8sPrefix
- case null =>
- val resolvedURL = s"https://$masterWithoutK8sPrefix"
- logInfo("No scheme specified for kubernetes master URL, so defaulting to https. Resolved " +
- s"URL is $resolvedURL.")
- resolvedURL
case _ =>
Review comment:
@yaooqinn . Although the current logic causes NPE, `getScheme` itself can return `null` according to the spec.
- https://docs.oracle.com/javase/8/docs/api/java/net/URI.html#getScheme--
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592301564
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119062/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-591982911
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27721: [SPARK-30970][K8S][Core]
Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-591880130
**[Test build #119022 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119022/testReport)** for PR 27721 at commit [`6a7d390`](https://github.com/apache/spark/commit/6a7d390fb70f1d506791aceab3d4c48305c5968a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-591960794
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119022/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592252120
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-591880130
**[Test build #119022 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119022/testReport)** for PR 27721 at commit [`6a7d390`](https://github.com/apache/spark/commit/6a7d390fb70f1d506791aceab3d4c48305c5968a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592079235
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23792/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592373495
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119067/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27721: [SPARK-30970][K8S][Core]
Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592310310
**[Test build #119067 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119067/testReport)** for PR 27721 at commit [`b3dcb63`](https://github.com/apache/spark/commit/b3dcb63a682bc31827a86cf381f157a81e9e07ac).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27721: [SPARK-30970][K8S][Core]
Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592371875
**[Test build #119067 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119067/testReport)** for PR 27721 at commit [`b3dcb63`](https://github.com/apache/spark/commit/b3dcb63a682bc31827a86cf381f157a81e9e07ac).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592395002
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23815/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592310310
**[Test build #119067 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119067/testReport)** for PR 27721 at commit [`b3dcb63`](https://github.com/apache/spark/commit/b3dcb63a682bc31827a86cf381f157a81e9e07ac).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27721: [SPARK-30970][K8S][Core]
Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592272932
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/23806/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592373468
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592301559
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592397251
Hi, @yaooqinn . Could you make a PR to `branch-2.4`? There is a conflict now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592079228
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592046799
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119028/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27721: [SPARK-30970][K8S][Core]
Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592079211
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/23792/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592039732
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592301559
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27721: [SPARK-30970][K8S][Core]
Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592334043
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/23812/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27721: [SPARK-30970][K8S][Core]
Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-591902363
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/23770/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#discussion_r385028885
##########
File path: core/src/main/scala/org/apache/spark/util/Utils.scala
##########
@@ -2772,17 +2772,13 @@ private[spark] object Utils extends Logging {
}
val masterScheme = new URI(masterWithoutK8sPrefix).getScheme
- val resolvedURL = masterScheme.toLowerCase(Locale.ROOT) match {
- case "https" =>
+
+ val resolvedURL = Option(masterScheme).map(_.toLowerCase(Locale.ROOT)) match {
+ case Some("https") =>
masterWithoutK8sPrefix
- case "http" =>
+ case Some("http") =>
logWarning("Kubernetes master URL uses HTTP instead of HTTPS.")
masterWithoutK8sPrefix
- case null =>
- val resolvedURL = s"https://$masterWithoutK8sPrefix"
- logInfo("No scheme specified for kubernetes master URL, so defaulting to https. Resolved " +
- s"URL is $resolvedURL.")
- resolvedURL
case _ =>
Review comment:
In the new logic, `None` case should map to https://github.com/apache/spark/pull/27721/files#diff-d239aee594001f8391676e1047a0381eL2782-L2785 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27721: [SPARK-30970][K8S][Core]
Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592327353
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/23812/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592254217
**[Test build #119062 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119062/testReport)** for PR 27721 at commit [`b3dcb63`](https://github.com/apache/spark/commit/b3dcb63a682bc31827a86cf381f157a81e9e07ac).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-591885317
@yaooqinn . Please use a specific title. This is only handling `https`. Isn't it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592272940
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27721: [SPARK-30970][K8S][Core]
Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592254217
**[Test build #119062 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119062/testReport)** for PR 27721 at commit [`b3dcb63`](https://github.com/apache/spark/commit/b3dcb63a682bc31827a86cf381f157a81e9e07ac).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27721: [SPARK-30970][K8S][Core]
Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592043972
**[Test build #119046 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119046/testReport)** for PR 27721 at commit [`b3dcb63`](https://github.com/apache/spark/commit/b3dcb63a682bc31827a86cf381f157a81e9e07ac).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592118927
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119046/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27721: [SPARK-30970][K8S][Core]
Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592064438
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/23792/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-591913196
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23770/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27721: [SPARK-30970][K8S][Core]
Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592397818
**[Test build #119071 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119071/testReport)** for PR 27721 at commit [`b3dcb63`](https://github.com/apache/spark/commit/b3dcb63a682bc31827a86cf381f157a81e9e07ac).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592379885
cc @holdenk for the flaky test which is blocking this PR.
```
- Test basic decommissioning *** FAILED ***
The code passed to eventually never returned normally. Attempted 126 times over 2.0100952450666667 minutes. Last failure message: "++ id -u
```
I created SPARK-30981 for the flaky test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-591960784
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592118913
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun removed a comment on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun removed a comment on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-591885317
@yaooqinn . Please use a specific title. This is only handling `https`. Isn't it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27721: [SPARK-30970][K8S][Core]
Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592335305
**[Test build #119071 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119071/testReport)** for PR 27721 at commit [`b3dcb63`](https://github.com/apache/spark/commit/b3dcb63a682bc31827a86cf381f157a81e9e07ac).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592395002
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23815/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592272948
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23806/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592334059
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23812/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592373495
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119067/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#discussion_r385044558
##########
File path: core/src/main/scala/org/apache/spark/util/Utils.scala
##########
@@ -2772,17 +2772,13 @@ private[spark] object Utils extends Logging {
}
val masterScheme = new URI(masterWithoutK8sPrefix).getScheme
- val resolvedURL = masterScheme.toLowerCase(Locale.ROOT) match {
- case "https" =>
+
+ val resolvedURL = Option(masterScheme).map(_.toLowerCase(Locale.ROOT)) match {
+ case Some("https") =>
masterWithoutK8sPrefix
- case "http" =>
+ case Some("http") =>
logWarning("Kubernetes master URL uses HTTP instead of HTTPS.")
masterWithoutK8sPrefix
- case null =>
- val resolvedURL = s"https://$masterWithoutK8sPrefix"
- logInfo("No scheme specified for kubernetes master URL, so defaulting to https. Resolved " +
- s"URL is $resolvedURL.")
- resolvedURL
case _ =>
Review comment:
if the scheme is undefined and the uri may be valid，then it will be handled by https://github.com/apache/spark/pull/27721/files#diff-d239aee594001f8391676e1047a0381eL2767-L2771 . So，the case None here means the uri is invalid
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592334059
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23812/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27721: [SPARK-30970][K8S][Core]
Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-591982894
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/23776/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592398257
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119071/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27721: [SPARK-30970][K8S][Core]
Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-591971234
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/23776/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592373468
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592309296
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592398257
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119071/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27721: [SPARK-30970][K8S][Core]
Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592394968
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/23815/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27721: [SPARK-30970][K8S][Core]
Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-591949506
**[Test build #119028 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119028/testReport)** for PR 27721 at commit [`b3dcb63`](https://github.com/apache/spark/commit/b3dcb63a682bc31827a86cf381f157a81e9e07ac).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27721: [SPARK-30970][K8S][Core]
Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-591913168
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/23770/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592046785
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-591982911
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592118913
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592398249
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-591913188
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592046799
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119028/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592335305
**[Test build #119071 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119071/testReport)** for PR 27721 at commit [`b3dcb63`](https://github.com/apache/spark/commit/b3dcb63a682bc31827a86cf381f157a81e9e07ac).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-591982924
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23776/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27721: [SPARK-30970][K8S][Core]
Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-591959673
**[Test build #119022 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119022/testReport)** for PR 27721 at commit [`6a7d390`](https://github.com/apache/spark/commit/6a7d390fb70f1d506791aceab3d4c48305c5968a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-591913188
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27721: [SPARK-30970][K8S][Core]
Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592388109
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/23815/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-591949506
**[Test build #119028 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119028/testReport)** for PR 27721 at commit [`b3dcb63`](https://github.com/apache/spark/commit/b3dcb63a682bc31827a86cf381f157a81e9e07ac).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27721: [SPARK-30970][K8S][Core]
Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592263038
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/23806/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-591877392
cc @dongjoon-hyun @srowen, thanks for reviewing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592394995
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592301564
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119062/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27721: [SPARK-30970][K8S][Core]
Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592045284
**[Test build #119028 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119028/testReport)** for PR 27721 at commit [`b3dcb63`](https://github.com/apache/spark/commit/b3dcb63a682bc31827a86cf381f157a81e9e07ac).
* This patch **fails SparkR unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-591982924
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23776/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592410907
OK @dongjoon-hyun and thanks for merging
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592334057
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#discussion_r385092282
##########
File path: core/src/main/scala/org/apache/spark/util/Utils.scala
##########
@@ -2772,17 +2772,13 @@ private[spark] object Utils extends Logging {
}
val masterScheme = new URI(masterWithoutK8sPrefix).getScheme
- val resolvedURL = masterScheme.toLowerCase(Locale.ROOT) match {
- case "https" =>
+
+ val resolvedURL = Option(masterScheme).map(_.toLowerCase(Locale.ROOT)) match {
+ case Some("https") =>
masterWithoutK8sPrefix
- case "http" =>
+ case Some("http") =>
logWarning("Kubernetes master URL uses HTTP instead of HTTPS.")
masterWithoutK8sPrefix
- case null =>
- val resolvedURL = s"https://$masterWithoutK8sPrefix"
- logInfo("No scheme specified for kubernetes master URL, so defaulting to https. Resolved " +
- s"URL is $resolvedURL.")
- resolvedURL
case _ =>
Review comment:
for example `k8s:///https://host:port` will be resolved to `/https://host:port` first and if we map `None` to the old logic, the final uri will be `k8s://https:///https://host:port`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592394995
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592043972
**[Test build #119046 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119046/testReport)** for PR 27721 at commit [`b3dcb63`](https://github.com/apache/spark/commit/b3dcb63a682bc31827a86cf381f157a81e9e07ac).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on issue #27721:
[SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #27721: [SPARK-30970][K8S][Core] Fix NPE while resolving k8s master url
URL: https://github.com/apache/spark/pull/27721#issuecomment-592334540
retest this please, the k8s it test seems quite flaky.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org