You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/22 14:02:26 UTC

[GitHub] [pulsar] imaffe commented on a diff in pull request #18951: [improve][fn] support reading config options from file in Function Python Runner

imaffe commented on code in PR #18951:
URL: https://github.com/apache/pulsar/pull/18951#discussion_r1055492238


##########
pulsar-functions/instance/src/main/python/python_instance_main.py:
##########
@@ -88,8 +132,10 @@ def main():
   parser.add_argument('--extra_dependency_repository', required=False, help='For packaged python like wheel files, any extra repository to pull the dependencies from')
   parser.add_argument('--state_storage_serviceurl', required=False, help='Managed State Storage Service Url')
   parser.add_argument('--cluster_name', required=True, help='The name of the cluster this instance is running on')

Review Comment:
   Should the arugments be declared required ? If a config is provided in file, then maybe the config from command line is not required any more



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org