You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2021/01/10 13:08:13 UTC
[GitHub] [avro] tjwp opened a new pull request #1048: AVRO-3023: Test against Ruby 3.0
tjwp opened a new pull request #1048:
URL: https://github.com/apache/avro/pull/1048
### Jira
[AVRO-3023](https://issues.apache.org/jira/browse/AVRO-3023) Test against Ruby 3.0.
Ruby 3.0 was released 12/25/2020: [announcement](https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/)
### Tests
This is only a test change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] tjwp commented on a change in pull request #1048: AVRO-3023: Test against Ruby 3.0
Posted by GitBox <gi...@apache.org>.
tjwp commented on a change in pull request #1048:
URL: https://github.com/apache/avro/pull/1048#discussion_r567428345
##########
File path: .github/workflows/test-lang-ruby.yml
##########
@@ -76,10 +77,11 @@ jobs:
- '2.5'
- '2.6'
- '2.7'
+ - '3.0'
steps:
- uses: actions/checkout@v2
- - uses: actions/setup-ruby@v1
+ - uses: ruby/setup-ruby@v1
Review comment:
Opened https://issues.apache.org/jira/browse/INFRA-21366 to ask the question
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] kojiromike commented on a change in pull request #1048: AVRO-3023: Test against Ruby 3.0
Posted by GitBox <gi...@apache.org>.
kojiromike commented on a change in pull request #1048:
URL: https://github.com/apache/avro/pull/1048#discussion_r567484913
##########
File path: .github/workflows/test-lang-ruby.yml
##########
@@ -76,10 +77,11 @@ jobs:
- '2.5'
- '2.6'
- '2.7'
+ - '3.0'
steps:
- uses: actions/checkout@v2
- - uses: actions/setup-ruby@v1
+ - uses: ruby/setup-ruby@v1
Review comment:
> If the build was able to use ruby/setup-ruby successfully, does that mean that it was already approved?
No, I don't believe it does. IIUC this build ran on your fork in your account, which isn't restricted by Apache rules.
But since you got the official approval from infra we are good to go.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] tjwp commented on a change in pull request #1048: AVRO-3023: Test against Ruby 3.0
Posted by GitBox <gi...@apache.org>.
tjwp commented on a change in pull request #1048:
URL: https://github.com/apache/avro/pull/1048#discussion_r567426513
##########
File path: .github/workflows/test-lang-ruby.yml
##########
@@ -76,10 +77,11 @@ jobs:
- '2.5'
- '2.6'
- '2.7'
+ - '3.0'
steps:
- uses: actions/checkout@v2
- - uses: actions/setup-ruby@v1
+ - uses: ruby/setup-ruby@v1
Review comment:
If the build was able to use `ruby/setup-ruby` successfully, does that mean that it was already approved?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] kojiromike merged pull request #1048: AVRO-3023: Test against Ruby 3.0
Posted by GitBox <gi...@apache.org>.
kojiromike merged pull request #1048:
URL: https://github.com/apache/avro/pull/1048
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] kojiromike commented on a change in pull request #1048: AVRO-3023: Test against Ruby 3.0
Posted by GitBox <gi...@apache.org>.
kojiromike commented on a change in pull request #1048:
URL: https://github.com/apache/avro/pull/1048#discussion_r554586710
##########
File path: .github/workflows/test-lang-ruby.yml
##########
@@ -76,10 +77,11 @@ jobs:
- '2.5'
- '2.6'
- '2.7'
+ - '3.0'
steps:
- uses: actions/checkout@v2
- - uses: actions/setup-ruby@v1
+ - uses: ruby/setup-ruby@v1
Review comment:
We need infra- approval to run actions that aren't official. Do you know if this one's approved?
See https://issues.apache.org/jira/browse/INFRA-21253 for example.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org