You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/02/01 01:58:00 UTC
[jira] [Commented] (WICKET-6950) wicket web-sockets implementation does not allow to configure/access web socket session on onOpen
[ https://issues.apache.org/jira/browse/WICKET-6950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485017#comment-17485017 ]
ASF GitHub Bot commented on WICKET-6950:
----------------------------------------
reiern70 commented on a change in pull request #496:
URL: https://github.com/apache/wicket/pull/496#discussion_r796214845
##########
File path: wicket-native-websocket/wicket-native-websocket-javax/src/main/java/org/apache/wicket/protocol/ws/javax/WicketEndpoint.java
##########
@@ -43,6 +46,118 @@
*/
public class WicketEndpoint extends Endpoint
{
+ private static class JavaxWebSocketSessionWrapper implements IWebSocketSession
Review comment:
done
##########
File path: wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/WebSocketSettings.java
##########
@@ -245,6 +246,16 @@ public Executor getSendPayloadExecutor()
return sendPayloadExecutor;
}
+ /**
+ * Allows to configure {@link org.apache.wicket.protocol.ws.api.IWebSocketSession}
+ *
+ * @param webSocketSession The {@link org.apache.wicket.protocol.ws.api.IWebSocketSession}
+ */
+ public void configureSession(IWebSocketSession webSocketSession)
Review comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> wicket web-sockets implementation does not allow to configure/access web socket session on onOpen
> -------------------------------------------------------------------------------------------------
>
> Key: WICKET-6950
> URL: https://issues.apache.org/jira/browse/WICKET-6950
> Project: Wicket
> Issue Type: Improvement
> Affects Versions: 10.0.0, 9.7.0
> Reporter: Ernesto Reinaldo Barreiro
> Assignee: Ernesto Reinaldo Barreiro
> Priority: Major
> Fix For: 9.8.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)