You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by venkat sairam <ve...@gmail.com> on 2017/03/03 15:11:27 UTC

Review Request 57291: HiveView2.0: Issues in worksheet

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57291/
-----------------------------------------------------------

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-20303
    https://issues.apache.org/jira/browse/AMBARI-20303


Repository: ambari


Description
-------

Worksheet tab is provided with the button to close the worksheet and upon double-click of worksheet tab, rename modal will be opened.


Diffs
-----

  contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js f820ea0 
  contrib/views/hive20/src/main/resources/ui/app/routes/queries.js 4ef3834 
  contrib/views/hive20/src/main/resources/ui/app/routes/queries/new.js 7bd2214 
  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js d08a47b 
  contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 6b7fc6a 
  contrib/views/hive20/src/main/resources/ui/app/templates/queries.hbs b8e19da 
  contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 8a771eb 


Diff: https://reviews.apache.org/r/57291/diff/1/


Testing
-------

Manual testing done


Thanks,

venkat sairam

Re: Review Request 57291: HiveView2.0: Issues in worksheet

Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57291/#review167956
-----------------------------------------------------------


Ship it!




Ship It!

- Nitiraj Rathore


On March 3, 2017, 3:11 p.m., venkat sairam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57291/
> -----------------------------------------------------------
> 
> (Updated March 3, 2017, 3:11 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-20303
>     https://issues.apache.org/jira/browse/AMBARI-20303
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Worksheet tab is provided with the button to close the worksheet and upon double-click of worksheet tab, rename modal will be opened.
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js f820ea0 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries.js 4ef3834 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/new.js 7bd2214 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js d08a47b 
>   contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 6b7fc6a 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries.hbs b8e19da 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 8a771eb 
> 
> 
> Diff: https://reviews.apache.org/r/57291/diff/1/
> 
> 
> Testing
> -------
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Re: Review Request 57291: HiveView2.0: Issues in worksheet

Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57291/#review167833
-----------------------------------------------------------


Ship it!




Ship It!

- Gaurav Nagar


On March 3, 2017, 3:11 p.m., venkat sairam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57291/
> -----------------------------------------------------------
> 
> (Updated March 3, 2017, 3:11 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-20303
>     https://issues.apache.org/jira/browse/AMBARI-20303
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Worksheet tab is provided with the button to close the worksheet and upon double-click of worksheet tab, rename modal will be opened.
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js f820ea0 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries.js 4ef3834 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/new.js 7bd2214 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js d08a47b 
>   contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 6b7fc6a 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries.hbs b8e19da 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 8a771eb 
> 
> 
> Diff: https://reviews.apache.org/r/57291/diff/1/
> 
> 
> Testing
> -------
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Re: Review Request 57291: HiveView2.0: Issues in worksheet

Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57291/#review167957
-----------------------------------------------------------


Ship it!




Ship It!

- Pallav Kulshreshtha


On March 3, 2017, 3:11 p.m., venkat sairam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57291/
> -----------------------------------------------------------
> 
> (Updated March 3, 2017, 3:11 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-20303
>     https://issues.apache.org/jira/browse/AMBARI-20303
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Worksheet tab is provided with the button to close the worksheet and upon double-click of worksheet tab, rename modal will be opened.
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js f820ea0 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries.js 4ef3834 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/new.js 7bd2214 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js d08a47b 
>   contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 6b7fc6a 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries.hbs b8e19da 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 8a771eb 
> 
> 
> Diff: https://reviews.apache.org/r/57291/diff/1/
> 
> 
> Testing
> -------
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>