You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/12/17 01:00:35 UTC
[GitHub] [yunikorn-k8shim] craigcondit opened a new pull request, #503: [YUNIKORN-1480] Fix klog crash when logging at debug level
craigcondit opened a new pull request, #503:
URL: https://github.com/apache/yunikorn-k8shim/pull/503
### What is this PR for?
Fix a crash in Kubernetes klog when debug logging is enabled. Klog can only be initialized once, and subsequent updates will crash the scheduler.
### What type of PR is it?
* [x] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1480
### How should this be tested?
Manual verification that crash no longer occurs.
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] wilfred-s closed pull request #503: [YUNIKORN-1480] Fix klog crash when logging at debug level
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #503: [YUNIKORN-1480] Fix klog crash when logging at debug level
URL: https://github.com/apache/yunikorn-k8shim/pull/503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #503: [YUNIKORN-1480] Fix klog crash when logging at debug level
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #503:
URL: https://github.com/apache/yunikorn-k8shim/pull/503#issuecomment-1355898132
# [Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/503?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#503](https://codecov.io/gh/apache/yunikorn-k8shim/pull/503?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (69a7e29) into [master](https://codecov.io/gh/apache/yunikorn-k8shim/commit/de8d8b62fc35bfe528b7fa3334673e20584e3f20?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de8d8b6) will **decrease** coverage by `0.06%`.
> The diff coverage is `33.33%`.
```diff
@@ Coverage Diff @@
## master #503 +/- ##
==========================================
- Coverage 69.48% 69.41% -0.07%
==========================================
Files 45 45
Lines 7711 7714 +3
==========================================
- Hits 5358 5355 -3
- Misses 2157 2162 +5
- Partials 196 197 +1
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-k8shim/pull/503?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/conf/schedulerconf.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/503/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmYvc2NoZWR1bGVyY29uZi5nbw==) | `81.04% <33.33%> (-2.05%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org