You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/01/17 13:19:57 UTC
[GitHub] [zookeeper] eolivelli opened a new pull request #1226:
ZOOKEEPER-3695 Source release tarball does not match repository in 3.6.0
eolivelli opened a new pull request #1226: ZOOKEEPER-3695 Source release tarball does not match repository in 3.6.0
URL: https://github.com/apache/zookeeper/pull/1226
- use the same configuration as in Apache Parent Pom to generate the source tarball
- drop the custom made configuration for the source tarball
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] eolivelli commented on issue #1226: ZOOKEEPER-3695
Source release tarball does not match repository in 3.6.0
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #1226: ZOOKEEPER-3695 Source release tarball does not match repository in 3.6.0
URL: https://github.com/apache/zookeeper/pull/1226#issuecomment-575660564
Use this command to test it:
`mvn clean install -Pfull-build -Papache-release -DskipTests`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] asfgit closed pull request #1226: ZOOKEEPER-3695 Source
release tarball does not match repository in 3.6.0
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1226: ZOOKEEPER-3695 Source release tarball does not match repository in 3.6.0
URL: https://github.com/apache/zookeeper/pull/1226
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] eolivelli commented on a change in pull request #1226:
ZOOKEEPER-3695 Source release tarball does not match repository in 3.6.0
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #1226: ZOOKEEPER-3695 Source release tarball does not match repository in 3.6.0
URL: https://github.com/apache/zookeeper/pull/1226#discussion_r367931268
##########
File path: pom.xml
##########
@@ -267,6 +267,44 @@
<activeByDefault>true</activeByDefault>
</activation>
</profile>
+ <profile>
+ <id>apache-release</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-assembly-plugin</artifactId>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.apache.resources</groupId>
+ <artifactId>apache-source-release-assembly-descriptor</artifactId>
Review comment:
This is the same as the official Apache one:
https://github.com/apache/maven-apache-parent/blob/master/pom.xml#L381
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services