[GitHub] [freemarker] vdiravka commented on a change in pull request #71: Added github actions to build Freemarker on ubuntu 18.04

[GitBox <gi...@apache.org>]

vdiravka commented on a change in pull request #71:
URL: https://github.com/apache/freemarker/pull/71#discussion_r699627582



##########
File path: .github/workflows/ci.yaml
##########
@@ -0,0 +1,19 @@
+name: Java CI
+
+on: [push]

Review comment:
       ```suggestion
   on: [push, pull_request]
   ```

##########
File path: .github/workflows/ci.yaml
##########
@@ -0,0 +1,19 @@
+name: Java CI
+
+on: [push]

Review comment:
       consider adding:
   `timeout-minutes: 5`

##########
File path: .github/workflows/ci.yaml
##########
@@ -0,0 +1,19 @@
+name: Java CI
+
+on: [push]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up JDK 1.8
+        uses: actions/setup-java@v1

Review comment:
       ```suggestion
           uses: actions/setup-java@v2
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@freemarker.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org