You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/03/07 20:45:43 UTC

[GitHub] [arrow] kou commented on a diff in pull request #34490: MINOR: [Go][CI] Fix indentation and syntax for yml file

kou commented on code in PR #34490:
URL: https://github.com/apache/arrow/pull/34490#discussion_r1128565576


##########
.github/workflows/go.yml:
##########
@@ -306,11 +306,13 @@ jobs:
         run: brew install apache-arrow pkg-config
       - name: Install staticcheck
         run: go install honnef.co/go/tools/cmd/staticcheck@${{ matrix.staticcheck }}
-      - name: Build
+      - name: Add To pkg config path
         shell: bash
         run: |
-           echo "PKG_CONFIG_PATH=/usr/local/Cellar/openssl@3/3.0.8/lib/pkgconfig:$PKG_CONFIG_PATH" >> $GITHUB_ENV
-          ci/scripts/go_build.sh $(pwd)
+          echo "PKG_CONFIG_PATH=/usr/local/Cellar/openssl@3/3.0.8/lib/pkgconfig:$PKG_CONFIG_PATH" >> $GITHUB_ENV

Review Comment:
   How about using `brew --preifx` to get `openssl@3` path?
   
   ```suggestion
             echo "PKG_CONFIG_PATH=$(brew --prefix openssl@3)/lib/pkgconfig:$PKG_CONFIG_PATH" >> $GITHUB_ENV
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org