You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by adeneche <gi...@git.apache.org> on 2015/10/21 21:19:05 UTC
[GitHub] drill pull request: DRILL-2967: Incompatible types error reported ...
GitHub user adeneche opened a pull request:
https://github.com/apache/drill/pull/213
DRILL-2967: Incompatible types error reported in a "not in" query wit…
…h compatible data types
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/adeneche/incubator-drill fixing-mergejoin
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/213.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #213
----
commit 285bef9ab4ea7c0bbd1a7b6bad3f63d797b4edcc
Author: adeneche <ad...@gmail.com>
Date: 2015-10-19T22:40:05Z
DRILL-2967: Incompatible types error reported in a "not in" query with compatible data types
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-2967: Incompatible types error reported ...
Posted by adeneche <gi...@git.apache.org>.
Github user adeneche commented on the pull request:
https://github.com/apache/drill/pull/213#issuecomment-149999031
@mehant can you please review ? thx
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-2967: Incompatible types error reported ...
Posted by mehant <gi...@git.apache.org>.
Github user mehant commented on the pull request:
https://github.com/apache/drill/pull/213#issuecomment-151273785
+1.
On a side note, I remember there was some discussion earlier about having an explicit nullable vector or not, in this particular case it might be better to have an explicit nullable vector and let the implicit cast logic handle going between a null type and others, instead of the operator having to deal with this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-2967: Incompatible types error reported ...
Posted by adeneche <gi...@git.apache.org>.
Github user adeneche closed the pull request at:
https://github.com/apache/drill/pull/213
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---