You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/11/18 08:14:14 UTC

[GitHub] [superset] Miisakiiisakii opened a new pull request, #22164: fix: the legend does not preserves the order of metrics

Miisakiiisakii opened a new pull request, #22164:
URL: https://github.com/apache/superset/pull/22164

   ### SUMMARY
   Pandas pivot_table modifies the order of columns.
   Reorder the table columns to preserve the legend order
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   ![WX20221118-151319](https://user-images.githubusercontent.com/34932975/202653438-d35938b6-4b98-43ee-bf0e-bf96aa9a45a7.png)
   ![WX20221118-151838](https://user-images.githubusercontent.com/34932975/202653444-4441d973-7229-4c06-802d-e4c76f6fc29c.png)
   
   
   ### TESTING INSTRUCTIONS
   
   
   ### ADDITIONAL INFORMATION
   
   
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
   - [ ] Migration is atomic, supports rollback & is backwards-compatible
   - [ ] Confirm DB migration upgrade and downgrade tested
   - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix: the legend does not preserves the order of metrics [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #22164:
URL: https://github.com/apache/superset/pull/22164#issuecomment-1942138077

   Looks like this PR needs further discussion and touch-ups to pass CI. I'll convert it to draft for now. Please re-open when it is read for re-review, and we can merge it if people are aligned on the approach/solution. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] M1s4k1 commented on pull request #22164: fix: the legend does not preserves the order of metrics

Posted by GitBox <gi...@apache.org>.
M1s4k1 commented on PR #22164:
URL: https://github.com/apache/superset/pull/22164#issuecomment-1319710389

   > 我认为此更改没有意义，因为在这些更改之后，无法手动重新排序指标。
   
   有什么设置可以使legend的顺序与metrics的顺序相同么? 文档中没有找到. 折线图里调整metrics之后,legend就会被按照字母顺序排列.(我并不熟练,只是目前需要去维护于此相关的项目)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix: the legend does not preserves the order of metrics [superset]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #22164:
URL: https://github.com/apache/superset/pull/22164#issuecomment-2043244237

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/22164?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   Attention: Patch coverage is `0%` with `2 lines` in your changes are missing coverage. Please review.
   > Project coverage is 54.22%. Comparing base [(`17c2bd8`)](https://app.codecov.io/gh/apache/superset/commit/17c2bd89a6ecc480851801d58fadbf130704f784?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`9154a4f`)](https://app.codecov.io/gh/apache/superset/pull/22164?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   > Report is 2459 commits behind head on master.
   
   | [Files](https://app.codecov.io/gh/apache/superset/pull/22164?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [superset/utils/pandas\_postprocessing/pivot.py](https://app.codecov.io/gh/apache/superset/pull/22164?src=pr&el=tree&filepath=superset%2Futils%2Fpandas_postprocessing%2Fpivot.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nL3Bpdm90LnB5) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/22164?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #22164       +/-   ##
   ===========================================
   - Coverage   66.99%   54.22%   -12.78%     
   ===========================================
     Files        1833     2011      +178     
     Lines       69936    91477    +21541     
     Branches     7572     7572               
   ===========================================
   + Hits        46855    49604     +2749     
   - Misses      21121    39913    +18792     
     Partials     1960     1960               
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/22164/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hive](https://app.codecov.io/gh/apache/superset/pull/22164/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `54.37% <0.00%> (+1.76%)` | :arrow_up: |
   | [mysql](https://app.codecov.io/gh/apache/superset/pull/22164/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [postgres](https://app.codecov.io/gh/apache/superset/pull/22164/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [presto](https://app.codecov.io/gh/apache/superset/pull/22164/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `53.72% <0.00%> (+1.23%)` | :arrow_up: |
   | [python](https://app.codecov.io/gh/apache/superset/pull/22164/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `54.51% <0.00%> (-26.88%)` | :arrow_down: |
   | [sqlite](https://app.codecov.io/gh/apache/superset/pull/22164/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [unit](https://app.codecov.io/gh/apache/superset/pull/22164/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/22164?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix: the legend does not preserves the order of metrics [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #22164: fix:  the legend does not preserves the order of metrics
URL: https://github.com/apache/superset/pull/22164


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] zhaoyongjie commented on pull request #22164: fix: the legend does not preserves the order of metrics

Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on PR #22164:
URL: https://github.com/apache/superset/pull/22164#issuecomment-1319712818

   > 
   
   手动调整顺序, 即metrics control里面的metrics可以手动调整顺序.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] M1s4k1 commented on pull request #22164: fix: the legend does not preserves the order of metrics

Posted by GitBox <gi...@apache.org>.
M1s4k1 commented on PR #22164:
URL: https://github.com/apache/superset/pull/22164#issuecomment-1319722421

   > 手动调整顺序, 即metrics control里面的metrics可以手动调整顺序.
   
   您的意思的是调整这里的顺序吗? 但是在折线图中调整这里的顺序,legend仍然会被重排为字母顺序
   ![WX20221118-165846](https://user-images.githubusercontent.com/34932975/202662877-fc833c1a-1543-4776-bf96-dfd5dffa9b8c.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] M1s4k1 commented on pull request #22164: fix: the legend does not preserves the order of metrics

Posted by GitBox <gi...@apache.org>.
M1s4k1 commented on PR #22164:
URL: https://github.com/apache/superset/pull/22164#issuecomment-1319763247

   > > > 手动调整顺序, 即metrics control里面的metrics可以手动调整顺序.
   > > 
   > > 
   > > 您的意思的是调整这里的顺序吗? 但是在折线图中调整这里的顺序,legend仍然会被重排为字母顺序 ![WX20221118-165846](https://user-images.githubusercontent.com/34932975/202662877-fc833c1a-1543-4776-bf96-dfd5dffa9b8c.png)
   > 
   > 我刚明白, 您如果只关心Legend顺序, 那么这是个前端问题, 你需要修改前端的line-chart plugins. 而不是修改post_processing operator.
   
   感谢 我再去看看


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] M1s4k1 commented on pull request #22164: fix: the legend does not preserves the order of metrics

Posted by GitBox <gi...@apache.org>.
M1s4k1 commented on PR #22164:
URL: https://github.com/apache/superset/pull/22164#issuecomment-1319763719

   感谢 我再去看看


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] zhaoyongjie commented on pull request #22164: fix: the legend does not preserves the order of metrics

Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on PR #22164:
URL: https://github.com/apache/superset/pull/22164#issuecomment-1319736533

   > > 手动调整顺序, 即metrics control里面的metrics可以手动调整顺序.
   > 
   > 您的意思的是调整这里的顺序吗? 但是在折线图中调整这里的顺序,legend仍然会被重排为字母顺序 ![WX20221118-165846](https://user-images.githubusercontent.com/34932975/202662877-fc833c1a-1543-4776-bf96-dfd5dffa9b8c.png)
   
   
   我刚明白, 您如果只关心Legend顺序, 那么这是个前端问题, 你需要修改前端的line-chart plugins. 而不是修改post_processing operator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix: the legend does not preserves the order of metrics [superset]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #22164:
URL: https://github.com/apache/superset/pull/22164#issuecomment-1908608519

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/22164?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   Attention: `2 lines` in your changes are missing coverage. Please review.
   > Comparison is base [(`17c2bd8`)](https://app.codecov.io/gh/apache/superset/commit/17c2bd89a6ecc480851801d58fadbf130704f784?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 66.99% compared to head [(`9154a4f`)](https://app.codecov.io/gh/apache/superset/pull/22164?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 54.22%.
   > Report is 1939 commits behind head on master.
   
   | [Files](https://app.codecov.io/gh/apache/superset/pull/22164?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [superset/utils/pandas\_postprocessing/pivot.py](https://app.codecov.io/gh/apache/superset/pull/22164?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nL3Bpdm90LnB5) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/22164?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #22164       +/-   ##
   ===========================================
   - Coverage   66.99%   54.22%   -12.78%     
   ===========================================
     Files        1833     2011      +178     
     Lines       69936    91477    +21541     
     Branches     7572     7572               
   ===========================================
   + Hits        46855    49604     +2749     
   - Misses      21121    39913    +18792     
     Partials     1960     1960               
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/22164/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hive](https://app.codecov.io/gh/apache/superset/pull/22164/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `54.37% <0.00%> (+1.76%)` | :arrow_up: |
   | [mysql](https://app.codecov.io/gh/apache/superset/pull/22164/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [postgres](https://app.codecov.io/gh/apache/superset/pull/22164/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [presto](https://app.codecov.io/gh/apache/superset/pull/22164/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `53.72% <0.00%> (+1.23%)` | :arrow_up: |
   | [python](https://app.codecov.io/gh/apache/superset/pull/22164/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `54.51% <0.00%> (-26.88%)` | :arrow_down: |
   | [sqlite](https://app.codecov.io/gh/apache/superset/pull/22164/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [unit](https://app.codecov.io/gh/apache/superset/pull/22164/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/22164?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org