You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/10/17 15:35:17 UTC
[GitHub] StefanRRichter commented on a change in pull request #6860:
[FLINK-10567]Fix TtlStateSerializer lost field during duplicate()
StefanRRichter commented on a change in pull request #6860: [FLINK-10567]Fix TtlStateSerializer lost field during duplicate()
URL: https://github.com/apache/flink/pull/6860#discussion_r225984090
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlStateFactory.java
##########
@@ -224,7 +224,7 @@ protected Object getField(@Nonnull TtlValue<T> v, int index) {
TypeSerializer<?> ... originalSerializers) {
Preconditions.checkNotNull(originalSerializers);
Preconditions.checkArgument(originalSerializers.length == 2);
- return new TtlSerializer<>(precomputed, (TypeSerializer<T>) originalSerializers[1]);
+ return new TtlSerializer<>(precomputed, (TypeSerializer<T>) originalSerializers[0], (TypeSerializer<T>) originalSerializers[1]);
Review comment:
We could just `return new TtlSerializer<>(precomputed, originalSerializers);`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services