You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@royale.apache.org by ap...@gmail.com on 2022/03/14 06:35:23 UTC
[DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
This is the discussion thread.
Thanks,
Yishay Weiss
RE: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
Posted by Yishay Weiss <yi...@hotmail.com>.
Hi Josh,
Thanks for checking this. I am not sure if there’s a strict protocol about the approval script. I don’t think running the approval script before calling for a vote can saved total time, so IMO it boils down to how we allocate time on the release process (voters versus RM). I am open to discuss pros and cons.
ASDoc does get run as part of the release steps, but I am pretty sure it’s run with flash, so that error was not detected.
Does anyone have clues as to what might be causing this?
Yishay
From: Josh Tynjala<ma...@bowlerhat.dev>
Sent: Tuesday, March 15, 2022 7:40 PM
To: dev@royale.apache.org<ma...@royale.apache.org>
Subject: Re: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
Does the release process include testing whether the approval script works
or not? Maybe we should make that part of the steps before the [VOTE] and
[DISCUSS] threads get sent to the mailing list.
--
Josh Tynjala
Bowler Hat LLC <https://bowlerhat.dev>
On Sun, Mar 13, 2022 at 11:35 PM <ap...@gmail.com> wrote:
> This is the discussion thread.
>
> Thanks,
> Yishay Weiss
Re: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
Posted by Josh Tynjala <jo...@bowlerhat.dev>.
Does the release process include testing whether the approval script works
or not? Maybe we should make that part of the steps before the [VOTE] and
[DISCUSS] threads get sent to the mailing list.
--
Josh Tynjala
Bowler Hat LLC <https://bowlerhat.dev>
On Sun, Mar 13, 2022 at 11:35 PM <ap...@gmail.com> wrote:
> This is the discussion thread.
>
> Thanks,
> Yishay Weiss
RE: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
Posted by Yishay Weiss <yi...@hotmail.com>.
I just belatedly cancelled RC2 vote, but RC3 vote is still on.
From: apacheroyaleci@gmail.com<ma...@gmail.com>
Sent: Monday, March 14, 2022 8:35 AM
To: dev@royale.apache.org<ma...@royale.apache.org>
Subject: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
This is the discussion thread.
Thanks,
Yishay Weiss
Re: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
Posted by Piotr Zarzycki <pi...@gmail.com>.
Main Maven build on Jenkins is still failing, but I think it may not be
problem on our sight, but rather something happened with our project in
nightly -> https://nightlies.apache.org/Royale/Royale-asjs/ - it has been
removed for some reason. I think I will contact infrastructure and ask what
has happened.
czw., 17 mar 2022 o 08:22 Yishay Weiss <yi...@hotmail.com> napisał(a):
> >Josh’s pick
>
> I meant Josh’s fix of course (being picky here).
> From: Yishay Weiss<ma...@hotmail.com>
> Sent: Thursday, March 17, 2022 9:12 AM
> To: Josh Tynjala<ma...@bowlerhat.dev>; dev@royale.apache.org
> <ma...@royale.apache.org>
> Subject: RE: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
>
> The examples are run as part of the step 11, but mvn only. The ant
> examples are only built after release approval. For some reason MenuExample
> was working in mvn but not in ant. That’s why the release steps did not
> fail prior to approval script. For anybody curious to find out why these
> differences between mvn and ant exist, this is the maven output [2] taken
> from the CI logs [1]. You can compare it to Josh’s ant output upthread.
>
> Unrelated, I scheduled a daily job for ASDocs example so we can track
> ASDocs errors, as they seem to be pretty common.
>
> I will see if I can figure out if I can continue the release from the
> existing release branch after cherry-picking Josh’s pick.
>
> Thanks.
>
> [1] Royale_Release_Step_011 #26 Console [Jenkins] (azure.com)<
> http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/view/Royale_Release_Steps/job/Royale_Release_Step_011/26/consoleFull
> >
>
>
> [2] [INFO] [INFO] ---------------< org.apache.royale.examples:MenuExample
> >---------------
>
> [INFO] [INFO] Building Apache Royale: Examples: Royale: MenuExample 0.9.9
> [195/265]
>
> [INFO] [INFO] --------------------------------[ swf
> ]---------------------------------
>
> [INFO] [INFO]
>
> [INFO] [INFO] --- maven-enforcer-plugin:1.4.1:enforce
> (enforce-maven-version) @ MenuExample ---
>
> [INFO] [INFO]
>
> [INFO] [INFO] --- maven-resources-plugin:3.1.0:copy-resources
> (copy-resources-debug) @ MenuExample ---
>
> [INFO] [INFO] Using 'UTF-8' encoding to copy filtered resources.
>
> [INFO] [INFO] skip non existing resourceDirectory
> C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\src\main\resources
>
> [INFO] [INFO]
>
> [INFO] [INFO] --- maven-resources-plugin:3.1.0:copy-resources
> (copy-resources-release) @ MenuExample ---
>
> [INFO] [INFO] Using 'UTF-8' encoding to copy filtered resources.
>
> [INFO] [INFO] skip non existing resourceDirectory
> C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\src\main\resources\assets
>
> [INFO] [INFO]
>
> [INFO] [INFO] --- maven-remote-resources-plugin:1.7.0:process
> (process-resource-bundles) @ MenuExample ---
>
> [INFO] [INFO] Preparing remote bundle
> org.apache:apache-jar-resource-bundle:1.4
>
> [INFO] [INFO] Copying 3 resources from 1 bundle.
>
> [INFO] [INFO]
>
> [INFO] [INFO] --- maven-resources-plugin:3.1.0:resources
> (default-resources) @ MenuExample ---
>
> [INFO] [INFO] Using 'UTF-8' encoding to copy filtered resources.
>
> [INFO] [INFO] skip non existing resourceDirectory
> C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\src\main\resources
>
> [INFO] [INFO] Copying 3 resources
>
> [INFO] [INFO]
>
> [INFO] [INFO] --- royale-maven-plugin:0.9.9:compile-app
> (default-compile-app) @ MenuExample ---
>
> [INFO] [INFO] Executing MXMLC in tool group Royale with args:
> [-load-config=C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\target\compile-app-config.xml,
> -metadata.date=2022-03-13T09:39:40Z,
> -metadata.dateFormat=yyyy-MM-dd'T'HH:mm:ss'Z',
> -js-output=C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\target\javascript,
> -compiler.targets=SWF,JSRoyale,
> C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\src\main\royale\MenuExample.mxml]
>
> [INFO] Loading configuration:
> C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\target\compile-app-config.xml
>
> [INFO]
>
> [INFO] 57676 bytes written to
> C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\target\MenuExample-0.9.9.swf
> in 0.602 seconds
>
> [INFO] Mar 13, 2022 12:00:56 PM
> com.google.javascript.jscomp.LoggerErrorManager printSummary
>
> [INFO] INFO: 0 error(s), 0 warning(s), 97.8% typed
>
> [INFO] The project 'MenuExample' has been successfully compiled and
> optimized.
>
>
> From: Yishay Weiss<ma...@hotmail.com>
> Sent: Wednesday, March 16, 2022 7:14 AM
> To: Josh Tynjala<ma...@bowlerhat.dev>; dev@royale.apache.org
> <ma...@royale.apache.org>
> Subject: Re: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
>
> Thanks, I will see if I can figure out why this didn't fail at an earlier
> stage. I will look into why asdoc example isn't run regularly on CI.
>
> My CLT-L09. On O2.
>
>
> -------- Original message --------
> From: Josh Tynjala <jo...@bowlerhat.dev>
> Date: Tue, 15 Mar 2022, 23:07
> To: dev@royale.apache.org
> Subject: Re: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
> I ran into two separate issues with the approval script.
>
> The first issue was the ASDoc example build failing in the JS-only SDK,
> which I discovered was happening because I didn't realize that I had an
> AIR_HOME environment variable set externally. I cleared AIR_HOME, and
> that's fixed it for me. No RC needed for this.
>
> The second issue was the MenuExample example build failing. My commit today
> fixes that. A new RC is needed to resolve this one with my commit.
>
> --
> Josh Tynjala
> Bowler Hat LLC <https://bowlerhat.dev>
>
>
> On Tue, Mar 15, 2022 at 1:52 PM Yishay Weiss <yi...@hotmail.com>
> wrote:
>
> > I’m not following. Was the problem AIR_HOME or what your latest commit
> > fixed? Do we need another RC?
> >
> > From: Josh Tynjala<ma...@bowlerhat.dev>
> > Sent: Tuesday, March 15, 2022 10:01 PM
> > To: dev@royale.apache.org<ma...@royale.apache.org>
> > Subject: Re: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
> >
> > I discovered that I had an AIR_HOME environment variable set elsewhere,
> and
> > that was causing the ASDoc build failure. In the approval script, I can
> now
> > reach MenuExample with both use-flash and without.
> >
> > I pushed a commit to develop that fixes the MenuExample build issue.
> >
> > --
> > Josh Tynjala
> > Bowler Hat LLC <https://bowlerhat.dev>
> >
> >
> > On Tue, Mar 15, 2022 at 10:37 AM Josh Tynjala <joshtynjala@bowlerhat.dev
> >
> > wrote:
> >
> > > When running the approval script *without* -Duse-flash=true (in other
> > > words, JS-only), I get the following error when it tries to build the
> > ASDoc
> > > example. However, it seems to build that example correctly when I use
> > > -Duse-flash=true.
> > >
> > > json:
> > > ROYALE_COMPILER_HOME:
> > >
> >
> /Users/joshtynjala/Desktop/ApacheRoyale/apache-royale-0.9.9-src/royale-asjs/js
> > > 16.6482905 seconds
> > > java.lang.NullPointerException: Cannot invoke
> > > "org.apache.royale.compiler.tree.as.IASNode.getSourcePath()" because
> > "node"
> > > is null
> > > org.apache.royale.compiler.internal.codegen.as
> > .ASBlockWalker.walk(ASBlockWalker.java:163)org.apache.royale.compiler.
> > internal.codegen.as
> >
> .ASBlockWalker.visitCompilationUnit(ASBlockWalker.java:188)org.apache.royale.compiler.internal.codegen.js.JSWriter.writeTo(JSWriter.java:96)org.apache.royale.compiler.internal.codegen.js.JSWriter.writeTo(JSWriter.java:80)org.apache.royale.compiler.clients.ASDOCJSC.compile(ASDOCJSC.java:275)org.apache.royale.compiler.clients.MXMLJSCRoyale._mainNoExit(MXMLJSCRoyale.java:264)org.apache.royale.compiler.clients.MXMLJSCRoyale.mainNoExit(MXMLJSCRoyale.java:221)org.apache.royale.compiler.clients.ASDOCJSC.staticMainNoExit(ASDOCJSC.java:159)org.apache.royale.compiler.clients.ASDOCJSC.main(ASDOCJSC.java:107)
> > >
> > > With -Duse-flash=true, I was able to get ASDoc built, but it fails on
> > > building MenuExample later. This is the error:
> > >
> > >
> >
> apache-royale-0.9.9-src/royale-asjs/examples/royale/MenuExample/src/main/royale/MenuExample.mxml(34):
> > > col: 3 Error: This tag could not be resolved to an ActionScript class.
> It
> > > will be ignored.
> > >
> > > <royale:MyInitialView />
> > >
> > > The issue seems to be caused by this commit:
> > >
> > >
> > >
> >
> https://github.com/apache/royale-asjs/commit/8bfe4a96a37a3a45441793694a9893bbd5f50d4f
> > >
> > > The source path should not have been changed from src/main/royale to
> src.
> > > The correct source path is src/main/royale for all examples and
> libraries
> > > in Royale.
> > >
> > > I will see if I can get these issues fixed for the next RC. As things
> > > are right now, I would vote -1.
> > >
> > > --
> > > Josh Tynjala
> > > Bowler Hat LLC <https://bowlerhat.dev>
> > >
> > >
> > > On Sun, Mar 13, 2022 at 11:35 PM <ap...@gmail.com> wrote:
> > >
> > >> This is the discussion thread.
> > >>
> > >> Thanks,
> > >> Yishay Weiss
> > >
> > >
> >
> >
>
>
--
Piotr Zarzycki
RE: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
Posted by Yishay Weiss <yi...@hotmail.com>.
>Josh’s pick
I meant Josh’s fix of course (being picky here).
From: Yishay Weiss<ma...@hotmail.com>
Sent: Thursday, March 17, 2022 9:12 AM
To: Josh Tynjala<ma...@bowlerhat.dev>; dev@royale.apache.org<ma...@royale.apache.org>
Subject: RE: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
The examples are run as part of the step 11, but mvn only. The ant examples are only built after release approval. For some reason MenuExample was working in mvn but not in ant. That’s why the release steps did not fail prior to approval script. For anybody curious to find out why these differences between mvn and ant exist, this is the maven output [2] taken from the CI logs [1]. You can compare it to Josh’s ant output upthread.
Unrelated, I scheduled a daily job for ASDocs example so we can track ASDocs errors, as they seem to be pretty common.
I will see if I can figure out if I can continue the release from the existing release branch after cherry-picking Josh’s pick.
Thanks.
[1] Royale_Release_Step_011 #26 Console [Jenkins] (azure.com)<http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/view/Royale_Release_Steps/job/Royale_Release_Step_011/26/consoleFull>
[2] [INFO] [INFO] ---------------< org.apache.royale.examples:MenuExample >---------------
[INFO] [INFO] Building Apache Royale: Examples: Royale: MenuExample 0.9.9 [195/265]
[INFO] [INFO] --------------------------------[ swf ]---------------------------------
[INFO] [INFO]
[INFO] [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @ MenuExample ---
[INFO] [INFO]
[INFO] [INFO] --- maven-resources-plugin:3.1.0:copy-resources (copy-resources-debug) @ MenuExample ---
[INFO] [INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] [INFO] skip non existing resourceDirectory C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\src\main\resources
[INFO] [INFO]
[INFO] [INFO] --- maven-resources-plugin:3.1.0:copy-resources (copy-resources-release) @ MenuExample ---
[INFO] [INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] [INFO] skip non existing resourceDirectory C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\src\main\resources\assets
[INFO] [INFO]
[INFO] [INFO] --- maven-remote-resources-plugin:1.7.0:process (process-resource-bundles) @ MenuExample ---
[INFO] [INFO] Preparing remote bundle org.apache:apache-jar-resource-bundle:1.4
[INFO] [INFO] Copying 3 resources from 1 bundle.
[INFO] [INFO]
[INFO] [INFO] --- maven-resources-plugin:3.1.0:resources (default-resources) @ MenuExample ---
[INFO] [INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] [INFO] skip non existing resourceDirectory C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\src\main\resources
[INFO] [INFO] Copying 3 resources
[INFO] [INFO]
[INFO] [INFO] --- royale-maven-plugin:0.9.9:compile-app (default-compile-app) @ MenuExample ---
[INFO] [INFO] Executing MXMLC in tool group Royale with args: [-load-config=C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\target\compile-app-config.xml, -metadata.date=2022-03-13T09:39:40Z, -metadata.dateFormat=yyyy-MM-dd'T'HH:mm:ss'Z', -js-output=C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\target\javascript, -compiler.targets=SWF,JSRoyale, C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\src\main\royale\MenuExample.mxml]
[INFO] Loading configuration: C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\target\compile-app-config.xml
[INFO]
[INFO] 57676 bytes written to C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\target\MenuExample-0.9.9.swf in 0.602 seconds
[INFO] Mar 13, 2022 12:00:56 PM com.google.javascript.jscomp.LoggerErrorManager printSummary
[INFO] INFO: 0 error(s), 0 warning(s), 97.8% typed
[INFO] The project 'MenuExample' has been successfully compiled and optimized.
From: Yishay Weiss<ma...@hotmail.com>
Sent: Wednesday, March 16, 2022 7:14 AM
To: Josh Tynjala<ma...@bowlerhat.dev>; dev@royale.apache.org<ma...@royale.apache.org>
Subject: Re: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
Thanks, I will see if I can figure out why this didn't fail at an earlier stage. I will look into why asdoc example isn't run regularly on CI.
My CLT-L09. On O2.
-------- Original message --------
From: Josh Tynjala <jo...@bowlerhat.dev>
Date: Tue, 15 Mar 2022, 23:07
To: dev@royale.apache.org
Subject: Re: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
I ran into two separate issues with the approval script.
The first issue was the ASDoc example build failing in the JS-only SDK,
which I discovered was happening because I didn't realize that I had an
AIR_HOME environment variable set externally. I cleared AIR_HOME, and
that's fixed it for me. No RC needed for this.
The second issue was the MenuExample example build failing. My commit today
fixes that. A new RC is needed to resolve this one with my commit.
--
Josh Tynjala
Bowler Hat LLC <https://bowlerhat.dev>
On Tue, Mar 15, 2022 at 1:52 PM Yishay Weiss <yi...@hotmail.com> wrote:
> I’m not following. Was the problem AIR_HOME or what your latest commit
> fixed? Do we need another RC?
>
> From: Josh Tynjala<ma...@bowlerhat.dev>
> Sent: Tuesday, March 15, 2022 10:01 PM
> To: dev@royale.apache.org<ma...@royale.apache.org>
> Subject: Re: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
>
> I discovered that I had an AIR_HOME environment variable set elsewhere, and
> that was causing the ASDoc build failure. In the approval script, I can now
> reach MenuExample with both use-flash and without.
>
> I pushed a commit to develop that fixes the MenuExample build issue.
>
> --
> Josh Tynjala
> Bowler Hat LLC <https://bowlerhat.dev>
>
>
> On Tue, Mar 15, 2022 at 10:37 AM Josh Tynjala <jo...@bowlerhat.dev>
> wrote:
>
> > When running the approval script *without* -Duse-flash=true (in other
> > words, JS-only), I get the following error when it tries to build the
> ASDoc
> > example. However, it seems to build that example correctly when I use
> > -Duse-flash=true.
> >
> > json:
> > ROYALE_COMPILER_HOME:
> >
> /Users/joshtynjala/Desktop/ApacheRoyale/apache-royale-0.9.9-src/royale-asjs/js
> > 16.6482905 seconds
> > java.lang.NullPointerException: Cannot invoke
> > "org.apache.royale.compiler.tree.as.IASNode.getSourcePath()" because
> "node"
> > is null
> > org.apache.royale.compiler.internal.codegen.as
> .ASBlockWalker.walk(ASBlockWalker.java:163)org.apache.royale.compiler.
> internal.codegen.as
> .ASBlockWalker.visitCompilationUnit(ASBlockWalker.java:188)org.apache.royale.compiler.internal.codegen.js.JSWriter.writeTo(JSWriter.java:96)org.apache.royale.compiler.internal.codegen.js.JSWriter.writeTo(JSWriter.java:80)org.apache.royale.compiler.clients.ASDOCJSC.compile(ASDOCJSC.java:275)org.apache.royale.compiler.clients.MXMLJSCRoyale._mainNoExit(MXMLJSCRoyale.java:264)org.apache.royale.compiler.clients.MXMLJSCRoyale.mainNoExit(MXMLJSCRoyale.java:221)org.apache.royale.compiler.clients.ASDOCJSC.staticMainNoExit(ASDOCJSC.java:159)org.apache.royale.compiler.clients.ASDOCJSC.main(ASDOCJSC.java:107)
> >
> > With -Duse-flash=true, I was able to get ASDoc built, but it fails on
> > building MenuExample later. This is the error:
> >
> >
> apache-royale-0.9.9-src/royale-asjs/examples/royale/MenuExample/src/main/royale/MenuExample.mxml(34):
> > col: 3 Error: This tag could not be resolved to an ActionScript class. It
> > will be ignored.
> >
> > <royale:MyInitialView />
> >
> > The issue seems to be caused by this commit:
> >
> >
> >
> https://github.com/apache/royale-asjs/commit/8bfe4a96a37a3a45441793694a9893bbd5f50d4f
> >
> > The source path should not have been changed from src/main/royale to src.
> > The correct source path is src/main/royale for all examples and libraries
> > in Royale.
> >
> > I will see if I can get these issues fixed for the next RC. As things
> > are right now, I would vote -1.
> >
> > --
> > Josh Tynjala
> > Bowler Hat LLC <https://bowlerhat.dev>
> >
> >
> > On Sun, Mar 13, 2022 at 11:35 PM <ap...@gmail.com> wrote:
> >
> >> This is the discussion thread.
> >>
> >> Thanks,
> >> Yishay Weiss
> >
> >
>
>
RE: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
Posted by Yishay Weiss <yi...@hotmail.com>.
I agree in retrospect that an example that compiles in Maven, but not in Ant, and is not critical for users, should not hold a release. It was good to spot the regression, but ideally that should be spotted on CI.
From: Alex Harui<ma...@adobe.com.INVALID>
Sent: Thursday, March 17, 2022 6:18 PM
To: dev@royale.apache.org<ma...@royale.apache.org>; Josh Tynjala<ma...@bowlerhat.dev>
Subject: Re: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
IMO, the release does not have to be bug free. If the Maven and Ant build scripts can build the source package, there are no unintended compiled code in the source package, LICENSE and NOTICE are correct, and a few other Apache policy requirements are met, and folks can use the results of the built source package to be successful in their work, I would still vote for release.
-Alex
On 3/17/22, 6:30 AM, "Yishay Weiss" <yi...@hotmail.com> wrote:
> The ant examples are only built after release approval.
Actually, I think I misread the scripts. I don’t think examples are built with ant anywhere in the release process except upon approval. If somebody wants to inform otherwise please do.
From: Yishay Weiss<ma...@hotmail.com>
Sent: Thursday, March 17, 2022 9:12 AM
To: Josh Tynjala<ma...@bowlerhat.dev>; dev@royale.apache.org<ma...@royale.apache.org>
Subject: RE: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
The examples are run as part of the step 11, but mvn only. The ant examples are only built after release approval. For some reason MenuExample was working in mvn but not in ant. That’s why the release steps did not fail prior to approval script. For anybody curious to find out why these differences between mvn and ant exist, this is the maven output [2] taken from the CI logs [1]. You can compare it to Josh’s ant output upthread.
Unrelated, I scheduled a daily job for ASDocs example so we can track ASDocs errors, as they seem to be pretty common.
I will see if I can figure out if I can continue the release from the existing release branch after cherry-picking Josh’s pick.
Thanks.
[1] Royale_Release_Step_011 #26 Console [Jenkins] (azure.com)<https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapacheroyaleci2.westus2.cloudapp.azure.com%3A8080%2Fview%2FRoyale_Release_Steps%2Fjob%2FRoyale_Release_Step_011%2F26%2FconsoleFull&data=04%7C01%7Caharui%40adobe.com%7C220edd2db12743243cdc08da081a10b5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637831206187637757%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=f5JkRgVY45JlJHgTGT%2B%2FTKbnJ5v%2BRyKh1SK%2FtvnNcqc%3D&reserved=0>
[2] [INFO] [INFO] ---------------< org.apache.royale.examples:MenuExample >---------------
[INFO] [INFO] Building Apache Royale: Examples: Royale: MenuExample 0.9.9 [195/265]
[INFO] [INFO] --------------------------------[ swf ]---------------------------------
[INFO] [INFO]
[INFO] [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @ MenuExample ---
[INFO] [INFO]
[INFO] [INFO] --- maven-resources-plugin:3.1.0:copy-resources (copy-resources-debug) @ MenuExample ---
[INFO] [INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] [INFO] skip non existing resourceDirectory C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\src\main\resources
[INFO] [INFO]
[INFO] [INFO] --- maven-resources-plugin:3.1.0:copy-resources (copy-resources-release) @ MenuExample ---
[INFO] [INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] [INFO] skip non existing resourceDirectory C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\src\main\resources\assets
[INFO] [INFO]
[INFO] [INFO] --- maven-remote-resources-plugin:1.7.0:process (process-resource-bundles) @ MenuExample ---
[INFO] [INFO] Preparing remote bundle org.apache:apache-jar-resource-bundle:1.4
[INFO] [INFO] Copying 3 resources from 1 bundle.
[INFO] [INFO]
[INFO] [INFO] --- maven-resources-plugin:3.1.0:resources (default-resources) @ MenuExample ---
[INFO] [INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] [INFO] skip non existing resourceDirectory C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\src\main\resources
[INFO] [INFO] Copying 3 resources
[INFO] [INFO]
[INFO] [INFO] --- royale-maven-plugin:0.9.9:compile-app (default-compile-app) @ MenuExample ---
[INFO] [INFO] Executing MXMLC in tool group Royale with args: [-load-config=C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\target\compile-app-config.xml, -metadata.date=2022-03-13T09:39:40Z, -metadata.dateFormat=yyyy-MM-dd'T'HH:mm:ss'Z', -js-output=C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\target\javascript, -compiler.targets=SWF,JSRoyale, C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\src\main\royale\MenuExample.mxml]
[INFO] Loading configuration: C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\target\compile-app-config.xml
[INFO]
[INFO] 57676 bytes written to C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\target\MenuExample-0.9.9.swf in 0.602 seconds
[INFO] Mar 13, 2022 12:00:56 PM com.google.javascript.jscomp.LoggerErrorManager printSummary
[INFO] INFO: 0 error(s), 0 warning(s), 97.8% typed
[INFO] The project 'MenuExample' has been successfully compiled and optimized.
From: Yishay Weiss<ma...@hotmail.com>
Sent: Wednesday, March 16, 2022 7:14 AM
To: Josh Tynjala<ma...@bowlerhat.dev>; dev@royale.apache.org<ma...@royale.apache.org>
Subject: Re: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
Thanks, I will see if I can figure out why this didn't fail at an earlier stage. I will look into why asdoc example isn't run regularly on CI.
My CLT-L09. On O2.
-------- Original message --------
From: Josh Tynjala <jo...@bowlerhat.dev>
Date: Tue, 15 Mar 2022, 23:07
To: dev@royale.apache.org
Subject: Re: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
I ran into two separate issues with the approval script.
The first issue was the ASDoc example build failing in the JS-only SDK,
which I discovered was happening because I didn't realize that I had an
AIR_HOME environment variable set externally. I cleared AIR_HOME, and
that's fixed it for me. No RC needed for this.
The second issue was the MenuExample example build failing. My commit today
fixes that. A new RC is needed to resolve this one with my commit.
--
Josh Tynjala
Bowler Hat LLC <https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbowlerhat.dev%2F&data=04%7C01%7Caharui%40adobe.com%7C220edd2db12743243cdc08da081a10b5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637831206187637757%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=RaNqkkAeVilqvae6EMZ5ZJwlbDenQ4Pe1mRMZyuOxUM%3D&reserved=0>
On Tue, Mar 15, 2022 at 1:52 PM Yishay Weiss <yi...@hotmail.com> wrote:
> I’m not following. Was the problem AIR_HOME or what your latest commit
> fixed? Do we need another RC?
>
> From: Josh Tynjala<ma...@bowlerhat.dev>
> Sent: Tuesday, March 15, 2022 10:01 PM
> To: dev@royale.apache.org<ma...@royale.apache.org>
> Subject: Re: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
>
> I discovered that I had an AIR_HOME environment variable set elsewhere, and
> that was causing the ASDoc build failure. In the approval script, I can now
> reach MenuExample with both use-flash and without.
>
> I pushed a commit to develop that fixes the MenuExample build issue.
>
> --
> Josh Tynjala
> Bowler Hat LLC <https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbowlerhat.dev%2F&data=04%7C01%7Caharui%40adobe.com%7C220edd2db12743243cdc08da081a10b5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637831206187637757%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=RaNqkkAeVilqvae6EMZ5ZJwlbDenQ4Pe1mRMZyuOxUM%3D&reserved=0>
>
>
> On Tue, Mar 15, 2022 at 10:37 AM Josh Tynjala <jo...@bowlerhat.dev>
> wrote:
>
> > When running the approval script *without* -Duse-flash=true (in other
> > words, JS-only), I get the following error when it tries to build the
> ASDoc
> > example. However, it seems to build that example correctly when I use
> > -Duse-flash=true.
> >
> > json:
> > ROYALE_COMPILER_HOME:
> >
> /Users/joshtynjala/Desktop/ApacheRoyale/apache-royale-0.9.9-src/royale-asjs/js
> > 16.6482905 seconds
> > java.lang.NullPointerException: Cannot invoke
> > "org.apache.royale.compiler.tree.as.IASNode.getSourcePath()" because
> "node"
> > is null
> > org.apache.royale.compiler.internal.codegen.as
> .ASBlockWalker.walk(ASBlockWalker.java:163)org.apache.royale.compiler.
> internal.codegen.as
> .ASBlockWalker.visitCompilationUnit(ASBlockWalker.java:188)org.apache.royale.compiler.internal.codegen.js.JSWriter.writeTo(JSWriter.java:96)org.apache.royale.compiler.internal.codegen.js.JSWriter.writeTo(JSWriter.java:80)org.apache.royale.compiler.clients.ASDOCJSC.compile(ASDOCJSC.java:275)org.apache.royale.compiler.clients.MXMLJSCRoyale._mainNoExit(MXMLJSCRoyale.java:264)org.apache.royale.compiler.clients.MXMLJSCRoyale.mainNoExit(MXMLJSCRoyale.java:221)org.apache.royale.compiler.clients.ASDOCJSC.staticMainNoExit(ASDOCJSC.java:159)org.apache.royale.compiler.clients.ASDOCJSC.main(ASDOCJSC.java:107)
> >
> > With -Duse-flash=true, I was able to get ASDoc built, but it fails on
> > building MenuExample later. This is the error:
> >
> >
> apache-royale-0.9.9-src/royale-asjs/examples/royale/MenuExample/src/main/royale/MenuExample.mxml(34):
> > col: 3 Error: This tag could not be resolved to an ActionScript class. It
> > will be ignored.
> >
> > <royale:MyInitialView />
> >
> > The issue seems to be caused by this commit:
> >
> >
> >
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fcommit%2F8bfe4a96a37a3a45441793694a9893bbd5f50d4f&data=04%7C01%7Caharui%40adobe.com%7C220edd2db12743243cdc08da081a10b5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637831206187637757%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=P5703yledopUKNI7xkaZ8g1EZGGS%2FlDWEXA5sMfS%2F30%3D&reserved=0
> >
> > The source path should not have been changed from src/main/royale to src.
> > The correct source path is src/main/royale for all examples and libraries
> > in Royale.
> >
> > I will see if I can get these issues fixed for the next RC. As things
> > are right now, I would vote -1.
> >
> > --
> > Josh Tynjala
> > Bowler Hat LLC <https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbowlerhat.dev%2F&data=04%7C01%7Caharui%40adobe.com%7C220edd2db12743243cdc08da081a10b5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637831206187637757%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=RaNqkkAeVilqvae6EMZ5ZJwlbDenQ4Pe1mRMZyuOxUM%3D&reserved=0>
> >
> >
> > On Sun, Mar 13, 2022 at 11:35 PM <ap...@gmail.com> wrote:
> >
> >> This is the discussion thread.
> >>
> >> Thanks,
> >> Yishay Weiss
> >
> >
>
>
Re: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
Posted by Alex Harui <ah...@adobe.com.INVALID>.
IMO, the release does not have to be bug free. If the Maven and Ant build scripts can build the source package, there are no unintended compiled code in the source package, LICENSE and NOTICE are correct, and a few other Apache policy requirements are met, and folks can use the results of the built source package to be successful in their work, I would still vote for release.
-Alex
On 3/17/22, 6:30 AM, "Yishay Weiss" <yi...@hotmail.com> wrote:
> The ant examples are only built after release approval.
Actually, I think I misread the scripts. I don’t think examples are built with ant anywhere in the release process except upon approval. If somebody wants to inform otherwise please do.
From: Yishay Weiss<ma...@hotmail.com>
Sent: Thursday, March 17, 2022 9:12 AM
To: Josh Tynjala<ma...@bowlerhat.dev>; dev@royale.apache.org<ma...@royale.apache.org>
Subject: RE: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
The examples are run as part of the step 11, but mvn only. The ant examples are only built after release approval. For some reason MenuExample was working in mvn but not in ant. That’s why the release steps did not fail prior to approval script. For anybody curious to find out why these differences between mvn and ant exist, this is the maven output [2] taken from the CI logs [1]. You can compare it to Josh’s ant output upthread.
Unrelated, I scheduled a daily job for ASDocs example so we can track ASDocs errors, as they seem to be pretty common.
I will see if I can figure out if I can continue the release from the existing release branch after cherry-picking Josh’s pick.
Thanks.
[1] Royale_Release_Step_011 #26 Console [Jenkins] (azure.com)<https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapacheroyaleci2.westus2.cloudapp.azure.com%3A8080%2Fview%2FRoyale_Release_Steps%2Fjob%2FRoyale_Release_Step_011%2F26%2FconsoleFull&data=04%7C01%7Caharui%40adobe.com%7C220edd2db12743243cdc08da081a10b5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637831206187637757%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=f5JkRgVY45JlJHgTGT%2B%2FTKbnJ5v%2BRyKh1SK%2FtvnNcqc%3D&reserved=0>
[2] [INFO] [INFO] ---------------< org.apache.royale.examples:MenuExample >---------------
[INFO] [INFO] Building Apache Royale: Examples: Royale: MenuExample 0.9.9 [195/265]
[INFO] [INFO] --------------------------------[ swf ]---------------------------------
[INFO] [INFO]
[INFO] [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @ MenuExample ---
[INFO] [INFO]
[INFO] [INFO] --- maven-resources-plugin:3.1.0:copy-resources (copy-resources-debug) @ MenuExample ---
[INFO] [INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] [INFO] skip non existing resourceDirectory C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\src\main\resources
[INFO] [INFO]
[INFO] [INFO] --- maven-resources-plugin:3.1.0:copy-resources (copy-resources-release) @ MenuExample ---
[INFO] [INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] [INFO] skip non existing resourceDirectory C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\src\main\resources\assets
[INFO] [INFO]
[INFO] [INFO] --- maven-remote-resources-plugin:1.7.0:process (process-resource-bundles) @ MenuExample ---
[INFO] [INFO] Preparing remote bundle org.apache:apache-jar-resource-bundle:1.4
[INFO] [INFO] Copying 3 resources from 1 bundle.
[INFO] [INFO]
[INFO] [INFO] --- maven-resources-plugin:3.1.0:resources (default-resources) @ MenuExample ---
[INFO] [INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] [INFO] skip non existing resourceDirectory C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\src\main\resources
[INFO] [INFO] Copying 3 resources
[INFO] [INFO]
[INFO] [INFO] --- royale-maven-plugin:0.9.9:compile-app (default-compile-app) @ MenuExample ---
[INFO] [INFO] Executing MXMLC in tool group Royale with args: [-load-config=C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\target\compile-app-config.xml, -metadata.date=2022-03-13T09:39:40Z, -metadata.dateFormat=yyyy-MM-dd'T'HH:mm:ss'Z', -js-output=C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\target\javascript, -compiler.targets=SWF,JSRoyale, C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\src\main\royale\MenuExample.mxml]
[INFO] Loading configuration: C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\target\compile-app-config.xml
[INFO]
[INFO] 57676 bytes written to C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\target\MenuExample-0.9.9.swf in 0.602 seconds
[INFO] Mar 13, 2022 12:00:56 PM com.google.javascript.jscomp.LoggerErrorManager printSummary
[INFO] INFO: 0 error(s), 0 warning(s), 97.8% typed
[INFO] The project 'MenuExample' has been successfully compiled and optimized.
From: Yishay Weiss<ma...@hotmail.com>
Sent: Wednesday, March 16, 2022 7:14 AM
To: Josh Tynjala<ma...@bowlerhat.dev>; dev@royale.apache.org<ma...@royale.apache.org>
Subject: Re: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
Thanks, I will see if I can figure out why this didn't fail at an earlier stage. I will look into why asdoc example isn't run regularly on CI.
My CLT-L09. On O2.
-------- Original message --------
From: Josh Tynjala <jo...@bowlerhat.dev>
Date: Tue, 15 Mar 2022, 23:07
To: dev@royale.apache.org
Subject: Re: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
I ran into two separate issues with the approval script.
The first issue was the ASDoc example build failing in the JS-only SDK,
which I discovered was happening because I didn't realize that I had an
AIR_HOME environment variable set externally. I cleared AIR_HOME, and
that's fixed it for me. No RC needed for this.
The second issue was the MenuExample example build failing. My commit today
fixes that. A new RC is needed to resolve this one with my commit.
--
Josh Tynjala
Bowler Hat LLC <https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbowlerhat.dev%2F&data=04%7C01%7Caharui%40adobe.com%7C220edd2db12743243cdc08da081a10b5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637831206187637757%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=RaNqkkAeVilqvae6EMZ5ZJwlbDenQ4Pe1mRMZyuOxUM%3D&reserved=0>
On Tue, Mar 15, 2022 at 1:52 PM Yishay Weiss <yi...@hotmail.com> wrote:
> I’m not following. Was the problem AIR_HOME or what your latest commit
> fixed? Do we need another RC?
>
> From: Josh Tynjala<ma...@bowlerhat.dev>
> Sent: Tuesday, March 15, 2022 10:01 PM
> To: dev@royale.apache.org<ma...@royale.apache.org>
> Subject: Re: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
>
> I discovered that I had an AIR_HOME environment variable set elsewhere, and
> that was causing the ASDoc build failure. In the approval script, I can now
> reach MenuExample with both use-flash and without.
>
> I pushed a commit to develop that fixes the MenuExample build issue.
>
> --
> Josh Tynjala
> Bowler Hat LLC <https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbowlerhat.dev%2F&data=04%7C01%7Caharui%40adobe.com%7C220edd2db12743243cdc08da081a10b5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637831206187637757%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=RaNqkkAeVilqvae6EMZ5ZJwlbDenQ4Pe1mRMZyuOxUM%3D&reserved=0>
>
>
> On Tue, Mar 15, 2022 at 10:37 AM Josh Tynjala <jo...@bowlerhat.dev>
> wrote:
>
> > When running the approval script *without* -Duse-flash=true (in other
> > words, JS-only), I get the following error when it tries to build the
> ASDoc
> > example. However, it seems to build that example correctly when I use
> > -Duse-flash=true.
> >
> > json:
> > ROYALE_COMPILER_HOME:
> >
> /Users/joshtynjala/Desktop/ApacheRoyale/apache-royale-0.9.9-src/royale-asjs/js
> > 16.6482905 seconds
> > java.lang.NullPointerException: Cannot invoke
> > "org.apache.royale.compiler.tree.as.IASNode.getSourcePath()" because
> "node"
> > is null
> > org.apache.royale.compiler.internal.codegen.as
> .ASBlockWalker.walk(ASBlockWalker.java:163)org.apache.royale.compiler.
> internal.codegen.as
> .ASBlockWalker.visitCompilationUnit(ASBlockWalker.java:188)org.apache.royale.compiler.internal.codegen.js.JSWriter.writeTo(JSWriter.java:96)org.apache.royale.compiler.internal.codegen.js.JSWriter.writeTo(JSWriter.java:80)org.apache.royale.compiler.clients.ASDOCJSC.compile(ASDOCJSC.java:275)org.apache.royale.compiler.clients.MXMLJSCRoyale._mainNoExit(MXMLJSCRoyale.java:264)org.apache.royale.compiler.clients.MXMLJSCRoyale.mainNoExit(MXMLJSCRoyale.java:221)org.apache.royale.compiler.clients.ASDOCJSC.staticMainNoExit(ASDOCJSC.java:159)org.apache.royale.compiler.clients.ASDOCJSC.main(ASDOCJSC.java:107)
> >
> > With -Duse-flash=true, I was able to get ASDoc built, but it fails on
> > building MenuExample later. This is the error:
> >
> >
> apache-royale-0.9.9-src/royale-asjs/examples/royale/MenuExample/src/main/royale/MenuExample.mxml(34):
> > col: 3 Error: This tag could not be resolved to an ActionScript class. It
> > will be ignored.
> >
> > <royale:MyInitialView />
> >
> > The issue seems to be caused by this commit:
> >
> >
> >
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fcommit%2F8bfe4a96a37a3a45441793694a9893bbd5f50d4f&data=04%7C01%7Caharui%40adobe.com%7C220edd2db12743243cdc08da081a10b5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637831206187637757%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=P5703yledopUKNI7xkaZ8g1EZGGS%2FlDWEXA5sMfS%2F30%3D&reserved=0
> >
> > The source path should not have been changed from src/main/royale to src.
> > The correct source path is src/main/royale for all examples and libraries
> > in Royale.
> >
> > I will see if I can get these issues fixed for the next RC. As things
> > are right now, I would vote -1.
> >
> > --
> > Josh Tynjala
> > Bowler Hat LLC <https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbowlerhat.dev%2F&data=04%7C01%7Caharui%40adobe.com%7C220edd2db12743243cdc08da081a10b5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637831206187637757%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=RaNqkkAeVilqvae6EMZ5ZJwlbDenQ4Pe1mRMZyuOxUM%3D&reserved=0>
> >
> >
> > On Sun, Mar 13, 2022 at 11:35 PM <ap...@gmail.com> wrote:
> >
> >> This is the discussion thread.
> >>
> >> Thanks,
> >> Yishay Weiss
> >
> >
>
>
RE: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
Posted by Yishay Weiss <yi...@hotmail.com>.
> The ant examples are only built after release approval.
Actually, I think I misread the scripts. I don’t think examples are built with ant anywhere in the release process except upon approval. If somebody wants to inform otherwise please do.
From: Yishay Weiss<ma...@hotmail.com>
Sent: Thursday, March 17, 2022 9:12 AM
To: Josh Tynjala<ma...@bowlerhat.dev>; dev@royale.apache.org<ma...@royale.apache.org>
Subject: RE: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
The examples are run as part of the step 11, but mvn only. The ant examples are only built after release approval. For some reason MenuExample was working in mvn but not in ant. That’s why the release steps did not fail prior to approval script. For anybody curious to find out why these differences between mvn and ant exist, this is the maven output [2] taken from the CI logs [1]. You can compare it to Josh’s ant output upthread.
Unrelated, I scheduled a daily job for ASDocs example so we can track ASDocs errors, as they seem to be pretty common.
I will see if I can figure out if I can continue the release from the existing release branch after cherry-picking Josh’s pick.
Thanks.
[1] Royale_Release_Step_011 #26 Console [Jenkins] (azure.com)<http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/view/Royale_Release_Steps/job/Royale_Release_Step_011/26/consoleFull>
[2] [INFO] [INFO] ---------------< org.apache.royale.examples:MenuExample >---------------
[INFO] [INFO] Building Apache Royale: Examples: Royale: MenuExample 0.9.9 [195/265]
[INFO] [INFO] --------------------------------[ swf ]---------------------------------
[INFO] [INFO]
[INFO] [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @ MenuExample ---
[INFO] [INFO]
[INFO] [INFO] --- maven-resources-plugin:3.1.0:copy-resources (copy-resources-debug) @ MenuExample ---
[INFO] [INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] [INFO] skip non existing resourceDirectory C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\src\main\resources
[INFO] [INFO]
[INFO] [INFO] --- maven-resources-plugin:3.1.0:copy-resources (copy-resources-release) @ MenuExample ---
[INFO] [INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] [INFO] skip non existing resourceDirectory C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\src\main\resources\assets
[INFO] [INFO]
[INFO] [INFO] --- maven-remote-resources-plugin:1.7.0:process (process-resource-bundles) @ MenuExample ---
[INFO] [INFO] Preparing remote bundle org.apache:apache-jar-resource-bundle:1.4
[INFO] [INFO] Copying 3 resources from 1 bundle.
[INFO] [INFO]
[INFO] [INFO] --- maven-resources-plugin:3.1.0:resources (default-resources) @ MenuExample ---
[INFO] [INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] [INFO] skip non existing resourceDirectory C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\src\main\resources
[INFO] [INFO] Copying 3 resources
[INFO] [INFO]
[INFO] [INFO] --- royale-maven-plugin:0.9.9:compile-app (default-compile-app) @ MenuExample ---
[INFO] [INFO] Executing MXMLC in tool group Royale with args: [-load-config=C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\target\compile-app-config.xml, -metadata.date=2022-03-13T09:39:40Z, -metadata.dateFormat=yyyy-MM-dd'T'HH:mm:ss'Z', -js-output=C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\target\javascript, -compiler.targets=SWF,JSRoyale, C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\src\main\royale\MenuExample.mxml]
[INFO] Loading configuration: C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\target\compile-app-config.xml
[INFO]
[INFO] 57676 bytes written to C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\target\MenuExample-0.9.9.swf in 0.602 seconds
[INFO] Mar 13, 2022 12:00:56 PM com.google.javascript.jscomp.LoggerErrorManager printSummary
[INFO] INFO: 0 error(s), 0 warning(s), 97.8% typed
[INFO] The project 'MenuExample' has been successfully compiled and optimized.
From: Yishay Weiss<ma...@hotmail.com>
Sent: Wednesday, March 16, 2022 7:14 AM
To: Josh Tynjala<ma...@bowlerhat.dev>; dev@royale.apache.org<ma...@royale.apache.org>
Subject: Re: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
Thanks, I will see if I can figure out why this didn't fail at an earlier stage. I will look into why asdoc example isn't run regularly on CI.
My CLT-L09. On O2.
-------- Original message --------
From: Josh Tynjala <jo...@bowlerhat.dev>
Date: Tue, 15 Mar 2022, 23:07
To: dev@royale.apache.org
Subject: Re: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
I ran into two separate issues with the approval script.
The first issue was the ASDoc example build failing in the JS-only SDK,
which I discovered was happening because I didn't realize that I had an
AIR_HOME environment variable set externally. I cleared AIR_HOME, and
that's fixed it for me. No RC needed for this.
The second issue was the MenuExample example build failing. My commit today
fixes that. A new RC is needed to resolve this one with my commit.
--
Josh Tynjala
Bowler Hat LLC <https://bowlerhat.dev>
On Tue, Mar 15, 2022 at 1:52 PM Yishay Weiss <yi...@hotmail.com> wrote:
> I’m not following. Was the problem AIR_HOME or what your latest commit
> fixed? Do we need another RC?
>
> From: Josh Tynjala<ma...@bowlerhat.dev>
> Sent: Tuesday, March 15, 2022 10:01 PM
> To: dev@royale.apache.org<ma...@royale.apache.org>
> Subject: Re: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
>
> I discovered that I had an AIR_HOME environment variable set elsewhere, and
> that was causing the ASDoc build failure. In the approval script, I can now
> reach MenuExample with both use-flash and without.
>
> I pushed a commit to develop that fixes the MenuExample build issue.
>
> --
> Josh Tynjala
> Bowler Hat LLC <https://bowlerhat.dev>
>
>
> On Tue, Mar 15, 2022 at 10:37 AM Josh Tynjala <jo...@bowlerhat.dev>
> wrote:
>
> > When running the approval script *without* -Duse-flash=true (in other
> > words, JS-only), I get the following error when it tries to build the
> ASDoc
> > example. However, it seems to build that example correctly when I use
> > -Duse-flash=true.
> >
> > json:
> > ROYALE_COMPILER_HOME:
> >
> /Users/joshtynjala/Desktop/ApacheRoyale/apache-royale-0.9.9-src/royale-asjs/js
> > 16.6482905 seconds
> > java.lang.NullPointerException: Cannot invoke
> > "org.apache.royale.compiler.tree.as.IASNode.getSourcePath()" because
> "node"
> > is null
> > org.apache.royale.compiler.internal.codegen.as
> .ASBlockWalker.walk(ASBlockWalker.java:163)org.apache.royale.compiler.
> internal.codegen.as
> .ASBlockWalker.visitCompilationUnit(ASBlockWalker.java:188)org.apache.royale.compiler.internal.codegen.js.JSWriter.writeTo(JSWriter.java:96)org.apache.royale.compiler.internal.codegen.js.JSWriter.writeTo(JSWriter.java:80)org.apache.royale.compiler.clients.ASDOCJSC.compile(ASDOCJSC.java:275)org.apache.royale.compiler.clients.MXMLJSCRoyale._mainNoExit(MXMLJSCRoyale.java:264)org.apache.royale.compiler.clients.MXMLJSCRoyale.mainNoExit(MXMLJSCRoyale.java:221)org.apache.royale.compiler.clients.ASDOCJSC.staticMainNoExit(ASDOCJSC.java:159)org.apache.royale.compiler.clients.ASDOCJSC.main(ASDOCJSC.java:107)
> >
> > With -Duse-flash=true, I was able to get ASDoc built, but it fails on
> > building MenuExample later. This is the error:
> >
> >
> apache-royale-0.9.9-src/royale-asjs/examples/royale/MenuExample/src/main/royale/MenuExample.mxml(34):
> > col: 3 Error: This tag could not be resolved to an ActionScript class. It
> > will be ignored.
> >
> > <royale:MyInitialView />
> >
> > The issue seems to be caused by this commit:
> >
> >
> >
> https://github.com/apache/royale-asjs/commit/8bfe4a96a37a3a45441793694a9893bbd5f50d4f
> >
> > The source path should not have been changed from src/main/royale to src.
> > The correct source path is src/main/royale for all examples and libraries
> > in Royale.
> >
> > I will see if I can get these issues fixed for the next RC. As things
> > are right now, I would vote -1.
> >
> > --
> > Josh Tynjala
> > Bowler Hat LLC <https://bowlerhat.dev>
> >
> >
> > On Sun, Mar 13, 2022 at 11:35 PM <ap...@gmail.com> wrote:
> >
> >> This is the discussion thread.
> >>
> >> Thanks,
> >> Yishay Weiss
> >
> >
>
>
RE: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
Posted by Yishay Weiss <yi...@hotmail.com>.
The examples are run as part of the step 11, but mvn only. The ant examples are only built after release approval. For some reason MenuExample was working in mvn but not in ant. That’s why the release steps did not fail prior to approval script. For anybody curious to find out why these differences between mvn and ant exist, this is the maven output [2] taken from the CI logs [1]. You can compare it to Josh’s ant output upthread.
Unrelated, I scheduled a daily job for ASDocs example so we can track ASDocs errors, as they seem to be pretty common.
I will see if I can figure out if I can continue the release from the existing release branch after cherry-picking Josh’s pick.
Thanks.
[1] Royale_Release_Step_011 #26 Console [Jenkins] (azure.com)<http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/view/Royale_Release_Steps/job/Royale_Release_Step_011/26/consoleFull>
[2] [INFO] [INFO] ---------------< org.apache.royale.examples:MenuExample >---------------
[INFO] [INFO] Building Apache Royale: Examples: Royale: MenuExample 0.9.9 [195/265]
[INFO] [INFO] --------------------------------[ swf ]---------------------------------
[INFO] [INFO]
[INFO] [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @ MenuExample ---
[INFO] [INFO]
[INFO] [INFO] --- maven-resources-plugin:3.1.0:copy-resources (copy-resources-debug) @ MenuExample ---
[INFO] [INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] [INFO] skip non existing resourceDirectory C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\src\main\resources
[INFO] [INFO]
[INFO] [INFO] --- maven-resources-plugin:3.1.0:copy-resources (copy-resources-release) @ MenuExample ---
[INFO] [INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] [INFO] skip non existing resourceDirectory C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\src\main\resources\assets
[INFO] [INFO]
[INFO] [INFO] --- maven-remote-resources-plugin:1.7.0:process (process-resource-bundles) @ MenuExample ---
[INFO] [INFO] Preparing remote bundle org.apache:apache-jar-resource-bundle:1.4
[INFO] [INFO] Copying 3 resources from 1 bundle.
[INFO] [INFO]
[INFO] [INFO] --- maven-resources-plugin:3.1.0:resources (default-resources) @ MenuExample ---
[INFO] [INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] [INFO] skip non existing resourceDirectory C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\src\main\resources
[INFO] [INFO] Copying 3 resources
[INFO] [INFO]
[INFO] [INFO] --- royale-maven-plugin:0.9.9:compile-app (default-compile-app) @ MenuExample ---
[INFO] [INFO] Executing MXMLC in tool group Royale with args: [-load-config=C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\target\compile-app-config.xml, -metadata.date=2022-03-13T09:39:40Z, -metadata.dateFormat=yyyy-MM-dd'T'HH:mm:ss'Z', -js-output=C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\target\javascript, -compiler.targets=SWF,JSRoyale, C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\src\main\royale\MenuExample.mxml]
[INFO] Loading configuration: C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\target\compile-app-config.xml
[INFO]
[INFO] 57676 bytes written to C:\jenkins\workspace\Royale_Release_Step_011\target\checkout\examples\royale\MenuExample\target\MenuExample-0.9.9.swf in 0.602 seconds
[INFO] Mar 13, 2022 12:00:56 PM com.google.javascript.jscomp.LoggerErrorManager printSummary
[INFO] INFO: 0 error(s), 0 warning(s), 97.8% typed
[INFO] The project 'MenuExample' has been successfully compiled and optimized.
From: Yishay Weiss<ma...@hotmail.com>
Sent: Wednesday, March 16, 2022 7:14 AM
To: Josh Tynjala<ma...@bowlerhat.dev>; dev@royale.apache.org<ma...@royale.apache.org>
Subject: Re: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
Thanks, I will see if I can figure out why this didn't fail at an earlier stage. I will look into why asdoc example isn't run regularly on CI.
My CLT-L09. On O2.
-------- Original message --------
From: Josh Tynjala <jo...@bowlerhat.dev>
Date: Tue, 15 Mar 2022, 23:07
To: dev@royale.apache.org
Subject: Re: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
I ran into two separate issues with the approval script.
The first issue was the ASDoc example build failing in the JS-only SDK,
which I discovered was happening because I didn't realize that I had an
AIR_HOME environment variable set externally. I cleared AIR_HOME, and
that's fixed it for me. No RC needed for this.
The second issue was the MenuExample example build failing. My commit today
fixes that. A new RC is needed to resolve this one with my commit.
--
Josh Tynjala
Bowler Hat LLC <https://bowlerhat.dev>
On Tue, Mar 15, 2022 at 1:52 PM Yishay Weiss <yi...@hotmail.com> wrote:
> I’m not following. Was the problem AIR_HOME or what your latest commit
> fixed? Do we need another RC?
>
> From: Josh Tynjala<ma...@bowlerhat.dev>
> Sent: Tuesday, March 15, 2022 10:01 PM
> To: dev@royale.apache.org<ma...@royale.apache.org>
> Subject: Re: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
>
> I discovered that I had an AIR_HOME environment variable set elsewhere, and
> that was causing the ASDoc build failure. In the approval script, I can now
> reach MenuExample with both use-flash and without.
>
> I pushed a commit to develop that fixes the MenuExample build issue.
>
> --
> Josh Tynjala
> Bowler Hat LLC <https://bowlerhat.dev>
>
>
> On Tue, Mar 15, 2022 at 10:37 AM Josh Tynjala <jo...@bowlerhat.dev>
> wrote:
>
> > When running the approval script *without* -Duse-flash=true (in other
> > words, JS-only), I get the following error when it tries to build the
> ASDoc
> > example. However, it seems to build that example correctly when I use
> > -Duse-flash=true.
> >
> > json:
> > ROYALE_COMPILER_HOME:
> >
> /Users/joshtynjala/Desktop/ApacheRoyale/apache-royale-0.9.9-src/royale-asjs/js
> > 16.6482905 seconds
> > java.lang.NullPointerException: Cannot invoke
> > "org.apache.royale.compiler.tree.as.IASNode.getSourcePath()" because
> "node"
> > is null
> > org.apache.royale.compiler.internal.codegen.as
> .ASBlockWalker.walk(ASBlockWalker.java:163)org.apache.royale.compiler.
> internal.codegen.as
> .ASBlockWalker.visitCompilationUnit(ASBlockWalker.java:188)org.apache.royale.compiler.internal.codegen.js.JSWriter.writeTo(JSWriter.java:96)org.apache.royale.compiler.internal.codegen.js.JSWriter.writeTo(JSWriter.java:80)org.apache.royale.compiler.clients.ASDOCJSC.compile(ASDOCJSC.java:275)org.apache.royale.compiler.clients.MXMLJSCRoyale._mainNoExit(MXMLJSCRoyale.java:264)org.apache.royale.compiler.clients.MXMLJSCRoyale.mainNoExit(MXMLJSCRoyale.java:221)org.apache.royale.compiler.clients.ASDOCJSC.staticMainNoExit(ASDOCJSC.java:159)org.apache.royale.compiler.clients.ASDOCJSC.main(ASDOCJSC.java:107)
> >
> > With -Duse-flash=true, I was able to get ASDoc built, but it fails on
> > building MenuExample later. This is the error:
> >
> >
> apache-royale-0.9.9-src/royale-asjs/examples/royale/MenuExample/src/main/royale/MenuExample.mxml(34):
> > col: 3 Error: This tag could not be resolved to an ActionScript class. It
> > will be ignored.
> >
> > <royale:MyInitialView />
> >
> > The issue seems to be caused by this commit:
> >
> >
> >
> https://github.com/apache/royale-asjs/commit/8bfe4a96a37a3a45441793694a9893bbd5f50d4f
> >
> > The source path should not have been changed from src/main/royale to src.
> > The correct source path is src/main/royale for all examples and libraries
> > in Royale.
> >
> > I will see if I can get these issues fixed for the next RC. As things
> > are right now, I would vote -1.
> >
> > --
> > Josh Tynjala
> > Bowler Hat LLC <https://bowlerhat.dev>
> >
> >
> > On Sun, Mar 13, 2022 at 11:35 PM <ap...@gmail.com> wrote:
> >
> >> This is the discussion thread.
> >>
> >> Thanks,
> >> Yishay Weiss
> >
> >
>
>
Re: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
Posted by Josh Tynjala <jo...@bowlerhat.dev>.
I ran into two separate issues with the approval script.
The first issue was the ASDoc example build failing in the JS-only SDK,
which I discovered was happening because I didn't realize that I had an
AIR_HOME environment variable set externally. I cleared AIR_HOME, and
that's fixed it for me. No RC needed for this.
The second issue was the MenuExample example build failing. My commit today
fixes that. A new RC is needed to resolve this one with my commit.
--
Josh Tynjala
Bowler Hat LLC <https://bowlerhat.dev>
On Tue, Mar 15, 2022 at 1:52 PM Yishay Weiss <yi...@hotmail.com> wrote:
> I’m not following. Was the problem AIR_HOME or what your latest commit
> fixed? Do we need another RC?
>
> From: Josh Tynjala<ma...@bowlerhat.dev>
> Sent: Tuesday, March 15, 2022 10:01 PM
> To: dev@royale.apache.org<ma...@royale.apache.org>
> Subject: Re: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
>
> I discovered that I had an AIR_HOME environment variable set elsewhere, and
> that was causing the ASDoc build failure. In the approval script, I can now
> reach MenuExample with both use-flash and without.
>
> I pushed a commit to develop that fixes the MenuExample build issue.
>
> --
> Josh Tynjala
> Bowler Hat LLC <https://bowlerhat.dev>
>
>
> On Tue, Mar 15, 2022 at 10:37 AM Josh Tynjala <jo...@bowlerhat.dev>
> wrote:
>
> > When running the approval script *without* -Duse-flash=true (in other
> > words, JS-only), I get the following error when it tries to build the
> ASDoc
> > example. However, it seems to build that example correctly when I use
> > -Duse-flash=true.
> >
> > json:
> > ROYALE_COMPILER_HOME:
> >
> /Users/joshtynjala/Desktop/ApacheRoyale/apache-royale-0.9.9-src/royale-asjs/js
> > 16.6482905 seconds
> > java.lang.NullPointerException: Cannot invoke
> > "org.apache.royale.compiler.tree.as.IASNode.getSourcePath()" because
> "node"
> > is null
> > org.apache.royale.compiler.internal.codegen.as
> .ASBlockWalker.walk(ASBlockWalker.java:163)org.apache.royale.compiler.
> internal.codegen.as
> .ASBlockWalker.visitCompilationUnit(ASBlockWalker.java:188)org.apache.royale.compiler.internal.codegen.js.JSWriter.writeTo(JSWriter.java:96)org.apache.royale.compiler.internal.codegen.js.JSWriter.writeTo(JSWriter.java:80)org.apache.royale.compiler.clients.ASDOCJSC.compile(ASDOCJSC.java:275)org.apache.royale.compiler.clients.MXMLJSCRoyale._mainNoExit(MXMLJSCRoyale.java:264)org.apache.royale.compiler.clients.MXMLJSCRoyale.mainNoExit(MXMLJSCRoyale.java:221)org.apache.royale.compiler.clients.ASDOCJSC.staticMainNoExit(ASDOCJSC.java:159)org.apache.royale.compiler.clients.ASDOCJSC.main(ASDOCJSC.java:107)
> >
> > With -Duse-flash=true, I was able to get ASDoc built, but it fails on
> > building MenuExample later. This is the error:
> >
> >
> apache-royale-0.9.9-src/royale-asjs/examples/royale/MenuExample/src/main/royale/MenuExample.mxml(34):
> > col: 3 Error: This tag could not be resolved to an ActionScript class. It
> > will be ignored.
> >
> > <royale:MyInitialView />
> >
> > The issue seems to be caused by this commit:
> >
> >
> >
> https://github.com/apache/royale-asjs/commit/8bfe4a96a37a3a45441793694a9893bbd5f50d4f
> >
> > The source path should not have been changed from src/main/royale to src.
> > The correct source path is src/main/royale for all examples and libraries
> > in Royale.
> >
> > I will see if I can get these issues fixed for the next RC. As things
> > are right now, I would vote -1.
> >
> > --
> > Josh Tynjala
> > Bowler Hat LLC <https://bowlerhat.dev>
> >
> >
> > On Sun, Mar 13, 2022 at 11:35 PM <ap...@gmail.com> wrote:
> >
> >> This is the discussion thread.
> >>
> >> Thanks,
> >> Yishay Weiss
> >
> >
>
>
RE: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
Posted by Yishay Weiss <yi...@hotmail.com>.
I’m not following. Was the problem AIR_HOME or what your latest commit fixed? Do we need another RC?
From: Josh Tynjala<ma...@bowlerhat.dev>
Sent: Tuesday, March 15, 2022 10:01 PM
To: dev@royale.apache.org<ma...@royale.apache.org>
Subject: Re: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
I discovered that I had an AIR_HOME environment variable set elsewhere, and
that was causing the ASDoc build failure. In the approval script, I can now
reach MenuExample with both use-flash and without.
I pushed a commit to develop that fixes the MenuExample build issue.
--
Josh Tynjala
Bowler Hat LLC <https://bowlerhat.dev>
On Tue, Mar 15, 2022 at 10:37 AM Josh Tynjala <jo...@bowlerhat.dev>
wrote:
> When running the approval script *without* -Duse-flash=true (in other
> words, JS-only), I get the following error when it tries to build the ASDoc
> example. However, it seems to build that example correctly when I use
> -Duse-flash=true.
>
> json:
> ROYALE_COMPILER_HOME:
> /Users/joshtynjala/Desktop/ApacheRoyale/apache-royale-0.9.9-src/royale-asjs/js
> 16.6482905 seconds
> java.lang.NullPointerException: Cannot invoke
> "org.apache.royale.compiler.tree.as.IASNode.getSourcePath()" because "node"
> is null
> org.apache.royale.compiler.internal.codegen.as.ASBlockWalker.walk(ASBlockWalker.java:163)org.apache.royale.compiler.internal.codegen.as.ASBlockWalker.visitCompilationUnit(ASBlockWalker.java:188)org.apache.royale.compiler.internal.codegen.js.JSWriter.writeTo(JSWriter.java:96)org.apache.royale.compiler.internal.codegen.js.JSWriter.writeTo(JSWriter.java:80)org.apache.royale.compiler.clients.ASDOCJSC.compile(ASDOCJSC.java:275)org.apache.royale.compiler.clients.MXMLJSCRoyale._mainNoExit(MXMLJSCRoyale.java:264)org.apache.royale.compiler.clients.MXMLJSCRoyale.mainNoExit(MXMLJSCRoyale.java:221)org.apache.royale.compiler.clients.ASDOCJSC.staticMainNoExit(ASDOCJSC.java:159)org.apache.royale.compiler.clients.ASDOCJSC.main(ASDOCJSC.java:107)
>
> With -Duse-flash=true, I was able to get ASDoc built, but it fails on
> building MenuExample later. This is the error:
>
> apache-royale-0.9.9-src/royale-asjs/examples/royale/MenuExample/src/main/royale/MenuExample.mxml(34):
> col: 3 Error: This tag could not be resolved to an ActionScript class. It
> will be ignored.
>
> <royale:MyInitialView />
>
> The issue seems to be caused by this commit:
>
>
> https://github.com/apache/royale-asjs/commit/8bfe4a96a37a3a45441793694a9893bbd5f50d4f
>
> The source path should not have been changed from src/main/royale to src.
> The correct source path is src/main/royale for all examples and libraries
> in Royale.
>
> I will see if I can get these issues fixed for the next RC. As things
> are right now, I would vote -1.
>
> --
> Josh Tynjala
> Bowler Hat LLC <https://bowlerhat.dev>
>
>
> On Sun, Mar 13, 2022 at 11:35 PM <ap...@gmail.com> wrote:
>
>> This is the discussion thread.
>>
>> Thanks,
>> Yishay Weiss
>
>
Re: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
Posted by Josh Tynjala <jo...@bowlerhat.dev>.
I discovered that I had an AIR_HOME environment variable set elsewhere, and
that was causing the ASDoc build failure. In the approval script, I can now
reach MenuExample with both use-flash and without.
I pushed a commit to develop that fixes the MenuExample build issue.
--
Josh Tynjala
Bowler Hat LLC <https://bowlerhat.dev>
On Tue, Mar 15, 2022 at 10:37 AM Josh Tynjala <jo...@bowlerhat.dev>
wrote:
> When running the approval script *without* -Duse-flash=true (in other
> words, JS-only), I get the following error when it tries to build the ASDoc
> example. However, it seems to build that example correctly when I use
> -Duse-flash=true.
>
> json:
> ROYALE_COMPILER_HOME:
> /Users/joshtynjala/Desktop/ApacheRoyale/apache-royale-0.9.9-src/royale-asjs/js
> 16.6482905 seconds
> java.lang.NullPointerException: Cannot invoke
> "org.apache.royale.compiler.tree.as.IASNode.getSourcePath()" because "node"
> is null
> org.apache.royale.compiler.internal.codegen.as.ASBlockWalker.walk(ASBlockWalker.java:163)org.apache.royale.compiler.internal.codegen.as.ASBlockWalker.visitCompilationUnit(ASBlockWalker.java:188)org.apache.royale.compiler.internal.codegen.js.JSWriter.writeTo(JSWriter.java:96)org.apache.royale.compiler.internal.codegen.js.JSWriter.writeTo(JSWriter.java:80)org.apache.royale.compiler.clients.ASDOCJSC.compile(ASDOCJSC.java:275)org.apache.royale.compiler.clients.MXMLJSCRoyale._mainNoExit(MXMLJSCRoyale.java:264)org.apache.royale.compiler.clients.MXMLJSCRoyale.mainNoExit(MXMLJSCRoyale.java:221)org.apache.royale.compiler.clients.ASDOCJSC.staticMainNoExit(ASDOCJSC.java:159)org.apache.royale.compiler.clients.ASDOCJSC.main(ASDOCJSC.java:107)
>
> With -Duse-flash=true, I was able to get ASDoc built, but it fails on
> building MenuExample later. This is the error:
>
> apache-royale-0.9.9-src/royale-asjs/examples/royale/MenuExample/src/main/royale/MenuExample.mxml(34):
> col: 3 Error: This tag could not be resolved to an ActionScript class. It
> will be ignored.
>
> <royale:MyInitialView />
>
> The issue seems to be caused by this commit:
>
>
> https://github.com/apache/royale-asjs/commit/8bfe4a96a37a3a45441793694a9893bbd5f50d4f
>
> The source path should not have been changed from src/main/royale to src.
> The correct source path is src/main/royale for all examples and libraries
> in Royale.
>
> I will see if I can get these issues fixed for the next RC. As things
> are right now, I would vote -1.
>
> --
> Josh Tynjala
> Bowler Hat LLC <https://bowlerhat.dev>
>
>
> On Sun, Mar 13, 2022 at 11:35 PM <ap...@gmail.com> wrote:
>
>> This is the discussion thread.
>>
>> Thanks,
>> Yishay Weiss
>
>
Re: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3
Posted by Josh Tynjala <jo...@bowlerhat.dev>.
When running the approval script *without* -Duse-flash=true (in other
words, JS-only), I get the following error when it tries to build the ASDoc
example. However, it seems to build that example correctly when I use
-Duse-flash=true.
json:
ROYALE_COMPILER_HOME:
/Users/joshtynjala/Desktop/ApacheRoyale/apache-royale-0.9.9-src/royale-asjs/js
16.6482905 seconds
java.lang.NullPointerException: Cannot invoke
"org.apache.royale.compiler.tree.as.IASNode.getSourcePath()" because "node"
is null
org.apache.royale.compiler.internal.codegen.as.ASBlockWalker.walk(ASBlockWalker.java:163)org.apache.royale.compiler.internal.codegen.as.ASBlockWalker.visitCompilationUnit(ASBlockWalker.java:188)org.apache.royale.compiler.internal.codegen.js.JSWriter.writeTo(JSWriter.java:96)org.apache.royale.compiler.internal.codegen.js.JSWriter.writeTo(JSWriter.java:80)org.apache.royale.compiler.clients.ASDOCJSC.compile(ASDOCJSC.java:275)org.apache.royale.compiler.clients.MXMLJSCRoyale._mainNoExit(MXMLJSCRoyale.java:264)org.apache.royale.compiler.clients.MXMLJSCRoyale.mainNoExit(MXMLJSCRoyale.java:221)org.apache.royale.compiler.clients.ASDOCJSC.staticMainNoExit(ASDOCJSC.java:159)org.apache.royale.compiler.clients.ASDOCJSC.main(ASDOCJSC.java:107)
With -Duse-flash=true, I was able to get ASDoc built, but it fails on
building MenuExample later. This is the error:
apache-royale-0.9.9-src/royale-asjs/examples/royale/MenuExample/src/main/royale/MenuExample.mxml(34):
col: 3 Error: This tag could not be resolved to an ActionScript class. It
will be ignored.
<royale:MyInitialView />
The issue seems to be caused by this commit:
https://github.com/apache/royale-asjs/commit/8bfe4a96a37a3a45441793694a9893bbd5f50d4f
The source path should not have been changed from src/main/royale to src.
The correct source path is src/main/royale for all examples and libraries
in Royale.
I will see if I can get these issues fixed for the next RC. As things
are right now, I would vote -1.
--
Josh Tynjala
Bowler Hat LLC <https://bowlerhat.dev>
On Sun, Mar 13, 2022 at 11:35 PM <ap...@gmail.com> wrote:
> This is the discussion thread.
>
> Thanks,
> Yishay Weiss