You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@iotdb.apache.org by Xiangdong Huang <sa...@gmail.com> on 2020/04/04 00:00:13 UTC
Re: Shepherd Comments
Hi Dave,
Thanks for pointing out the issues in March.
I see there are still 2 issues shown on the webpage [1].
- Has not provided a wiki link
- ASF Foundation link is missing form website
However, the ASF link and wiki has already added in iotdb's website [2].
I checked [3] and find there are some description about the ASF link:
- "Text of a link expected to match regular expression:
apache|asf|foundation". However, we have a set of links about "ASF" on the
right-top of [2].
- No more description about the wiki link.
[1] http://incubator.apache.org/clutch/iotdb.html
[2] https://iotdb.apache.org
[3] https://whimsy.apache.org/pods/project/iotdb
Best,
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University
黄向东
清华大学 软件学院
Xiangdong Huang <sa...@gmail.com> 于2020年3月7日周六 上午10:39写道：
> Hi Dave,
>
> Welcome to shepherd IoTDB.
> I will fix the issues you mentioned quickly.
>
> Best,
> -----------------------------------
> Xiangdong Huang
> School of Software, Tsinghua University
>
> 黄向东
> 清华大学 软件学院
>
>
> Dave Fisher <wa...@apache.org> 于2020年3月7日周六 上午3:03写道：
>
>> Hi -
>>
>> I was assigned IOTDB to shepherd this month.
>>
>> Good progress. I have a few small comments.
>>
>> Please see http://incubator.apache.org/clutch/iotdb.html
>>
>> (1) Old releases need to be referenced at archives.apache.org and
>> removed from the dist.apache.org svn repository. Kudos for already
>> changing to use downloads.apache.org
>>
>> (2) Additional ASF links are requested on the project websites. See the
>> list at the bottom of the clutch page.
>>
>> (3) JIRA link in status file did not have id=“tracker”. I fixed this for
>> you.
>>
>> ===================================================================
>> --- iotdb.xml (revision 1874916)
>> +++ iotdb.xml (working copy)
>> @@ -91,9 +91,9 @@
>> <td>https://github.com/apache/incubator-iotdb.git</td>
>> </tr>
>> <tr>
>> - <td>Bug tracing</td>
>> + <td>Bug tracking</td>
>> <td>JIRA</td>
>> - <td>https://issues.apache.org/jira/browse/IOTDB</td>
>> + <td id="tracker">https://issues.apache.org/jira/browse/IOTDB
>> </td>
>> </tr>
>> <tr>
>> <td>Twitter</td>
>>
>> Regards,
>> Dave
>
>
Re: Shepherd Comments
Posted by Xiangdong Huang <sa...@gmail.com>.
Hi,
> You might want to remove that off the link to the foundation:
rel="noopener noreferrer”
Thanks, Justin. You are right.
And I am glad to announce that our podling website checks are almost passed
[1]!
I say "almost", it is because that on page [2], it says that we have no
wiki link......
(Actually we have. The source code is: <a href="
https://cwiki.apache.org/confluence/display/iotdb" class="nav-link
external">Wiki</a>)
[1] https://whimsy.apache.org/pods/project/iotdb
[2] http://incubator.apache.org/clutch/iotdb.html
Best,
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University
黄向东
清华大学 软件学院
Justin Mclean <ju...@classsoftware.com> 于2020年4月5日周日 上午6:12写道：
> HI,
>
> You might want to remove that off the link to the foundation:
> > rel="noopener noreferrer”
>
> Justin
>
>
>
>
Re: Shepherd Comments
Posted by Justin Mclean <ju...@classsoftware.com>.
HI,
You might want to remove that off the link to the foundation:
> rel="noopener noreferrer”
Justin
Re: Shepherd Comments
Posted by Xiangdong Huang <sa...@gmail.com>.
Hi,
I read the source code of the generated HTML, and format the snippet (and
remove many details) as follows:
<div class="nav-item">
<div class="dropdown-wrapper">
<a class="dropdown-title"><span class="title">ASF</span> <span
class="arrow right"></span></a>
<ul class="nav-dropdown" style="display:none;">
<li class="dropdown-item">
<a href="http://www.apache.org/foundation/" target="_blank"
rel="noopener noreferrer" class="nav-link external">
Foundation
<!-- a svg tag to draw a rectangle with an arrow -->
</a>
</li>
<!-- Other links-->
</ul>
</div>
</div>
Does that match the rule?
Best,
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University
黄向东
清华大学 软件学院
Christofer Dutz <ch...@c-ware.de> 于2020年4月4日周六 下午4:59写道：
> Hi all,
>
> The ruling checks static HTML links it won't find anything in code. Not
> sure how the new website generates its pages, but that might be something
> worth having a look at.
>
> Chris
> ________________________________
> Von: Xiangdong Huang <sa...@gmail.com>
> Gesendet: Samstag, 4. April 2020 02:00
> An: dev@iotdb.apache.org <de...@iotdb.apache.org>; wave@apache.org <
> wave@apache.org>
> Betreff: Re: Shepherd Comments
>
> Hi Dave,
>
> Thanks for pointing out the issues in March.
>
> I see there are still 2 issues shown on the webpage [1].
>
> - Has not provided a wiki link
> - ASF Foundation link is missing form website
>
> However, the ASF link and wiki has already added in iotdb's website [2].
>
> I checked [3] and find there are some description about the ASF link:
> - "Text of a link expected to match regular expression:
> apache|asf|foundation". However, we have a set of links about "ASF" on the
> right-top of [2].
> - No more description about the wiki link.
>
> [1] http://incubator.apache.org/clutch/iotdb.html
> [2] https://iotdb.apache.org
> [3] https://whimsy.apache.org/pods/project/iotdb
>
> Best,
> -----------------------------------
> Xiangdong Huang
> School of Software, Tsinghua University
>
> 黄向东
> 清华大学 软件学院
>
>
> Xiangdong Huang <sa...@gmail.com> 于2020年3月7日周六 上午10:39写道：
>
> > Hi Dave,
> >
> > Welcome to shepherd IoTDB.
> > I will fix the issues you mentioned quickly.
> >
> > Best,
> > -----------------------------------
> > Xiangdong Huang
> > School of Software, Tsinghua University
> >
> > 黄向东
> > 清华大学 软件学院
> >
> >
> > Dave Fisher <wa...@apache.org> 于2020年3月7日周六 上午3:03写道：
> >
> >> Hi -
> >>
> >> I was assigned IOTDB to shepherd this month.
> >>
> >> Good progress. I have a few small comments.
> >>
> >> Please see http://incubator.apache.org/clutch/iotdb.html
> >>
> >> (1) Old releases need to be referenced at archives.apache.org and
> >> removed from the dist.apache.org svn repository. Kudos for already
> >> changing to use downloads.apache.org
> >>
> >> (2) Additional ASF links are requested on the project websites. See the
> >> list at the bottom of the clutch page.
> >>
> >> (3) JIRA link in status file did not have id=“tracker”. I fixed this for
> >> you.
> >>
> >> ===================================================================
> >> --- iotdb.xml (revision 1874916)
> >> +++ iotdb.xml (working copy)
> >> @@ -91,9 +91,9 @@
> >> <td>https://github.com/apache/incubator-iotdb.git</td>
> >> </tr>
> >> <tr>
> >> - <td>Bug tracing</td>
> >> + <td>Bug tracking</td>
> >> <td>JIRA</td>
> >> - <td>https://issues.apache.org/jira/browse/IOTDB</td>
> >> + <td id="tracker">https://issues.apache.org/jira/browse/IOTDB
> >> </td>
> >> </tr>
> >> <tr>
> >> <td>Twitter</td>
> >>
> >> Regards,
> >> Dave
> >
> >
>
Re: Shepherd Comments
Posted by Christofer Dutz <ch...@c-ware.de>.
Hi all,
The ruling checks static HTML links it won't find anything in code. Not sure how the new website generates its pages, but that might be something worth having a look at.
Chris
________________________________
Von: Xiangdong Huang <sa...@gmail.com>
Gesendet: Samstag, 4. April 2020 02:00
An: dev@iotdb.apache.org <de...@iotdb.apache.org>; wave@apache.org <wa...@apache.org>
Betreff: Re: Shepherd Comments
Hi Dave,
Thanks for pointing out the issues in March.
I see there are still 2 issues shown on the webpage [1].
- Has not provided a wiki link
- ASF Foundation link is missing form website
However, the ASF link and wiki has already added in iotdb's website [2].
I checked [3] and find there are some description about the ASF link:
- "Text of a link expected to match regular expression:
apache|asf|foundation". However, we have a set of links about "ASF" on the
right-top of [2].
- No more description about the wiki link.
[1] http://incubator.apache.org/clutch/iotdb.html
[2] https://iotdb.apache.org
[3] https://whimsy.apache.org/pods/project/iotdb
Best,
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University
黄向东
清华大学 软件学院
Xiangdong Huang <sa...@gmail.com> 于2020年3月7日周六 上午10:39写道：
> Hi Dave,
>
> Welcome to shepherd IoTDB.
> I will fix the issues you mentioned quickly.
>
> Best,
> -----------------------------------
> Xiangdong Huang
> School of Software, Tsinghua University
>
> 黄向东
> 清华大学 软件学院
>
>
> Dave Fisher <wa...@apache.org> 于2020年3月7日周六 上午3:03写道：
>
>> Hi -
>>
>> I was assigned IOTDB to shepherd this month.
>>
>> Good progress. I have a few small comments.
>>
>> Please see http://incubator.apache.org/clutch/iotdb.html
>>
>> (1) Old releases need to be referenced at archives.apache.org and
>> removed from the dist.apache.org svn repository. Kudos for already
>> changing to use downloads.apache.org
>>
>> (2) Additional ASF links are requested on the project websites. See the
>> list at the bottom of the clutch page.
>>
>> (3) JIRA link in status file did not have id=“tracker”. I fixed this for
>> you.
>>
>> ===================================================================
>> --- iotdb.xml (revision 1874916)
>> +++ iotdb.xml (working copy)
>> @@ -91,9 +91,9 @@
>> <td>https://github.com/apache/incubator-iotdb.git</td>
>> </tr>
>> <tr>
>> - <td>Bug tracing</td>
>> + <td>Bug tracking</td>
>> <td>JIRA</td>
>> - <td>https://issues.apache.org/jira/browse/IOTDB</td>
>> + <td id="tracker">https://issues.apache.org/jira/browse/IOTDB
>> </td>
>> </tr>
>> <tr>
>> <td>Twitter</td>
>>
>> Regards,
>> Dave
>
>