You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/04/22 17:34:55 UTC

[GitHub] [commons-fileupload] arturobernalg opened a new pull request #60: FILEUPLOAD-312 - Use charset constant

arturobernalg opened a new pull request #60:
URL: https://github.com/apache/commons-fileupload/pull/60


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-fileupload] jochenw closed pull request #60: FILEUPLOAD-312 - Use charset constant

Posted by GitBox <gi...@apache.org>.

jochenw closed pull request #60:
URL: https://github.com/apache/commons-fileupload/pull/60


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-fileupload] coveralls commented on pull request #60: FILEUPLOAD-312 - Use charset constant

Posted by GitBox <gi...@apache.org>.

coveralls commented on pull request #60:
URL: https://github.com/apache/commons-fileupload/pull/60#issuecomment-825054301


   
   [![Coverage Status](https://coveralls.io/builds/39053946/badge)](https://coveralls.io/builds/39053946)
   
   Coverage increased (+0.1%) to 78.43% when pulling **dc3074510a769599aefa84f368fcc27f94cf05ad on arturobernalg:feature/FILEUPLOAD-312** into **b8253237867120ec8c99ea34b68ac86c6283dbc3 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-fileupload] jochenw commented on pull request #60: FILEUPLOAD-312 - Use charset constant

Posted by GitBox <gi...@apache.org>.

jochenw commented on pull request #60:
URL: https://github.com/apache/commons-fileupload/pull/60#issuecomment-825176472


   Same as in #63: I am generally fine with those changes, but the patch is way too large. Please, dotake the time to split this into smaller pieces.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org