You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "sgilmore10 (via GitHub)" <gi...@apache.org> on 2023/09/01 15:00:06 UTC

[GitHub] [arrow] sgilmore10 commented on issue #37515: [C++] `ChunkedArray::Equals()` treats NaNs as equal by default

sgilmore10 commented on issue #37515:
URL: https://github.com/apache/arrow/issues/37515#issuecomment-1702894110

   Ah, thanks for pointing that out! It's a bit weird that `Equals(ChunkedArray& other)` and `Equals(std::shared_ptr<ChunkedArray>& other)` may return different results.  For example, if you modified the program above to also call `Equals(ChunkedArray& other)`, this would be the output:
   
   ```shell
   chunked_array->Equals(chunked_array): 1
   chunked_array->Equals(*chunked_array): 0
   ```
   
   I wonder if it's worth removing this optimization for consistency?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org