[GitHub] [druid] AmatyaAvadhanula commented on a diff in pull request #13172: Fix Overlord leader election when task lock re-acquisition fails

[GitBox <gi...@apache.org>]

AmatyaAvadhanula commented on code in PR #13172:
URL: https://github.com/apache/druid/pull/13172#discussion_r985838562


##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskLockbox.java:
##########
@@ -197,17 +205,26 @@ public int compare(Pair<Task, TaskLock> left, Pair<Task, TaskLock> right)
           activeTasks.size(),
           storedLocks.size() - taskLockCount
       );
+
+      for (Task task : failedToReacquireLockTasks) {
+        for (TaskLock lock : taskStorage.getLocks(task.getId())) {
+          taskStorage.removeLock(task.getId(), lock);
+        }
+        taskStorage.setStatus(TaskStatus.failure(task.getId(), "Failed to reacquire lock"));

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org