[GitHub] [kafka] ijuma commented on a change in pull request #9284: KAFKA-10479 Throw exception if users try to update configs of existen…

[GitBox <gi...@apache.org>]

ijuma commented on a change in pull request #9284:
URL: https://github.com/apache/kafka/pull/9284#discussion_r495973438



##########
File path: docs/upgrade.html
##########
@@ -27,6 +27,14 @@ <h5><a id="upgrade_270_notable" href="#upgrade_270_notable">Notable changes in 2
         <code>default.api.timeout.ms</code>, and Kafka Streams' new <code>task.timeout.ms</code> parameters instead.
         Note that parameter <code>retry.backoff.ms</code> is not impacted by this change.
     </li>
+    <li>Altering non-reconfigurable configs of existent listeners causes <code>InvalidRequestException</code>.
+        By contrast, the previous behavior would have caused the updated configuration to be persisted, but it wouldn't
+        take effect until the broker was restarted. This change breaks behavior compatibility but the old behavior is not
+        worth keeping since that behavior is unintended. see
+        <a href="https://github.com/apache/kafka/pull/9284">KAFKA-10479</a> for more discussion.
+        see <code>DynamicBrokerConfig.DynamicSecurityConfigs</code> and <code>SocketServer.ListenerReconfigurableConfigs</code>
+        for reconfigurable configs of existent listeners.
+    </li>

Review comment:
       Does it really break compatibility? It seems like the previous behavior wasn't working as intended anyway.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org