You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Dhaval Shah <dh...@gmail.com> on 2020/01/16 06:30:22 UTC
Re: Review Request 71994: RANGER-2701 : Improve Logging mechanism for
Ranger KMS
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71994/
-----------------------------------------------------------
(Updated Jan. 16, 2020, 6:30 a.m.)
Review request for ranger, Ankita Sinha, Gautam Borad, Mehul Parikh, and Pradeep Agrawal.
Bugs: RANGER-2701
https://issues.apache.org/jira/browse/RANGER-2701
Repository: ranger
Description
-------
Change the logging level from INFO to DEBUG of certain logs in Ranger KMS.
E.G.
2019-12-13 14:45:25,844 INFO KMS - Entering decryptEncryptedKey method.
2019-12-13 14:45:25,866 INFO KMS - Exiting handleEncryptedKeyOp method.
This logs are useful while debugging the issue.
Diffs
-----
kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMS.java f67f68b
Diff: https://reviews.apache.org/r/71994/diff/3/
Testing
-------
Change LOG level frm INFO to DEBUG wherever its required for Ranger KMS
Thanks,
Dhaval Shah
Re: Review Request 71994: RANGER-2701 : Improve Logging mechanism for
Ranger KMS
Posted by Dhaval Shah <dh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71994/
-----------------------------------------------------------
(Updated Jan. 20, 2020, 6:08 a.m.)
Review request for ranger, Ankita Sinha, Gautam Borad, Mehul Parikh, and Pradeep Agrawal.
Bugs: RANGER-2701
https://issues.apache.org/jira/browse/RANGER-2701
Repository: ranger
Description
-------
Change the logging level from INFO to DEBUG of certain logs in Ranger KMS.
E.G.
2019-12-13 14:45:25,844 INFO KMS - Entering decryptEncryptedKey method.
2019-12-13 14:45:25,866 INFO KMS - Exiting handleEncryptedKeyOp method.
This logs are useful while debugging the issue.
Diffs (updated)
-----
kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMS.java f67f68b
Diff: https://reviews.apache.org/r/71994/diff/4/
Changes: https://reviews.apache.org/r/71994/diff/3-4/
Testing
-------
Change LOG level frm INFO to DEBUG wherever its required for Ranger KMS
Thanks,
Dhaval Shah
Re: Review Request 71994: RANGER-2701 : Improve Logging mechanism for
Ranger KMS
Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71994/#review219322
-----------------------------------------------------------
kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMS.java
Line 635 (original), 689 (patched)
<https://reviews.apache.org/r/71994/#comment307472>
Change to LOG.error
- Pradeep Agrawal
On Jan. 16, 2020, 6:30 a.m., Dhaval Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71994/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2020, 6:30 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Mehul Parikh, and Pradeep Agrawal.
>
>
> Bugs: RANGER-2701
> https://issues.apache.org/jira/browse/RANGER-2701
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Change the logging level from INFO to DEBUG of certain logs in Ranger KMS.
>
> E.G.
>
> 2019-12-13 14:45:25,844 INFO KMS - Entering decryptEncryptedKey method.
> 2019-12-13 14:45:25,866 INFO KMS - Exiting handleEncryptedKeyOp method.
>
> This logs are useful while debugging the issue.
>
>
> Diffs
> -----
>
> kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMS.java f67f68b
>
>
> Diff: https://reviews.apache.org/r/71994/diff/3/
>
>
> Testing
> -------
>
> Change LOG level frm INFO to DEBUG wherever its required for Ranger KMS
>
>
> Thanks,
>
> Dhaval Shah
>
>
Re: Review Request 71994: RANGER-2701 : Improve Logging mechanism for
Ranger KMS
Posted by Mehul Parikh <me...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71994/#review219295
-----------------------------------------------------------
Ship it!
Ship It!
- Mehul Parikh
On Jan. 16, 2020, 6:30 a.m., Dhaval Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71994/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2020, 6:30 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Mehul Parikh, and Pradeep Agrawal.
>
>
> Bugs: RANGER-2701
> https://issues.apache.org/jira/browse/RANGER-2701
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Change the logging level from INFO to DEBUG of certain logs in Ranger KMS.
>
> E.G.
>
> 2019-12-13 14:45:25,844 INFO KMS - Entering decryptEncryptedKey method.
> 2019-12-13 14:45:25,866 INFO KMS - Exiting handleEncryptedKeyOp method.
>
> This logs are useful while debugging the issue.
>
>
> Diffs
> -----
>
> kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMS.java f67f68b
>
>
> Diff: https://reviews.apache.org/r/71994/diff/3/
>
>
> Testing
> -------
>
> Change LOG level frm INFO to DEBUG wherever its required for Ranger KMS
>
>
> Thanks,
>
> Dhaval Shah
>
>