You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/04/13 16:15:56 UTC

[GitHub] merlimat commented on a change in pull request #1568: moving function worker service to pulsar service

merlimat commented on a change in pull request #1568: moving function worker service to pulsar service
URL: https://github.com/apache/incubator-pulsar/pull/1568#discussion_r181438813
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
 ##########
 @@ -390,6 +406,104 @@ public synchronized void brokerIsAFollowerNow() {
             });
 
             leaderElectionService.start();
+
+            // start function worker service if necessary
+            if (functionWorkerService.isPresent()) {
 
 Review comment:
   Can you move this block into a method?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services