You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2021/12/11 00:14:28 UTC
[GitHub] [logging-log4j-scala] pjfanning opened a new pull request #5: upgrade dependencies to partially suit scala 3 build
pjfanning opened a new pull request #5:
URL: https://github.com/apache/logging-log4j-scala/pull/5
This is far from a full solution to having Scala 3 build working. It does upgrade some tools and libs as a baby step.
Relates to https://issues.apache.org/jira/browse/LOG4J2-3184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j-scala] pjfanning commented on pull request #5: upgrade dependencies to partially suit scala 3 build
Posted by GitBox <gi...@apache.org>.
pjfanning commented on pull request #5:
URL: https://github.com/apache/logging-log4j-scala/pull/5#issuecomment-991800432
@jvz I'm wondering about some logger methods and why we don't just call the delegate directly - that using the macro code doesn't seem to add anything in some cases.
For example:
```
def traceExit(): Unit =
macro LoggerMacro.traceExit
```
this could be:
```
def traceExit(): Unit =
delegate.traceExit()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j-scala] pjfanning commented on pull request #5: scala 3 support
Posted by GitBox <gi...@apache.org>.
pjfanning commented on pull request #5:
URL: https://github.com/apache/logging-log4j-scala/pull/5#issuecomment-999106843
@jvz is it ok to change the scala 2 build so that traceEntry and traceExit use no macros there either (for consistency)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j-scala] jvz commented on pull request #5: scala 3 support
Posted by GitBox <gi...@apache.org>.
jvz commented on pull request #5:
URL: https://github.com/apache/logging-log4j-scala/pull/5#issuecomment-999107132
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j-scala] pjfanning commented on pull request #5: scala 3 support
Posted by GitBox <gi...@apache.org>.
pjfanning commented on pull request #5:
URL: https://github.com/apache/logging-log4j-scala/pull/5#issuecomment-999121194
@jvz could you review this when you get a chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j-scala] pjfanning commented on pull request #5: upgrade dependencies to partially suit scala 3 build
Posted by GitBox <gi...@apache.org>.
pjfanning commented on pull request #5:
URL: https://github.com/apache/logging-log4j-scala/pull/5#issuecomment-991768025
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j-scala] pjfanning commented on pull request #5: upgrade dependencies to partially suit scala 3 build
Posted by GitBox <gi...@apache.org>.
pjfanning commented on pull request #5:
URL: https://github.com/apache/logging-log4j-scala/pull/5#issuecomment-991768025
Thanks for the comments @jvz - I've only covered a fraction of the functions so far - I'll keep tipping away but it could take a while. Scala macros are not something I've worked with much. The tests also rely on scala reflection code that does not seem to work in Scala 3 so I might need to rewrite those too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j-scala] jvz commented on pull request #5: upgrade dependencies to partially suit scala 3 build
Posted by GitBox <gi...@apache.org>.
jvz commented on pull request #5:
URL: https://github.com/apache/logging-log4j-scala/pull/5#issuecomment-998438723
Made some minor dependency updates recently. Go ahead and rebase or merge from master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j-scala] jvz commented on pull request #5: scala 3 support
Posted by GitBox <gi...@apache.org>.
jvz commented on pull request #5:
URL: https://github.com/apache/logging-log4j-scala/pull/5#issuecomment-1000515452
Thanks so much for the PR! I'll work on a release candidate sometime today (assuming the rest of the build still works as documented).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j-scala] pjfanning commented on pull request #5: scala 3 support
Posted by GitBox <gi...@apache.org>.
pjfanning commented on pull request #5:
URL: https://github.com/apache/logging-log4j-scala/pull/5#issuecomment-1000514813
@jvz I'm happy to get this merged as is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j-scala] pjfanning commented on pull request #5: upgrade dependencies to partially suit scala 3 build
Posted by GitBox <gi...@apache.org>.
pjfanning commented on pull request #5:
URL: https://github.com/apache/logging-log4j-scala/pull/5#issuecomment-999078320
@jvz I've made some progress but could you look at my comment from 10 days ago? Is it ok just to delegate the traceEntry and traceExit calls to wrapped logger instead of getting macros involved? In my head, the only benefit of the macros is to take Scala interpolated strings and convert them to log4j interpolated strings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j-scala] jvz commented on pull request #5: upgrade dependencies to partially suit scala 3 build
Posted by GitBox <gi...@apache.org>.
jvz commented on pull request #5:
URL: https://github.com/apache/logging-log4j-scala/pull/5#issuecomment-999096680
Oh yeah, please, go ahead and make that a delegated method. The point of the macros in the past were to allow for string interpolation to be elided when logging is disabled for that call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j-scala] jvz merged pull request #5: scala 3 support
Posted by GitBox <gi...@apache.org>.
jvz merged pull request #5:
URL: https://github.com/apache/logging-log4j-scala/pull/5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org