You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Justin Edelson (JIRA)" <ji...@apache.org> on 2010/09/01 18:27:54 UTC
[jira] Created: (FELIX-2570) HTML is escaped in
ModeAwareConfigurationPrinter when in "web" mode
HTML is escaped in ModeAwareConfigurationPrinter when in "web" mode
-------------------------------------------------------------------
Key: FELIX-2570
URL: https://issues.apache.org/jira/browse/FELIX-2570
Project: Felix
Issue Type: Bug
Components: Web Console
Affects Versions: webconsole-3.1.2
Reporter: Justin Edelson
See http://markmail.org/message/ppwjjbc6tayzvcew
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (FELIX-2570) HTML is escaped in
ModeAwareConfigurationPrinter when in "web" mode
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger closed FELIX-2570.
------------------------------------
Close after release
> HTML is escaped in ModeAwareConfigurationPrinter when in "web" mode
> -------------------------------------------------------------------
>
> Key: FELIX-2570
> URL: https://issues.apache.org/jira/browse/FELIX-2570
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Affects Versions: webconsole-3.1.2
> Reporter: Justin Edelson
> Assignee: Felix Meschberger
> Fix For: webconsole-3.1.6
>
>
> See http://markmail.org/message/ppwjjbc6tayzvcew
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (FELIX-2570) HTML is escaped in
ModeAwareConfigurationPrinter when in "web" mode
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger reassigned FELIX-2570:
----------------------------------------
Assignee: Felix Meschberger
> HTML is escaped in ModeAwareConfigurationPrinter when in "web" mode
> -------------------------------------------------------------------
>
> Key: FELIX-2570
> URL: https://issues.apache.org/jira/browse/FELIX-2570
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Affects Versions: webconsole-3.1.2
> Reporter: Justin Edelson
> Assignee: Felix Meschberger
>
> See http://markmail.org/message/ppwjjbc6tayzvcew
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2570) HTML is escaped in
ModeAwareConfigurationPrinter when in "web" mode
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920494#action_12920494 ]
Carsten Ziegeler commented on FELIX-2570:
-----------------------------------------
The mail thread above suggests new modes, I'm not sure if this is a good idea.
What about adding a new property: felix.webconsole.configprinter.escapeOutput or something like this - a printer can set this one with value false if it wants to output html
> HTML is escaped in ModeAwareConfigurationPrinter when in "web" mode
> -------------------------------------------------------------------
>
> Key: FELIX-2570
> URL: https://issues.apache.org/jira/browse/FELIX-2570
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Affects Versions: webconsole-3.1.2
> Reporter: Justin Edelson
> Assignee: Felix Meschberger
>
> See http://markmail.org/message/ppwjjbc6tayzvcew
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2570) HTML is escaped in
ModeAwareConfigurationPrinter when in "web" mode
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920588#action_12920588 ]
Carsten Ziegeler commented on FELIX-2570:
-----------------------------------------
Ok, while this of course works, I'm wondering what the benefit over using a separate property is?
> HTML is escaped in ModeAwareConfigurationPrinter when in "web" mode
> -------------------------------------------------------------------
>
> Key: FELIX-2570
> URL: https://issues.apache.org/jira/browse/FELIX-2570
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Affects Versions: webconsole-3.1.2
> Reporter: Justin Edelson
> Assignee: Felix Meschberger
>
> See http://markmail.org/message/ppwjjbc6tayzvcew
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2570) HTML is escaped in
ModeAwareConfigurationPrinter when in "web" mode
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920584#action_12920584 ]
Carsten Ziegeler commented on FELIX-2570:
-----------------------------------------
> Yes. If just "html" is specified it really means "always" + "html"
Hmm, and how can I say, just "web" but html? If I specify the modes "web" and "html"?
> HTML is escaped in ModeAwareConfigurationPrinter when in "web" mode
> -------------------------------------------------------------------
>
> Key: FELIX-2570
> URL: https://issues.apache.org/jira/browse/FELIX-2570
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Affects Versions: webconsole-3.1.2
> Reporter: Justin Edelson
> Assignee: Felix Meschberger
>
> See http://markmail.org/message/ppwjjbc6tayzvcew
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2570) HTML is escaped in
ModeAwareConfigurationPrinter when in "web" mode
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920541#action_12920541 ]
Justin Edelson commented on FELIX-2570:
---------------------------------------
> What about adding a new property: felix.webconsole.configprinter.escapeOutput or something like this - a printer can set this one with value false if it
> wants to output html
This sounds good to me, although perhaps the property name should have "web" in it to indicate that the escaping should be disabled in web mode *only*.
> HTML is escaped in ModeAwareConfigurationPrinter when in "web" mode
> -------------------------------------------------------------------
>
> Key: FELIX-2570
> URL: https://issues.apache.org/jira/browse/FELIX-2570
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Affects Versions: webconsole-3.1.2
> Reporter: Justin Edelson
> Assignee: Felix Meschberger
>
> See http://markmail.org/message/ppwjjbc6tayzvcew
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2570) HTML is escaped in
ModeAwareConfigurationPrinter when in "web" mode
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920570#action_12920570 ]
Felix Meschberger commented on FELIX-2570:
------------------------------------------
> The default is "always"
That's what I wanted to say ;-)
> Is "all" the default?
Yes. If just "html" is specified it really means "always" + "html"
> HTML is escaped in ModeAwareConfigurationPrinter when in "web" mode
> -------------------------------------------------------------------
>
> Key: FELIX-2570
> URL: https://issues.apache.org/jira/browse/FELIX-2570
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Affects Versions: webconsole-3.1.2
> Reporter: Justin Edelson
> Assignee: Felix Meschberger
>
> See http://markmail.org/message/ppwjjbc6tayzvcew
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2570) HTML is escaped in
ModeAwareConfigurationPrinter when in "web" mode
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920587#action_12920587 ]
Felix Meschberger commented on FELIX-2570:
------------------------------------------
Like this:
<no property> or empty property --> always; web console output filtered
"web" --> web console only, filtered
"web, html" --> web console only, not-filtered
"html" --> always; web console output not-filtered
...
> HTML is escaped in ModeAwareConfigurationPrinter when in "web" mode
> -------------------------------------------------------------------
>
> Key: FELIX-2570
> URL: https://issues.apache.org/jira/browse/FELIX-2570
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Affects Versions: webconsole-3.1.2
> Reporter: Justin Edelson
> Assignee: Felix Meschberger
>
> See http://markmail.org/message/ppwjjbc6tayzvcew
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2570) HTML is escaped in
ModeAwareConfigurationPrinter when in "web" mode
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920548#action_12920548 ]
Felix Meschberger commented on FELIX-2570:
------------------------------------------
I am working on a slightly different solution: Adding the "pseudo-mode" "html" to the registered modes of the ConfigurationPrinter signals, that html output should be passed unfiltered when rendering in the web console. The pseudo-mode only has effect if the configuration printer is registered for "web" or "all" modes.
> HTML is escaped in ModeAwareConfigurationPrinter when in "web" mode
> -------------------------------------------------------------------
>
> Key: FELIX-2570
> URL: https://issues.apache.org/jira/browse/FELIX-2570
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Affects Versions: webconsole-3.1.2
> Reporter: Justin Edelson
> Assignee: Felix Meschberger
>
> See http://markmail.org/message/ppwjjbc6tayzvcew
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2570) HTML is escaped in
ModeAwareConfigurationPrinter when in "web" mode
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920563#action_12920563 ]
Carsten Ziegeler commented on FELIX-2570:
-----------------------------------------
The default is "always" which means in all modes :)
> HTML is escaped in ModeAwareConfigurationPrinter when in "web" mode
> -------------------------------------------------------------------
>
> Key: FELIX-2570
> URL: https://issues.apache.org/jira/browse/FELIX-2570
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Affects Versions: webconsole-3.1.2
> Reporter: Justin Edelson
> Assignee: Felix Meschberger
>
> See http://markmail.org/message/ppwjjbc6tayzvcew
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (FELIX-2570) HTML is escaped in
ModeAwareConfigurationPrinter when in "web" mode
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger resolved FELIX-2570.
--------------------------------------
Resolution: Fixed
Assuming this is ok, thus resolving
> HTML is escaped in ModeAwareConfigurationPrinter when in "web" mode
> -------------------------------------------------------------------
>
> Key: FELIX-2570
> URL: https://issues.apache.org/jira/browse/FELIX-2570
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Affects Versions: webconsole-3.1.2
> Reporter: Justin Edelson
> Assignee: Felix Meschberger
> Fix For: webconsole-3.1.4
>
>
> See http://markmail.org/message/ppwjjbc6tayzvcew
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-2570) HTML is escaped in
ModeAwareConfigurationPrinter when in "web" mode
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger updated FELIX-2570:
-------------------------------------
Fix Version/s: webconsole-3.1.4
> HTML is escaped in ModeAwareConfigurationPrinter when in "web" mode
> -------------------------------------------------------------------
>
> Key: FELIX-2570
> URL: https://issues.apache.org/jira/browse/FELIX-2570
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Affects Versions: webconsole-3.1.2
> Reporter: Justin Edelson
> Assignee: Felix Meschberger
> Fix For: webconsole-3.1.4
>
>
> See http://markmail.org/message/ppwjjbc6tayzvcew
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2570) HTML is escaped in
ModeAwareConfigurationPrinter when in "web" mode
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920558#action_12920558 ]
Justin Edelson commented on FELIX-2570:
---------------------------------------
Is "all" the default? Or would that need to be specified explicitly?
In http://svn.apache.org/repos/asf/sling/trunk/bundles/jcr/webconsole/src/main/java/org/apache/sling/jcr/webconsole/internal/NodeTypeConfigurationPrinter.java (which is where this comes from), I didn't specify a mode property and instead tried (it's commented out now) to output HTML if the mode passed to printConfiguration() is "web".
> HTML is escaped in ModeAwareConfigurationPrinter when in "web" mode
> -------------------------------------------------------------------
>
> Key: FELIX-2570
> URL: https://issues.apache.org/jira/browse/FELIX-2570
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Affects Versions: webconsole-3.1.2
> Reporter: Justin Edelson
> Assignee: Felix Meschberger
>
> See http://markmail.org/message/ppwjjbc6tayzvcew
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2570) HTML is escaped in
ModeAwareConfigurationPrinter when in "web" mode
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920664#action_12920664 ]
Felix Meschberger commented on FELIX-2570:
------------------------------------------
First I didn't think of adding a property and second I started with the idea of adding a new mode like web+html, which turned out to make things more complicated than need which then resulted in the pseudo mode.
But looking at it again, you are right. It is conceptually cleaner to add a new property for this.
The modes property is called just "modes". So we might want to call the new property something short, too.
Proposing "web.unescaped" indicating that this is for the "web" mode and to allowing for unescaped html output. By default this property is not set thus supporting backwards compatibility by escaping the output. If the property is set to a value which can be converted to a boolean true value (e.g. Boolean.TRUE or the string "true") the output is not escaped.
> HTML is escaped in ModeAwareConfigurationPrinter when in "web" mode
> -------------------------------------------------------------------
>
> Key: FELIX-2570
> URL: https://issues.apache.org/jira/browse/FELIX-2570
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Affects Versions: webconsole-3.1.2
> Reporter: Justin Edelson
> Assignee: Felix Meschberger
>
> See http://markmail.org/message/ppwjjbc6tayzvcew
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2570) HTML is escaped in
ModeAwareConfigurationPrinter when in "web" mode
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920961#action_12920961 ]
Felix Meschberger commented on FELIX-2570:
------------------------------------------
Committed the changes in Rev. 1022523.
Added a new service registration property
WebConsoleConstants.CONFIG_PRINTER_WEB_UNESCAPED = "felix.webconsole.configprinter.web.unescaped";
If this property is set to true (Boolean true or String "true") the output of the respective Configuration Printer service is not escaped when displayed in the web display.
Of course the configuration printer has to take care to not generate HTML when printing status in non-web mode, like text or ZIP.
Does this suit your need ?
> HTML is escaped in ModeAwareConfigurationPrinter when in "web" mode
> -------------------------------------------------------------------
>
> Key: FELIX-2570
> URL: https://issues.apache.org/jira/browse/FELIX-2570
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Affects Versions: webconsole-3.1.2
> Reporter: Justin Edelson
> Assignee: Felix Meschberger
>
> See http://markmail.org/message/ppwjjbc6tayzvcew
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.