[jira] [Comment Edited] (YARN-8898) Fix FederationInterceptor#allocate to set application priority in allocateResponse

["Bibin A Chundatt (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-8898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660577#comment-16660577 ] 

Bibin A Chundatt edited comment on YARN-8898 at 10/23/18 12:37 PM:
-------------------------------------------------------------------

[~botong]/[~BilwaST]

Adding few points which we can discuss on.
 # Application priority update, what should be the behaviour if subcluster's priorities are not same. Should we be considering appriority of home cluster always. ?
 # Also incase of async response from subcluster we should maintaine response order too. {{HeartbeatCallBack#callback}} i think we should be using linked list rt ?
{code:java}
          responses = new ArrayList<>();
          asyncResponseSink.put(subClusterId, responses);
{code}

 # If response from home cluster not received during merge of response, probably we have to remember the last response from home cluster.


was (Author: bibinchundatt):
[~botong]/[~BilwaST]

Adding few points which we can discuss on.

#  Application priority update, what should be the behaviour if subcluster's priorities are not same. Should we be considering appriority of home cluster always. ?
# Also incase of async response from subcluster we should maintaine response order too. {{HeartbeatCallBack#callback}} i think we should be using linked list rt ?
{code}
          responses = new ArrayList<>();
          asyncResponseSink.put(subClusterId, responses);
{code}
# If response from home cluster received during merge of response, probably we have to remember the last response from home cluster.






> Fix FederationInterceptor#allocate to set application priority in allocateResponse
> ----------------------------------------------------------------------------------
>
>                 Key: YARN-8898
>                 URL: https://issues.apache.org/jira/browse/YARN-8898
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Bibin A Chundatt
>            Assignee: Bilwa S T
>            Priority: Major
>
> In case of FederationInterceptor#mergeAllocateResponses skips application_priority in response returned



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org