You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/10/01 17:17:42 UTC

[GitHub] [zookeeper] championquizzer opened a new pull request #1474: Fixed some bugs found by shellcheck

championquizzer opened a new pull request #1474:
URL: https://github.com/apache/zookeeper/pull/1474


   1. Double quote array expansions to avoid re-splitting elements in 3 files.
   2. Added shebang to one file.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] ctubbsii commented on a change in pull request #1474: Fixed some bugs found by shellcheck

Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #1474:
URL: https://github.com/apache/zookeeper/pull/1474#discussion_r498527845



##########
File path: bin/zkServer.sh
##########
@@ -229,9 +229,9 @@ version)
     ;;
 restart)
     shift
-    "$0" stop ${@}
+    "$0" stop "${@}"
     sleep 3
-    "$0" start ${@}
+    "$0" start "${@}"

Review comment:
       FWIW, the braces aren't doing anything here, and `"${@}"` could be replaced by `"$@"`
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org