[GitHub] zeppelin pull request #3140: [WIP][ZEPPELIN-3713] Remove paragraph text and ...

[egorklimov <gi...@git.apache.org>]

GitHub user egorklimov opened a pull request:

    https://github.com/apache/zeppelin/pull/3140

    [WIP][ZEPPELIN-3713] Remove paragraph text and title from NotebookService.runParagraph

    ### What is this PR for?
    
    NotebookService.runParagraph have paragraph text and title as args, it seems to be unnecessary, because paragraph extracted from note already contains them. Also it might cause new bugs related to incorrect text/title passing.
    
    For example, bug in NotebookRestApi.runParagraph():
    
    ```
    @POST
    @Path("job/{noteId}/{paragraphId}")
    @ZeppelinApi
    public Response runParagraph(@PathParam("noteId") String noteId,
    @PathParam("paragraphId") String paragraphId, String message)
    throws IOException, IllegalArgumentException {
    
    ...
    
    notebookService.runParagraph(
        noteId, paragraphId, "", "", params,
        new HashMap<String, Object>(), false, getServiceContext(), new RestServiceCallback<>());
    return new JsonResponse<>(Status.OK).build();
    }
    
    ```
    all paragraphs processing as blank.
    
    
    ### What type of PR is it?
    Bug Fix & Refactoring
    
    ### What is the Jira issue?
    * issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN-3713
    
    ### How should this be tested?
    * Tested manually
    * [CI in progress](https://travis-ci.org/TinkoffCreditSystems/zeppelin/builds/416018134) 
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3713

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/3140.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3140
    
----
commit 41cc3e5b55536dbe434bb717d832fa11b76eb352
Author: egorklimov <kl...@...>
Date:   2018-08-14T17:04:02Z

    Refactor NotebookService

----


---

[GitHub] zeppelin pull request #3140: [WIP][ZEPPELIN-3713] Remove paragraph text and ...

[egorklimov <gi...@git.apache.org>]

Github user egorklimov closed the pull request at:

    https://github.com/apache/zeppelin/pull/3140


---

[GitHub] zeppelin issue #3140: [WIP][ZEPPELIN-3713] Remove paragraph text and title f...

[egorklimov <gi...@git.apache.org>]

Github user egorklimov commented on the issue:

    https://github.com/apache/zeppelin/pull/3140
  
    @zjffdu said:
    
    > I am afraid we have to keep title & text, because when we run paragraph, the paragraph text in backend may not be updated. That means api runParagraph is not only run paragraph, but also persist paragraph. 
    
    Maybe it will be better to discuss this here than in mail list.
    
    I opened new [task](https://issues.apache.org/jira/browse/ZEPPELIN-3715) with REST API bug fix.


---