[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1012: MINIFICPP-1499 Add clcache to Windows builds

[GitBox <gi...@apache.org>]

lordgamez commented on a change in pull request #1012:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1012#discussion_r579323553



##########
File path: .github/workflows/ci.yml
##########
@@ -64,27 +64,64 @@ jobs:
   windows_VS2017:
     name: "windows-vs2017"
     runs-on: windows-2016
-    timeout-minutes: 90
+    timeout-minutes: 120
+    env:
+      CLCACHE_DIR: ${{ GITHUB.WORKSPACE }}\clcache
+      CLCACHE_CL: C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\bin\Hostx86\x86\cl_original.exe
     steps:
       - id: checkout
         uses: actions/checkout@v2
+      - id: cache
+        uses: actions/cache@v2
+        with:
+          path: ${{ env.CLCACHE_DIR }}
+          key: windows-vs2017-clcache-${{github.ref}}-${{github.sha}}
+          restore-keys: |
+            windows-vs2017-clcache-${{github.ref}}-
+            windows-vs2017-clcache-refs/heads/main-
       - name: Setup PATH
         uses: microsoft/setup-msbuild@v1.0.2
+      - name: Setup clcache
+        run: |
+          (New-Object System.Net.WebClient).DownloadFile('https://github.com/frerich/clcache/releases/download/v4.2.0/clcache-4.2.0.zip', "$pwd\clcache.zip")

Review comment:
       I will give another go with sccache and see if I can make it work. Unfortunately I only found 3 options of caching for MSVC (2 of which are not maintained), but still from what I've found clcache seem to be the preferred one. There are some forks with active development, the author of clcache advises people to merge new required features to those repositories. Although I think for our use case the last release version may suffice if sccache cannot be used.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org