You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/08/24 14:37:00 UTC

[jira] [Work logged] (ARTEMIS-3440) separate effect of -Pdev from -Ptests

     [ https://issues.apache.org/jira/browse/ARTEMIS-3440?focusedWorklogId=641130&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-641130 ]

ASF GitHub Bot logged work on ARTEMIS-3440:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/Aug/21 14:36
            Start Date: 24/Aug/21 14:36
    Worklog Time Spent: 10m 
      Work Description: gemmellr opened a new pull request #3707:
URL: https://github.com/apache/activemq-artemis/pull/3707


   https://issues.apache.org/jira/browse/ARTEMIS-3440
   
   The JIRA changes are in the first commit.
   
   The PR also includes a second commit building on the first, to improve the GHA job config so various checks are run independently, ensuring the actual test suite finishes quicker, happens even if the checks fail (and more typically, vice versa), and the checks start and finish sooner. All together aiming to getting earlier and more complete feedback on the changes, with the overall runs sometimes ~10 minutes faster than before.
   
   (This first run wont be as fast as it will most of the time, as the cache fixups will mean it has it to repopulate - though comparing, this scenario still looks to be ~15 minutes faster than it was before the changes, as the main branch cache happened to repopulate this morning, which is when I noticed some of the issues with its use that I also fixed here)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 641130)
    Remaining Estimate: 0h
            Time Spent: 10m

> separate effect of -Pdev from -Ptests
> -------------------------------------
>
>                 Key: ARTEMIS-3440
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3440
>             Project: ActiveMQ Artemis
>          Issue Type: Task
>            Reporter: Robbie Gemmell
>            Assignee: Robbie Gemmell
>            Priority: Major
>             Fix For: 2.19.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently the build has RAT and checkstyle executions always configured, but uses some artemis specific properties to skip them by default. These properties are then used in the 'tests', fast-tests', and 'dev' profiles to enable the checks when the profile is activated.
> This approach means that:
>  - If you use the test profiles (needed to run tests), you get the dev checks even if you dont want.
>  - You cant skip or not-skip the checks even with their own well known skip properties.
>  - You cant run the check directly with its own mojo, without first hunting down an artemis specific property to also not-skip them so they actually run.
> The former in particular can be annoying when developing and running specific tests repeatedly, as it adds >10sec before the execution of a specified integration test for example.
> It also prevents an improvement I was looking to do for the GHA CI jobs where the checks are run in isolation from the tests (ensures the tests start and complete as fast as possible, speeding things up overall, makes the checks not prevent the tests running if they fail, and vice versa ensures the checks occur regardless of the tests failing which happens somewhat often at times).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)