[GitHub] [guacamole-client] mike-jumper commented on issue #348: GUACAMOLE-422: Forward Timezone to RDP and SSH Connections

[GitBox <gi...@apache.org>]

mike-jumper commented on issue #348: GUACAMOLE-422: Forward Timezone to RDP and SSH Connections
URL: https://github.com/apache/guacamole-client/pull/348#issuecomment-476362364
 
 
   Regarding whether the changes belong in 1.1.0, the base timezone changes are already present on staging/1.1.0, at least for providing "timezone" parameters for RDP and SSH. That much should definitely stay, as it's compatible with 1.0.0 and I believe was included in scope as part of the initial release discussion.
   
   As for the handshake changes ... those are incompatible protocol changes and would technically bump things to 2.0.0. _However_, I think we can alter things there such that the changes are compatible.
   
   If the handling of the handshake phase is altered such that:
   
   1. Order of the various handshake-specific instructions does not matter.
   2. Presence/absence of the various handshake-specific instructions does not matter (with the exception of `connect` which terminates the handshake).
   
   then things will inherently be backward compatible, and the protocol becomes a bit more forgiving of implementations going forward. This would require replacing current usage of `guac_parser_expect()` within the handshake with a read loop and array of instruction handler callbacks, similar to:
   
   https://github.com/apache/guacamole-server/blob/ffe0b57faa97272ee1287bcea74c5d787e221953/src/libguac/user-handlers.c#L37-L54
   
   and:
   
   https://github.com/apache/guacamole-server/blob/ffe0b57faa97272ee1287bcea74c5d787e221953/src/libguac/user.c#L170-L186

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services