You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@struts.apache.org by pl...@apache.org on 2006/08/29 00:39:14 UTC
svn commit: r437868 - in
/struts/struts2/trunk/core/src/main/java/org/apache/struts2:
StrutsConstants.java dispatcher/mapper/DefaultActionMapper.java
Author: plightbo
Date: Mon Aug 28 15:39:12 2006
New Revision: 437868
URL: http://svn.apache.org/viewvc?rev=437868&view=rev
Log:
Wendy has a sharp eye
Modified:
struts/struts2/trunk/core/src/main/java/org/apache/struts2/StrutsConstants.java
struts/struts2/trunk/core/src/main/java/org/apache/struts2/dispatcher/mapper/DefaultActionMapper.java
Modified: struts/struts2/trunk/core/src/main/java/org/apache/struts2/StrutsConstants.java
URL: http://svn.apache.org/viewvc/struts/struts2/trunk/core/src/main/java/org/apache/struts2/StrutsConstants.java?rev=437868&r1=437867&r2=437868&view=diff
==============================================================================
--- struts/struts2/trunk/core/src/main/java/org/apache/struts2/StrutsConstants.java (original)
+++ struts/struts2/trunk/core/src/main/java/org/apache/struts2/StrutsConstants.java Mon Aug 28 15:39:12 2006
@@ -123,5 +123,5 @@
public static final String STRUTS_SERVE_STATIC_BROWSER_CACHE = "struts.serve.static.browserCache";
/** Allows one to disable dynamic method invocation from the URL */
- public static final String STRUTS_DISABLE_DYNAMIC_METHOD_INVOCATIOn = "struts.core.disableDynamicMethodInvocation";
+ public static final String STRUTS_DISABLE_DYNAMIC_METHOD_INVOCATION = "struts.core.disableDynamicMethodInvocation";
}
Modified: struts/struts2/trunk/core/src/main/java/org/apache/struts2/dispatcher/mapper/DefaultActionMapper.java
URL: http://svn.apache.org/viewvc/struts/struts2/trunk/core/src/main/java/org/apache/struts2/dispatcher/mapper/DefaultActionMapper.java?rev=437868&r1=437867&r2=437868&view=diff
==============================================================================
--- struts/struts2/trunk/core/src/main/java/org/apache/struts2/dispatcher/mapper/DefaultActionMapper.java (original)
+++ struts/struts2/trunk/core/src/main/java/org/apache/struts2/dispatcher/mapper/DefaultActionMapper.java Mon Aug 28 15:39:12 2006
@@ -149,7 +149,7 @@
static final String REDIRECT_PREFIX = "redirect:";
static final String REDIRECT_ACTION_PREFIX = "redirect-action:";
- private static boolean disableDyanmicMethodCalls = "true".equals(Settings.get(StrutsConstants.STRUTS_SERVE_STATIC_BROWSER_CACHE));
+ private static boolean disableDynamicMethodCalls = "true".equals(Settings.get(StrutsConstants.STRUTS_SERVE_STATIC_BROWSER_CACHE));
private PrefixTrie prefixTrie = null;
public DefaultActionMapper() {
@@ -208,7 +208,7 @@
parseNameAndNamespace(uri, mapping, config);
- if (!disableDyanmicMethodCalls) {
+ if (!disableDynamicMethodCalls) {
handleSpecialParameters(request, mapping);
}
@@ -216,7 +216,7 @@
return null;
}
- if (!disableDyanmicMethodCalls) {
+ if (!disableDynamicMethodCalls) {
// handle "name!method" convention.
String name = mapping.getName();
int exclamation = name.lastIndexOf("!");
Re: svn commit: r437868 - in
/struts/struts2/trunk/core/src/main/java/org/apache/struts2:
StrutsConstants.java dispatcher/mapper/DefaultActionMapper.java
Posted by Patrick Lightbody <fo...@opensymphony.com>.
> > struts.core.disableDynamicMethodInvocation
>
> Is there a reason to add ".core" here?
>
Darn - you caught my attempt to very subtly imply that disabling this feature disables something core to Struts. It certainly is in my opinion. :)
> We don't specify ".core" in any of the other property
> names.
>
> On that subject, do we need to specify all these
> settings as
> properties, or could they be specified in a
> struts.xml instead? It
> would be nice if we could configure everything in one
> place.
Yes, I agree, we should do this. The only reason we had it split up before was because we didn't have a WebWork-specific DTD. But we have that now, thanks to Don, we I agree, we should change it.
> -Ted.
>
>
> On 8/28/06, plightbo@apache.org <pl...@apache.org>
> wrote:
> > Author: plightbo
> > Date: Mon Aug 28 15:39:12 2006
> > New Revision: 437868
> >
> > URL:
> http://svn.apache.org/viewvc?rev=437868&view=rev
> > Log:
> > Wendy has a sharp eye
> >
> > Modified:
> >
>
> truts/struts2/trunk/core/src/main/java/org/apache/stru
> ts2/StrutsConstants.java
> >
>
> truts/struts2/trunk/core/src/main/java/org/apache/stru
> ts2/dispatcher/mapper/DefaultActionMapper.java
> >
> > Modified:
> struts/struts2/trunk/core/src/main/java/org/apache/str
> uts2/StrutsConstants.java
> > URL:
> http://svn.apache.org/viewvc/struts/struts2/trunk/core
> /src/main/java/org/apache/struts2/StrutsConstants.java
> ?rev=437868&r1=437867&r2=437868&view=diff
> >
> ======================================================
> ========================
> > ---
> struts/struts2/trunk/core/src/main/java/org/apache/str
> uts2/StrutsConstants.java (original)
> > +++
> struts/struts2/trunk/core/src/main/java/org/apache/str
> uts2/StrutsConstants.java Mon Aug 28 15:39:12 2006
> > @@ -123,5 +123,5 @@
> > public static final String
> STRUTS_SERVE_STATIC_BROWSER_CACHE =
> "struts.serve.static.browserCache";
> >
> > /** Allows one to disable dynamic method
> invocation from the URL */
> > - public static final String
> STRUTS_DISABLE_DYNAMIC_METHOD_INVOCATIOn =
> "struts.core.disableDynamicMethodInvocation";
> > + public static final String
> STRUTS_DISABLE_DYNAMIC_METHOD_INVOCATION =
> "struts.core.disableDynamicMethodInvocation";
> > }
>
> ------------------------------------------------------
> ---------------
> To unsubscribe, e-mail:
> dev-unsubscribe@struts.apache.org
> For additional commands, e-mail:
> dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
Posted via Jive Forums
http://forums.opensymphony.com/thread.jspa?threadID=41607&messageID=83081#83081
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: svn commit: r437868 - in /struts/struts2/trunk/core/src/main/java/org/apache/struts2: StrutsConstants.java dispatcher/mapper/DefaultActionMapper.java
Posted by Ted Husted <hu...@apache.org>.
> struts.core.disableDynamicMethodInvocation
Is there a reason to add ".core" here?
We don't specify ".core" in any of the other property names.
On that subject, do we need to specify all these settings as
properties, or could they be specified in a struts.xml instead? It
would be nice if we could configure everything in one place.
-Ted.
On 8/28/06, plightbo@apache.org <pl...@apache.org> wrote:
> Author: plightbo
> Date: Mon Aug 28 15:39:12 2006
> New Revision: 437868
>
> URL: http://svn.apache.org/viewvc?rev=437868&view=rev
> Log:
> Wendy has a sharp eye
>
> Modified:
> struts/struts2/trunk/core/src/main/java/org/apache/struts2/StrutsConstants.java
> struts/struts2/trunk/core/src/main/java/org/apache/struts2/dispatcher/mapper/DefaultActionMapper.java
>
> Modified: struts/struts2/trunk/core/src/main/java/org/apache/struts2/StrutsConstants.java
> URL: http://svn.apache.org/viewvc/struts/struts2/trunk/core/src/main/java/org/apache/struts2/StrutsConstants.java?rev=437868&r1=437867&r2=437868&view=diff
> ==============================================================================
> --- struts/struts2/trunk/core/src/main/java/org/apache/struts2/StrutsConstants.java (original)
> +++ struts/struts2/trunk/core/src/main/java/org/apache/struts2/StrutsConstants.java Mon Aug 28 15:39:12 2006
> @@ -123,5 +123,5 @@
> public static final String STRUTS_SERVE_STATIC_BROWSER_CACHE = "struts.serve.static.browserCache";
>
> /** Allows one to disable dynamic method invocation from the URL */
> - public static final String STRUTS_DISABLE_DYNAMIC_METHOD_INVOCATIOn = "struts.core.disableDynamicMethodInvocation";
> + public static final String STRUTS_DISABLE_DYNAMIC_METHOD_INVOCATION = "struts.core.disableDynamicMethodInvocation";
> }
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org