You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/07/29 06:51:53 UTC

[GitHub] [rocketmq] makabakaboom opened a new pull request #3191: [ISSUE #3015] make samplingInMinutes samplingInHour collected data more accurate

makabakaboom opened a new pull request #3191:
URL: https://github.com/apache/rocketmq/pull/3191


   make samplingInMinutes samplingInHour collected data more accurate
   
   
   **Make sure set the target branch to `develop`**
   
   ## What is the purpose of the change
   
   [ISSUE #3015]
   
   ## Brief changelog
   
   [ISSUE #3015]
   
   ## Verifying this change
   
   [ISSUE #3015]
   
   Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
   
   - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] panzhi33 commented on pull request #3191: [ISSUE #3190] make samplingInMinutes samplingInHour collected data more accurate

Posted by GitBox <gi...@apache.org>.
panzhi33 commented on pull request #3191:
URL: https://github.com/apache/rocketmq/pull/3191#issuecomment-890487483


   > csListMinute，csListHour，csListDay列表分别保存一分钟、一小时、一天的点，分别对应有6、6、24个点，computeStatsData通过调用栈我看用途大多数都是去计算系统中一些统计值，如topic一段时间内的消息量、TPS等统计值。按照原实现，比如我看到的topic的小时级别数据和天级别的数据就具有一定的延迟性，比如小时级别的数据我就需要10分钟后才能精确，天的数据就有1小时延迟。修改代码只是在统计分钟级别的时候去更新了小时和天级别的最后一个值的数据，这样小时级别和天级别还是原设计的6、24个点，只是小时改为统计1h+10min内的实时值，一天改为统计1D + 1h内的实时值。或许这里修改不是最优的实现方式，但是我认为这里确实存在统计延迟
   
   你是对的,我的问题,没看仔细.有个问题问下,为啥不放在synchronized代码块里面了


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] panzhi33 edited a comment on pull request #3191: [ISSUE #3190] make samplingInMinutes samplingInHour collected data more accurate

Posted by GitBox <gi...@apache.org>.
panzhi33 edited a comment on pull request #3191:
URL: https://github.com/apache/rocketmq/pull/3191#issuecomment-889766188


   ![image](https://user-images.githubusercontent.com/29321745/127630617-df6cd149-ea17-48aa-b04e-222a347506e4.png)
   Minutes and hours save limited data, you write like this, only the data in the next few seconds，the data obtained is wrong，not the same as the expected value of the design


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] codecov-commenter edited a comment on pull request #3191: [ISSUE #3190] make samplingInMinutes samplingInHour collected data more accurate

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3191:
URL: https://github.com/apache/rocketmq/pull/3191#issuecomment-888855815


   # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3191?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3191](https://codecov.io/gh/apache/rocketmq/pull/3191?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2da2602) into [develop](https://codecov.io/gh/apache/rocketmq/commit/6f7b0d6a2daaf4592f44d10608dd57ea1bc79e2f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6f7b0d6) will **increase** coverage by `0.93%`.
   > The diff coverage is `71.42%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq/pull/3191/graphs/tree.svg?width=650&height=150&src=pr&token=4w0sxP1wZv&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/rocketmq/pull/3191?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop    #3191      +/-   ##
   =============================================
   + Coverage      47.45%   48.39%   +0.93%     
   - Complexity      4053     4627     +574     
   =============================================
     Files            478      552      +74     
     Lines          32899    37178    +4279     
     Branches        4372     5002     +630     
   =============================================
   + Hits           15613    17992    +2379     
   - Misses         15256    16947    +1691     
   - Partials        2030     2239     +209     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/3191?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...va/org/apache/rocketmq/common/stats/StatsItem.java](https://codecov.io/gh/apache/rocketmq/pull/3191/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNJdGVtLmphdmE=) | `51.07% <71.42%> (+1.07%)` | :arrow_up: |
   | [...ketmq/common/protocol/body/ConsumerConnection.java](https://codecov.io/gh/apache/rocketmq/pull/3191/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvYm9keS9Db25zdW1lckNvbm5lY3Rpb24uamF2YQ==) | `95.83% <0.00%> (-4.17%)` | :arrow_down: |
   | [...pl/consumer/ConsumeMessageConcurrentlyService.java](https://codecov.io/gh/apache/rocketmq/pull/3191/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Db25zdW1lTWVzc2FnZUNvbmN1cnJlbnRseVNlcnZpY2UuamF2YQ==) | `47.57% <0.00%> (-0.98%)` | :arrow_down: |
   | [...a/org/apache/rocketmq/store/StoreStatsService.java](https://codecov.io/gh/apache/rocketmq/pull/3191/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL1N0b3JlU3RhdHNTZXJ2aWNlLmphdmE=) | `29.50% <0.00%> (-0.66%)` | :arrow_down: |
   | [...lient/impl/consumer/DefaultMQPushConsumerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/3191/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9EZWZhdWx0TVFQdXNoQ29uc3VtZXJJbXBsLmphdmE=) | `39.64% <0.00%> (-0.53%)` | :arrow_down: |
   | [...he/rocketmq/client/impl/consumer/ProcessQueue.java](https://codecov.io/gh/apache/rocketmq/pull/3191/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Qcm9jZXNzUXVldWUuamF2YQ==) | `59.06% <0.00%> (-0.47%)` | :arrow_down: |
   | [...ketmq/client/impl/consumer/PullMessageService.java](https://codecov.io/gh/apache/rocketmq/pull/3191/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9QdWxsTWVzc2FnZVNlcnZpY2UuamF2YQ==) | `75.55% <0.00%> (ø)` | |
   | [...etmq/client/latency/LatencyFaultToleranceImpl.java](https://codecov.io/gh/apache/rocketmq/pull/3191/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvbGF0ZW5jeS9MYXRlbmN5RmF1bHRUb2xlcmFuY2VJbXBsLmphdmE=) | `50.00% <0.00%> (ø)` | |
   | [...he/rocketmq/test/client/rmq/RMQNormalProducer.java](https://codecov.io/gh/apache/rocketmq/pull/3191/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC9jbGllbnQvcm1xL1JNUU5vcm1hbFByb2R1Y2VyLmphdmE=) | `79.78% <0.00%> (ø)` | |
   | ... and [88 more](https://codecov.io/gh/apache/rocketmq/pull/3191/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/3191?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3191?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6f7b0d6...2da2602](https://codecov.io/gh/apache/rocketmq/pull/3191?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] makabakaboom commented on pull request #3191: [ISSUE #3190] make samplingInMinutes samplingInHour collected data more accurate

Posted by GitBox <gi...@apache.org>.
makabakaboom commented on pull request #3191:
URL: https://github.com/apache/rocketmq/pull/3191#issuecomment-890472671


   csListMinute，csListHour，csListDay列表分别保存一分钟、一小时、一天的点，分别对应有6、6、24个点，computeStatsData通过调用栈我看用途大多数都是去计算系统中一些统计值，如topic一段时间内的消息量、TPS等统计值。按照原实现，比如我看到的topic的小时级别数据和天级别的数据就具有一定的延迟性，比如小时级别的数据我就需要10分钟后才能精确，天的数据就有1小时延迟。修改代码只是在统计分钟级别的时候去更新了小时和天级别的最后一个值的数据，这样小时级别和天级别还是原设计的6、24个点，只是小时改为统计1h+10min内的实时值，一天改为统计1D + 1h内的实时值。或许这里修改不是最优的实现方式，但是我认为这里确实存在统计延迟


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] makabakaboom commented on pull request #3191: [ISSUE #3190] make samplingInMinutes samplingInHour collected data more accurate

Posted by GitBox <gi...@apache.org>.
makabakaboom commented on pull request #3191:
URL: https://github.com/apache/rocketmq/pull/3191#issuecomment-890357214


   > ![image](https://user-images.githubusercontent.com/29321745/127630617-df6cd149-ea17-48aa-b04e-222a347506e4.png)
   > Minutes and hours save limited data, you write like this, only the data in the next few seconds，the data obtained is wrong，not the same as the expected value of the design
   
   可以从新review这个PR，从代码中可以看到最近一小时和最近一天的统计分别有10分钟和一个小时延迟，这样缺乏统计的实时性，可能导致查询到结果最近一小时和最近一天的值反而比最近一分钟小。而修改后，利用每10s的采样值去替换掉最近一小时和最近一天的集合中最后一个统计值，这样能达到较实时的效果，而且也没有违反原集合的意义，也能达到和原集合相同的效果，集合中的最后一个对象的前面对象集合依旧相差对应period的时间差。最终效果是统计值比原来更有实时性


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] panzhi33 commented on pull request #3191: [ISSUE #3190] make samplingInMinutes samplingInHour collected data more accurate

Posted by GitBox <gi...@apache.org>.
panzhi33 commented on pull request #3191:
URL: https://github.com/apache/rocketmq/pull/3191#issuecomment-889766188


   ![image](https://user-images.githubusercontent.com/29321745/127630617-df6cd149-ea17-48aa-b04e-222a347506e4.png)
   Minutes and hours save limited data, you write like this, only the data in the next few seconds，the data obtained is wrong


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] makabakaboom commented on pull request #3191: [ISSUE #3190] make samplingInMinutes samplingInHour collected data more accurate

Posted by GitBox <gi...@apache.org>.
makabakaboom commented on pull request #3191:
URL: https://github.com/apache/rocketmq/pull/3191#issuecomment-890651759


   > > csListMinute，csListHour，csListDay列表分别保存一分钟、一小时、一天的点，分别对应有6、6、24个点，computeStatsData通过调用栈我看用途大多数都是去计算系统中一些统计值，如topic一段时间内的消息量、TPS等统计值。按照原实现，比如我看到的topic的小时级别数据和天级别的数据就具有一定的延迟性，比如小时级别的数据我就需要10分钟后才能精确，天的数据就有1小时延迟。修改代码只是在统计分钟级别的时候去更新了小时和天级别的最后一个值的数据，这样小时级别和天级别还是原设计的6、24个点，只是小时改为统计1h+10min内的实时值，一天改为统计1D + 1h内的实时值。或许这里修改不是最优的实现方式，但是我认为这里确实存在统计延迟
   > 
   > 你是对的,我的问题,没看仔细.有个问题问下,为啥不放在synchronized代码块里面了
   
   考虑synchronized代码块里面主要是对 对应列表有影响的放在里面，且每个采样方法里面都有对应列表锁，而一小时和一天修改跟一分钟列表无关系，没必要在一分钟的synchronized代码块里面


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls edited a comment on pull request #3191: [ISSUE #3190] make samplingInMinutes samplingInHour collected data more accurate

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3191:
URL: https://github.com/apache/rocketmq/pull/3191#issuecomment-888856287


   
   [![Coverage Status](https://coveralls.io/builds/41823211/badge)](https://coveralls.io/builds/41823211)
   
   Coverage increased (+0.1%) to 54.137% when pulling **2da260238ed91706b44a442dca6700d2d6bd9ab5 on makabakaboom:patch-2** into **6f7b0d6a2daaf4592f44d10608dd57ea1bc79e2f on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] codecov-commenter commented on pull request #3191: [ISSUE #3190] make samplingInMinutes samplingInHour collected data more accurate

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #3191:
URL: https://github.com/apache/rocketmq/pull/3191#issuecomment-888855815


   # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3191?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3191](https://codecov.io/gh/apache/rocketmq/pull/3191?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2da2602) into [develop](https://codecov.io/gh/apache/rocketmq/commit/6f7b0d6a2daaf4592f44d10608dd57ea1bc79e2f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6f7b0d6) will **increase** coverage by `0.05%`.
   > The diff coverage is `71.42%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq/pull/3191/graphs/tree.svg?width=650&height=150&src=pr&token=4w0sxP1wZv&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/rocketmq/pull/3191?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop    #3191      +/-   ##
   =============================================
   + Coverage      47.45%   47.50%   +0.05%     
   - Complexity      4053     4059       +6     
   =============================================
     Files            478      478              
     Lines          32899    32918      +19     
     Branches        4372     4376       +4     
   =============================================
   + Hits           15613    15639      +26     
   + Misses         15256    15249       -7     
     Partials        2030     2030              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/3191?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...va/org/apache/rocketmq/common/stats/StatsItem.java](https://codecov.io/gh/apache/rocketmq/pull/3191/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNJdGVtLmphdmE=) | `51.07% <71.42%> (+1.07%)` | :arrow_up: |
   | [...ketmq/common/protocol/body/ConsumerConnection.java](https://codecov.io/gh/apache/rocketmq/pull/3191/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvYm9keS9Db25zdW1lckNvbm5lY3Rpb24uamF2YQ==) | `95.83% <0.00%> (-4.17%)` | :arrow_down: |
   | [...a/org/apache/rocketmq/store/StoreStatsService.java](https://codecov.io/gh/apache/rocketmq/pull/3191/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL1N0b3JlU3RhdHNTZXJ2aWNlLmphdmE=) | `28.85% <0.00%> (-1.32%)` | :arrow_down: |
   | [...pl/consumer/ConsumeMessageConcurrentlyService.java](https://codecov.io/gh/apache/rocketmq/pull/3191/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Db25zdW1lTWVzc2FnZUNvbmN1cnJlbnRseVNlcnZpY2UuamF2YQ==) | `47.57% <0.00%> (-0.98%)` | :arrow_down: |
   | [...he/rocketmq/client/impl/consumer/ProcessQueue.java](https://codecov.io/gh/apache/rocketmq/pull/3191/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Qcm9jZXNzUXVldWUuamF2YQ==) | `58.60% <0.00%> (-0.94%)` | :arrow_down: |
   | [...lient/impl/consumer/DefaultMQPushConsumerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/3191/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9EZWZhdWx0TVFQdXNoQ29uc3VtZXJJbXBsLmphdmE=) | `39.64% <0.00%> (-0.53%)` | :arrow_down: |
   | [...ketmq/client/impl/consumer/PullMessageService.java](https://codecov.io/gh/apache/rocketmq/pull/3191/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9QdWxsTWVzc2FnZVNlcnZpY2UuamF2YQ==) | `75.55% <0.00%> (ø)` | |
   | [...etmq/client/latency/LatencyFaultToleranceImpl.java](https://codecov.io/gh/apache/rocketmq/pull/3191/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvbGF0ZW5jeS9MYXRlbmN5RmF1bHRUb2xlcmFuY2VJbXBsLmphdmE=) | `50.00% <0.00%> (ø)` | |
   | [...mq/client/impl/producer/DefaultMQProducerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/3191/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9wcm9kdWNlci9EZWZhdWx0TVFQcm9kdWNlckltcGwuamF2YQ==) | `44.77% <0.00%> (+0.24%)` | :arrow_up: |
   | ... and [5 more](https://codecov.io/gh/apache/rocketmq/pull/3191/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/3191?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3191?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6f7b0d6...2da2602](https://codecov.io/gh/apache/rocketmq/pull/3191?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] panzhi33 commented on pull request #3191: [ISSUE #3190] make samplingInMinutes samplingInHour collected data more accurate

Posted by GitBox <gi...@apache.org>.
panzhi33 commented on pull request #3191:
URL: https://github.com/apache/rocketmq/pull/3191#issuecomment-890438812


   这三个方法,统计的是分钟级别的,小时级别的,天级别的数据.要实时性,就看samplingInSeconds 分钟级别的数据就行.目前你改动的,导致看不到小时级别,天级别的数据,和原来的设计不符.
   你可以看下这个方法,看下会用这个数据来做什么org.apache.rocketmq.common.stats.StatsItem#computeStatsData


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] RongtongJin closed pull request #3191: [ISSUE #3190] make samplingInMinutes samplingInHour collected data more accurate

Posted by GitBox <gi...@apache.org>.
RongtongJin closed pull request #3191:
URL: https://github.com/apache/rocketmq/pull/3191


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #3191: [ISSUE #3190] make samplingInMinutes samplingInHour collected data more accurate

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3191:
URL: https://github.com/apache/rocketmq/pull/3191#issuecomment-888856287


   
   [![Coverage Status](https://coveralls.io/builds/41741429/badge)](https://coveralls.io/builds/41741429)
   
   Coverage increased (+0.005%) to 54.046% when pulling **2da260238ed91706b44a442dca6700d2d6bd9ab5 on makabakaboom:patch-2** into **6f7b0d6a2daaf4592f44d10608dd57ea1bc79e2f on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org