You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Dmitry Pekar <dm...@stealth.ly> on 2015/01/14 11:55:36 UTC
Re: Review Request 28481: Patch for KAFKA-1792
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28481/
-----------------------------------------------------------
(Updated Jan. 14, 2015, 10:55 a.m.)
Review request for kafka.
Bugs: KAFKA-1792
https://issues.apache.org/jira/browse/KAFKA-1792
Repository: kafka
Description (updated)
-------
KAFKA-1792: CR
KAFKA-1792: CR2
KAFKA-1792: merge of KAFKA-1753
KAFKA-1792: generate renamed to rebalance
Diffs (updated)
-----
core/src/main/scala/kafka/admin/AdminUtils.scala 28b12c7b89a56c113b665fbde1b95f873f8624a3
core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala 979992b68af3723cd229845faff81c641123bb88
core/src/test/scala/unit/kafka/admin/AdminTest.scala e28979827110dfbbb92fe5b152e7f1cc973de400
topics.json ff011ed381e781b9a177036001d44dca3eac586f
Diff: https://reviews.apache.org/r/28481/diff/
Testing
-------
Thanks,
Dmitry Pekar
Re: Review Request 28481: Patch for KAFKA-1792
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28481/#review74760
-----------------------------------------------------------
core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala
<https://reviews.apache.org/r/28481/#comment121477>
I'm not sure if this makes sense. Basically, the entire point of --rebalance is to figure out the best balanced replica placement with the minimum number of replicas moved. If you ask the user to list the topics or the brokers, this may not lead to the most balanced replica placement in the cluster. If we did this, then the only thing the user would want to do is limit the number of replicas moved in one go, in order to manually throttle the data movement in the cluster. It is ok to do that in a separate JIRA.
Same with the replace broker use case. Replacing a broker is much easier to use if it is a separate option (--replace-broker --from-broker 1 --to-broker 2). Though if you want to cover that in a separate JIRA, that's fine.
- Neha Narkhede
On Feb. 26, 2015, 2:58 p.m., Dmitry Pekar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28481/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2015, 2:58 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1792
> https://issues.apache.org/jira/browse/KAFKA-1792
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1792: CR
>
>
> KAFKA-1792: CR2
>
>
> KAFKA-1792: merge of KAFKA-1753
>
>
> KAFKA-1792: generate renamed to rebalance
>
>
> KAFKA-1792: --rebalance renamed back to --generate, removed --decomission-broker command
>
>
> KAFKA-1792: added back --decommission-broker command
>
>
> KAFKA-1792: --generate renamed back to --rebalance
>
>
> KAFKA-1792: added old --generate command for compatibility
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/admin/AdminUtils.scala b700110f2d7f1ede235af55d8e37e1b5592c6c7d
> core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala 979992b68af3723cd229845faff81c641123bb88
> core/src/test/scala/unit/kafka/admin/AdminTest.scala e28979827110dfbbb92fe5b152e7f1cc973de400
> topics.json ff011ed381e781b9a177036001d44dca3eac586f
>
> Diff: https://reviews.apache.org/r/28481/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dmitry Pekar
>
>
Re: Review Request 28481: Patch for KAFKA-1792
Posted by Dmitry Pekar <dm...@stealth.ly>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28481/
-----------------------------------------------------------
(Updated Feb. 26, 2015, 2:58 p.m.)
Review request for kafka.
Bugs: KAFKA-1792
https://issues.apache.org/jira/browse/KAFKA-1792
Repository: kafka
Description (updated)
-------
KAFKA-1792: CR
KAFKA-1792: CR2
KAFKA-1792: merge of KAFKA-1753
KAFKA-1792: generate renamed to rebalance
KAFKA-1792: --rebalance renamed back to --generate, removed --decomission-broker command
KAFKA-1792: added back --decommission-broker command
KAFKA-1792: --generate renamed back to --rebalance
KAFKA-1792: added old --generate command for compatibility
Diffs (updated)
-----
core/src/main/scala/kafka/admin/AdminUtils.scala b700110f2d7f1ede235af55d8e37e1b5592c6c7d
core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala 979992b68af3723cd229845faff81c641123bb88
core/src/test/scala/unit/kafka/admin/AdminTest.scala e28979827110dfbbb92fe5b152e7f1cc973de400
topics.json ff011ed381e781b9a177036001d44dca3eac586f
Diff: https://reviews.apache.org/r/28481/diff/
Testing
-------
Thanks,
Dmitry Pekar
Re: Review Request 28481: Patch for KAFKA-1792
Posted by Dmitry Pekar <dm...@stealth.ly>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28481/
-----------------------------------------------------------
(Updated Feb. 13, 2015, 7:07 p.m.)
Review request for kafka.
Bugs: KAFKA-1792
https://issues.apache.org/jira/browse/KAFKA-1792
Repository: kafka
Description (updated)
-------
KAFKA-1792: CR
KAFKA-1792: CR2
KAFKA-1792: merge of KAFKA-1753
KAFKA-1792: generate renamed to rebalance
KAFKA-1792: --rebalance renamed back to --generate, removed --decomission-broker command
KAFKA-1792: added back --decommission-broker command
Diffs (updated)
-----
core/src/main/scala/kafka/admin/AdminUtils.scala 28b12c7b89a56c113b665fbde1b95f873f8624a3
core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala 979992b68af3723cd229845faff81c641123bb88
core/src/test/scala/unit/kafka/admin/AdminTest.scala e28979827110dfbbb92fe5b152e7f1cc973de400
topics.json ff011ed381e781b9a177036001d44dca3eac586f
Diff: https://reviews.apache.org/r/28481/diff/
Testing
-------
Thanks,
Dmitry Pekar
Re: Review Request 28481: Patch for KAFKA-1792
Posted by Dmitry Pekar <dm...@stealth.ly>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28481/
-----------------------------------------------------------
(Updated Jan. 27, 2015, 5:09 p.m.)
Review request for kafka.
Bugs: KAFKA-1792
https://issues.apache.org/jira/browse/KAFKA-1792
Repository: kafka
Description (updated)
-------
KAFKA-1792: CR
KAFKA-1792: CR2
KAFKA-1792: merge of KAFKA-1753
KAFKA-1792: generate renamed to rebalance
KAFKA-1792: --rebalance renamed back to --generate, removed --decomission-broker command
Diffs (updated)
-----
core/src/main/scala/kafka/admin/AdminUtils.scala 28b12c7b89a56c113b665fbde1b95f873f8624a3
core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala 979992b68af3723cd229845faff81c641123bb88
core/src/test/scala/unit/kafka/admin/AdminTest.scala e28979827110dfbbb92fe5b152e7f1cc973de400
topics.json ff011ed381e781b9a177036001d44dca3eac586f
Diff: https://reviews.apache.org/r/28481/diff/
Testing
-------
Thanks,
Dmitry Pekar